diff options
author | Hannes Eder <hannes@hanneseder.net> | 2009-02-10 13:44:12 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-02-11 04:15:41 -0500 |
commit | 4fd2735881bf4d8bf5e30979f31fc2f1b1d505fa (patch) | |
tree | 09f923acc762038aad786e1acf1065db9dd072eb /kernel/trace/trace.c | |
parent | 4040068dce64f75c9d414f41fc2fb314a44bad65 (diff) |
tracing: fix sparse warnings: make symbols static
Impact: make global variables and a global function static
The function '__trace_userstack' does not seem to have a caller, so it
is commented out.
Fix this sparse warnings:
kernel/trace/trace.c:82:5: warning: symbol 'tracing_disabled' was not declared. Should it be static?
kernel/trace/trace.c:600:10: warning: symbol 'trace_record_cmdline_disabled' was not declared. Should it be static?
kernel/trace/trace.c:957:6: warning: symbol '__trace_userstack' was not declared. Should it be static?
kernel/trace/trace.c:1694:5: warning: symbol 'tracing_release' was not declared. Should it be static?
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/trace/trace.c')
-rw-r--r-- | kernel/trace/trace.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index d7c175a442df..c157ba70f30c 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
@@ -80,7 +80,7 @@ static int dummy_set_flag(u32 old_flags, u32 bit, int set) | |||
80 | * of the tracer is successful. But that is the only place that sets | 80 | * of the tracer is successful. But that is the only place that sets |
81 | * this back to zero. | 81 | * this back to zero. |
82 | */ | 82 | */ |
83 | int tracing_disabled = 1; | 83 | static int tracing_disabled = 1; |
84 | 84 | ||
85 | static DEFINE_PER_CPU(local_t, ftrace_cpu_disabled); | 85 | static DEFINE_PER_CPU(local_t, ftrace_cpu_disabled); |
86 | 86 | ||
@@ -626,7 +626,7 @@ static int cmdline_idx; | |||
626 | static DEFINE_SPINLOCK(trace_cmdline_lock); | 626 | static DEFINE_SPINLOCK(trace_cmdline_lock); |
627 | 627 | ||
628 | /* temporary disable recording */ | 628 | /* temporary disable recording */ |
629 | atomic_t trace_record_cmdline_disabled __read_mostly; | 629 | static atomic_t trace_record_cmdline_disabled __read_mostly; |
630 | 630 | ||
631 | static void trace_init_cmdlines(void) | 631 | static void trace_init_cmdlines(void) |
632 | { | 632 | { |
@@ -983,10 +983,12 @@ static void ftrace_trace_userstack(struct trace_array *tr, | |||
983 | #endif | 983 | #endif |
984 | } | 984 | } |
985 | 985 | ||
986 | void __trace_userstack(struct trace_array *tr, unsigned long flags) | 986 | #ifdef UNUSED |
987 | static void __trace_userstack(struct trace_array *tr, unsigned long flags) | ||
987 | { | 988 | { |
988 | ftrace_trace_userstack(tr, flags, preempt_count()); | 989 | ftrace_trace_userstack(tr, flags, preempt_count()); |
989 | } | 990 | } |
991 | #endif /* UNUSED */ | ||
990 | 992 | ||
991 | static void | 993 | static void |
992 | ftrace_trace_special(void *__tr, | 994 | ftrace_trace_special(void *__tr, |
@@ -1720,7 +1722,7 @@ int tracing_open_generic(struct inode *inode, struct file *filp) | |||
1720 | return 0; | 1722 | return 0; |
1721 | } | 1723 | } |
1722 | 1724 | ||
1723 | int tracing_release(struct inode *inode, struct file *file) | 1725 | static int tracing_release(struct inode *inode, struct file *file) |
1724 | { | 1726 | { |
1725 | struct seq_file *m = (struct seq_file *)file->private_data; | 1727 | struct seq_file *m = (struct seq_file *)file->private_data; |
1726 | struct trace_iterator *iter = m->private; | 1728 | struct trace_iterator *iter = m->private; |