aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/time
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2015-03-25 08:08:27 -0400
committerIngo Molnar <mingo@kernel.org>2015-04-01 08:22:59 -0400
commitdb6f672ef11d7a3c5aa128a3c3e57c92580a25f7 (patch)
treeae952d977285371a08f1ab951e2c8830ccd08429 /kernel/time
parentc1797baf6880174f899ce3960d0598f5bbeeb7ff (diff)
clockevents: Remove extra local_irq_save() in clockevents_exchange_device()
Called with 'clockevents_lock' held and interrupts disabled already. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Link: http://lkml.kernel.org/r/51005827.yXt5tjZMBs@vostro.rjw.lan Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/time')
-rw-r--r--kernel/time/clockevents.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index 3531beecbe95..b73002718536 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -595,14 +595,12 @@ void clockevents_handle_noop(struct clock_event_device *dev)
595 * @old: device to release (can be NULL) 595 * @old: device to release (can be NULL)
596 * @new: device to request (can be NULL) 596 * @new: device to request (can be NULL)
597 * 597 *
598 * Called from the notifier chain. clockevents_lock is held already 598 * Called from various tick functions with clockevents_lock held and
599 * interrupts disabled.
599 */ 600 */
600void clockevents_exchange_device(struct clock_event_device *old, 601void clockevents_exchange_device(struct clock_event_device *old,
601 struct clock_event_device *new) 602 struct clock_event_device *new)
602{ 603{
603 unsigned long flags;
604
605 local_irq_save(flags);
606 /* 604 /*
607 * Caller releases a clock event device. We queue it into the 605 * Caller releases a clock event device. We queue it into the
608 * released list and do a notify add later. 606 * released list and do a notify add later.
@@ -618,7 +616,6 @@ void clockevents_exchange_device(struct clock_event_device *old,
618 BUG_ON(new->state != CLOCK_EVT_STATE_DETACHED); 616 BUG_ON(new->state != CLOCK_EVT_STATE_DETACHED);
619 clockevents_shutdown(new); 617 clockevents_shutdown(new);
620 } 618 }
621 local_irq_restore(flags);
622} 619}
623 620
624/** 621/**