diff options
| author | Thomas Gleixner <tglx@linutronix.de> | 2008-02-01 11:45:13 -0500 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2008-02-01 11:45:13 -0500 |
| commit | 1001d0a9ee74a468077dfd4da0565174e88de26b (patch) | |
| tree | 8775592b23e8049700ff98a7bdbcf9c802a0f127 /kernel/time | |
| parent | 3588a085cd52ef080bf72df772378e1ba6bb292f (diff) | |
timekeeping: update xtime_cache when time(zone) changes
xtime_cache needs to be updated whenever xtime and or wall_to_monotic
are changed. Otherwise users of xtime_cache might see a stale (and in
the case of timezone changes utterly wrong) value until the next
update happens.
Fixup the obvious places, which miss this update.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: John Stultz <johnstul@us.ibm.com>
Tested-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/time')
| -rw-r--r-- | kernel/time/timekeeping.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 092a2366b5a9..cd5dbc4579c9 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c | |||
| @@ -47,7 +47,7 @@ struct timespec wall_to_monotonic __attribute__ ((aligned (16))); | |||
| 47 | static unsigned long total_sleep_time; /* seconds */ | 47 | static unsigned long total_sleep_time; /* seconds */ |
| 48 | 48 | ||
| 49 | static struct timespec xtime_cache __attribute__ ((aligned (16))); | 49 | static struct timespec xtime_cache __attribute__ ((aligned (16))); |
| 50 | static inline void update_xtime_cache(u64 nsec) | 50 | void update_xtime_cache(u64 nsec) |
| 51 | { | 51 | { |
| 52 | xtime_cache = xtime; | 52 | xtime_cache = xtime; |
| 53 | timespec_add_ns(&xtime_cache, nsec); | 53 | timespec_add_ns(&xtime_cache, nsec); |
| @@ -145,6 +145,7 @@ int do_settimeofday(struct timespec *tv) | |||
| 145 | 145 | ||
| 146 | set_normalized_timespec(&xtime, sec, nsec); | 146 | set_normalized_timespec(&xtime, sec, nsec); |
| 147 | set_normalized_timespec(&wall_to_monotonic, wtm_sec, wtm_nsec); | 147 | set_normalized_timespec(&wall_to_monotonic, wtm_sec, wtm_nsec); |
| 148 | update_xtime_cache(0); | ||
| 148 | 149 | ||
| 149 | clock->error = 0; | 150 | clock->error = 0; |
| 150 | ntp_clear(); | 151 | ntp_clear(); |
| @@ -252,8 +253,8 @@ void __init timekeeping_init(void) | |||
| 252 | xtime.tv_nsec = 0; | 253 | xtime.tv_nsec = 0; |
| 253 | set_normalized_timespec(&wall_to_monotonic, | 254 | set_normalized_timespec(&wall_to_monotonic, |
| 254 | -xtime.tv_sec, -xtime.tv_nsec); | 255 | -xtime.tv_sec, -xtime.tv_nsec); |
| 256 | update_xtime_cache(0); | ||
| 255 | total_sleep_time = 0; | 257 | total_sleep_time = 0; |
| 256 | |||
| 257 | write_sequnlock_irqrestore(&xtime_lock, flags); | 258 | write_sequnlock_irqrestore(&xtime_lock, flags); |
| 258 | } | 259 | } |
| 259 | 260 | ||
| @@ -290,6 +291,7 @@ static int timekeeping_resume(struct sys_device *dev) | |||
| 290 | } | 291 | } |
| 291 | /* Make sure that we have the correct xtime reference */ | 292 | /* Make sure that we have the correct xtime reference */ |
| 292 | timespec_add_ns(&xtime, timekeeping_suspend_nsecs); | 293 | timespec_add_ns(&xtime, timekeeping_suspend_nsecs); |
| 294 | update_xtime_cache(0); | ||
| 293 | /* re-base the last cycle value */ | 295 | /* re-base the last cycle value */ |
| 294 | clock->cycle_last = clocksource_read(clock); | 296 | clock->cycle_last = clocksource_read(clock); |
| 295 | clock->error = 0; | 297 | clock->error = 0; |
