diff options
author | Peter Zijlstra <peterz@infradead.org> | 2013-08-19 09:20:21 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2013-09-02 02:27:37 -0400 |
commit | 6906a40839198f33dbb56d20e644c01e00663952 (patch) | |
tree | 27b31ae4522f4191cb82c17cf30b918b94562412 /kernel/sched | |
parent | 3ae11c90fd055ba1b1b03a014f851b395bdd26ff (diff) |
sched/fair: Optimize find_busiest_queue()
Use for_each_cpu_and() and thereby avoid computing the capacity for
CPUs we know we're not interested in.
Reviewed-by: Paul Turner <pjt@google.com>
Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/n/tip-lppceyv6kb3a19g8spmrn20b@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/sched')
-rw-r--r-- | kernel/sched/fair.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index ccf20e76b6b2..bedd30b168a5 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c | |||
@@ -4946,7 +4946,7 @@ static struct rq *find_busiest_queue(struct lb_env *env, | |||
4946 | unsigned long busiest_load = 0, busiest_power = 1; | 4946 | unsigned long busiest_load = 0, busiest_power = 1; |
4947 | int i; | 4947 | int i; |
4948 | 4948 | ||
4949 | for_each_cpu(i, sched_group_cpus(group)) { | 4949 | for_each_cpu_and(i, sched_group_cpus(group), env->cpus) { |
4950 | unsigned long power = power_of(i); | 4950 | unsigned long power = power_of(i); |
4951 | unsigned long capacity = DIV_ROUND_CLOSEST(power, | 4951 | unsigned long capacity = DIV_ROUND_CLOSEST(power, |
4952 | SCHED_POWER_SCALE); | 4952 | SCHED_POWER_SCALE); |
@@ -4955,9 +4955,6 @@ static struct rq *find_busiest_queue(struct lb_env *env, | |||
4955 | if (!capacity) | 4955 | if (!capacity) |
4956 | capacity = fix_small_capacity(env->sd, group); | 4956 | capacity = fix_small_capacity(env->sd, group); |
4957 | 4957 | ||
4958 | if (!cpumask_test_cpu(i, env->cpus)) | ||
4959 | continue; | ||
4960 | |||
4961 | rq = cpu_rq(i); | 4958 | rq = cpu_rq(i); |
4962 | wl = weighted_cpuload(i); | 4959 | wl = weighted_cpuload(i); |
4963 | 4960 | ||