diff options
author | Tejun Heo <tj@kernel.org> | 2009-11-13 04:33:53 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-11-15 03:59:54 -0500 |
commit | 498657a478c60be092208422fefa9c7b248729c2 (patch) | |
tree | c04542330fbbfaaa863fbec0f565b79c89df7033 /kernel/sched.c | |
parent | 055a00865dcfc8e61f3cbefbb879c9577bd36ae5 (diff) |
sched, kvm: Fix race condition involving sched_in_preempt_notifers
In finish_task_switch(), fire_sched_in_preempt_notifiers() is
called after finish_lock_switch().
However, depending on architecture, preemption can be enabled after
finish_lock_switch() which breaks the semantics of preempt
notifiers.
So move it before finish_arch_switch(). This also makes the in-
notifiers symmetric to out- notifiers in terms of locking - now
both are called under rq lock.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Avi Kivity <avi@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <4AFD2801.7020900@kernel.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched.c')
-rw-r--r-- | kernel/sched.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched.c b/kernel/sched.c index 701eca4958a2..cea2beac7909 100644 --- a/kernel/sched.c +++ b/kernel/sched.c | |||
@@ -2758,9 +2758,9 @@ static void finish_task_switch(struct rq *rq, struct task_struct *prev) | |||
2758 | prev_state = prev->state; | 2758 | prev_state = prev->state; |
2759 | finish_arch_switch(prev); | 2759 | finish_arch_switch(prev); |
2760 | perf_event_task_sched_in(current, cpu_of(rq)); | 2760 | perf_event_task_sched_in(current, cpu_of(rq)); |
2761 | fire_sched_in_preempt_notifiers(current); | ||
2761 | finish_lock_switch(rq, prev); | 2762 | finish_lock_switch(rq, prev); |
2762 | 2763 | ||
2763 | fire_sched_in_preempt_notifiers(current); | ||
2764 | if (mm) | 2764 | if (mm) |
2765 | mmdrop(mm); | 2765 | mmdrop(mm); |
2766 | if (unlikely(prev_state == TASK_DEAD)) { | 2766 | if (unlikely(prev_state == TASK_DEAD)) { |