aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/sched.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2010-03-15 05:10:10 -0400
committerIngo Molnar <mingo@elte.hu>2010-04-02 14:12:01 -0400
commit1445c08d06c5594895b4fae952ef8a457e89c390 (patch)
treee6fe92454d978ec8b7b84511661c7c5965307bf8 /kernel/sched.c
parent897f0b3c3ff40b443c84e271bef19bd6ae885195 (diff)
sched: move_task_off_dead_cpu(): Take rq->lock around select_fallback_rq()
move_task_off_dead_cpu()->select_fallback_rq() reads/updates ->cpus_allowed lockless. We can race with set_cpus_allowed() running in parallel. Change it to take rq->lock around select_fallback_rq(). Note that it is not trivial to move this spin_lock() into select_fallback_rq(), we must recheck the task was not migrated after we take the lock and other callers do not need this lock. To avoid the races with other callers of select_fallback_rq() which rely on TASK_WAKING, we also check p->state != TASK_WAKING and do nothing otherwise. The owner of TASK_WAKING must update ->cpus_allowed and choose the correct CPU anyway, and the subsequent __migrate_task() is just meaningless because p->se.on_rq must be false. Alternatively, we could change select_task_rq() to take rq->lock right after it calls sched_class->select_task_rq(), but this looks a bit ugly. Also, change it to not assume irqs are disabled and absorb __migrate_task_irq(). Signed-off-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl> LKML-Reference: <20100315091010.GA9131@redhat.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched.c')
-rw-r--r--kernel/sched.c30
1 files changed, 15 insertions, 15 deletions
diff --git a/kernel/sched.c b/kernel/sched.c
index c0b3ebc16317..27774b5aeb61 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -5448,29 +5448,29 @@ static int migration_thread(void *data)
5448} 5448}
5449 5449
5450#ifdef CONFIG_HOTPLUG_CPU 5450#ifdef CONFIG_HOTPLUG_CPU
5451
5452static int __migrate_task_irq(struct task_struct *p, int src_cpu, int dest_cpu)
5453{
5454 int ret;
5455
5456 local_irq_disable();
5457 ret = __migrate_task(p, src_cpu, dest_cpu);
5458 local_irq_enable();
5459 return ret;
5460}
5461
5462/* 5451/*
5463 * Figure out where task on dead CPU should go, use force if necessary. 5452 * Figure out where task on dead CPU should go, use force if necessary.
5464 */ 5453 */
5465static void move_task_off_dead_cpu(int dead_cpu, struct task_struct *p) 5454static void move_task_off_dead_cpu(int dead_cpu, struct task_struct *p)
5466{ 5455{
5467 int dest_cpu; 5456 struct rq *rq = cpu_rq(dead_cpu);
5468 5457 int needs_cpu, uninitialized_var(dest_cpu);
5458 unsigned long flags;
5469again: 5459again:
5470 dest_cpu = select_fallback_rq(dead_cpu, p); 5460 local_irq_save(flags);
5461
5462 raw_spin_lock(&rq->lock);
5463 needs_cpu = (task_cpu(p) == dead_cpu) && (p->state != TASK_WAKING);
5464 if (needs_cpu)
5465 dest_cpu = select_fallback_rq(dead_cpu, p);
5466 raw_spin_unlock(&rq->lock);
5471 5467
5472 /* It can have affinity changed while we were choosing. */ 5468 /* It can have affinity changed while we were choosing. */
5473 if (unlikely(!__migrate_task_irq(p, dead_cpu, dest_cpu))) 5469 if (needs_cpu)
5470 needs_cpu = !__migrate_task(p, dead_cpu, dest_cpu);
5471 local_irq_restore(flags);
5472
5473 if (unlikely(needs_cpu))
5474 goto again; 5474 goto again;
5475} 5475}
5476 5476