aboutsummaryrefslogtreecommitdiffstats
path: root/ipc/shm.c
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2014-06-06 19:35:10 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2014-06-06 19:35:10 -0400
commit57d326169e878a1a37b2bccd1cf81f6809ee67b9 (patch)
tree86ed74ae4dc2beaebce1c67b8459f1873b777d3a /ipc/shm.c
parent7b215de3d0abbc4f6daf2efd19e8809af0564490 (diff)
parent0244756edc4b98c129e92c7061d9f383708cf786 (diff)
Merge branch 'akpm' (patches from Andrew Morton) into next
Merge more updates from Andrew Morton: - Most of the rest of MM. This includes "mark remap_file_pages syscall as deprecated" but the actual "replace remap_file_pages syscall with emulation" is held back. I guess we'll need to work out when to pull the trigger on that one. - various minor cleanups to obscure filesystems - the drivers/rtc queue - hfsplus updates - ufs, hpfs, fatfs, affs, reiserfs - Documentation/ - signals - procfs - cpu hotplug - lib/idr.c - rapidio - sysctl - ipc updates * emailed patches from Andrew Morton <akpm@linux-foundation.org>: (171 commits) ufs: sb mutex merge + mutex_destroy powerpc: update comments for generic idle conversion cris: update comments for generic idle conversion idle: remove cpu_idle() forward declarations nbd: zero from and len fields in NBD_CMD_DISCONNECT. mm: convert some level-less printks to pr_* MAINTAINERS: adi-buildroot-devel is moderated MAINTAINERS: add linux-api for review of API/ABI changes mm/kmemleak-test.c: use pr_fmt for logging fs/dlm/debug_fs.c: replace seq_printf by seq_puts fs/dlm/lockspace.c: convert simple_str to kstr fs/dlm/config.c: convert simple_str to kstr mm: mark remap_file_pages() syscall as deprecated mm: memcontrol: remove unnecessary memcg argument from soft limit functions mm: memcontrol: clean up memcg zoneinfo lookup mm/memblock.c: call kmemleak directly from memblock_(alloc|free) mm/mempool.c: update the kmemleak stack trace for mempool allocations lib/radix-tree.c: update the kmemleak stack trace for radix tree allocations mm: introduce kmemleak_update_trace() mm/kmemleak.c: use %u to print ->checksum ...
Diffstat (limited to 'ipc/shm.c')
-rw-r--r--ipc/shm.c23
1 files changed, 15 insertions, 8 deletions
diff --git a/ipc/shm.c b/ipc/shm.c
index 76459616a7fa..89fc354156cb 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -43,7 +43,7 @@
43#include <linux/mount.h> 43#include <linux/mount.h>
44#include <linux/ipc_namespace.h> 44#include <linux/ipc_namespace.h>
45 45
46#include <asm/uaccess.h> 46#include <linux/uaccess.h>
47 47
48#include "util.h" 48#include "util.h"
49 49
@@ -493,7 +493,11 @@ static int newseg(struct ipc_namespace *ns, struct ipc_params *params)
493 if (size < SHMMIN || size > ns->shm_ctlmax) 493 if (size < SHMMIN || size > ns->shm_ctlmax)
494 return -EINVAL; 494 return -EINVAL;
495 495
496 if (ns->shm_tot + numpages > ns->shm_ctlall) 496 if (numpages << PAGE_SHIFT < size)
497 return -ENOSPC;
498
499 if (ns->shm_tot + numpages < ns->shm_tot ||
500 ns->shm_tot + numpages > ns->shm_ctlall)
497 return -ENOSPC; 501 return -ENOSPC;
498 502
499 shp = ipc_rcu_alloc(sizeof(*shp)); 503 shp = ipc_rcu_alloc(sizeof(*shp));
@@ -609,15 +613,15 @@ static inline int shm_more_checks(struct kern_ipc_perm *ipcp,
609SYSCALL_DEFINE3(shmget, key_t, key, size_t, size, int, shmflg) 613SYSCALL_DEFINE3(shmget, key_t, key, size_t, size, int, shmflg)
610{ 614{
611 struct ipc_namespace *ns; 615 struct ipc_namespace *ns;
612 struct ipc_ops shm_ops; 616 static const struct ipc_ops shm_ops = {
617 .getnew = newseg,
618 .associate = shm_security,
619 .more_checks = shm_more_checks,
620 };
613 struct ipc_params shm_params; 621 struct ipc_params shm_params;
614 622
615 ns = current->nsproxy->ipc_ns; 623 ns = current->nsproxy->ipc_ns;
616 624
617 shm_ops.getnew = newseg;
618 shm_ops.associate = shm_security;
619 shm_ops.more_checks = shm_more_checks;
620
621 shm_params.key = key; 625 shm_params.key = key;
622 shm_params.flg = shmflg; 626 shm_params.flg = shmflg;
623 shm_params.u.size = size; 627 shm_params.u.size = size;
@@ -694,7 +698,7 @@ static inline unsigned long copy_shminfo_to_user(void __user *buf, struct shminf
694 out.shmmin = in->shmmin; 698 out.shmmin = in->shmmin;
695 out.shmmni = in->shmmni; 699 out.shmmni = in->shmmni;
696 out.shmseg = in->shmseg; 700 out.shmseg = in->shmseg;
697 out.shmall = in->shmall; 701 out.shmall = in->shmall;
698 702
699 return copy_to_user(buf, &out, sizeof(out)); 703 return copy_to_user(buf, &out, sizeof(out));
700 } 704 }
@@ -1160,6 +1164,9 @@ long do_shmat(int shmid, char __user *shmaddr, int shmflg, ulong *raddr,
1160 down_write(&current->mm->mmap_sem); 1164 down_write(&current->mm->mmap_sem);
1161 if (addr && !(shmflg & SHM_REMAP)) { 1165 if (addr && !(shmflg & SHM_REMAP)) {
1162 err = -EINVAL; 1166 err = -EINVAL;
1167 if (addr + size < addr)
1168 goto invalid;
1169
1163 if (find_vma_intersection(current->mm, addr, addr + size)) 1170 if (find_vma_intersection(current->mm, addr, addr + size))
1164 goto invalid; 1171 goto invalid;
1165 /* 1172 /*