diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-12 21:48:15 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-12 21:48:15 -0400 |
commit | c29deef32e3699e40da3e9e82267610de04e6b54 (patch) | |
tree | 820ab21fe399225f7341499e461ee793a180d414 /include | |
parent | f9da455b93f6ba076935b4ef4589f61e529ae046 (diff) | |
parent | bd01ec1a13f9a327950c8e3080096446c7804753 (diff) |
Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull more locking changes from Ingo Molnar:
"This is the second round of locking tree updates for v3.16, offering
large system scalability improvements:
- optimistic spinning for rwsems, from Davidlohr Bueso.
- 'qrwlocks' core code and x86 enablement, from Waiman Long and PeterZ"
* 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
x86, locking/rwlocks: Enable qrwlocks on x86
locking/rwlocks: Introduce 'qrwlocks' - fair, queued rwlocks
locking/mutexes: Documentation update/rewrite
locking/rwsem: Fix checkpatch.pl warnings
locking/rwsem: Fix warnings for CONFIG_RWSEM_GENERIC_SPINLOCK
locking/rwsem: Support optimistic spinning
Diffstat (limited to 'include')
-rw-r--r-- | include/asm-generic/qrwlock.h | 166 | ||||
-rw-r--r-- | include/asm-generic/qrwlock_types.h | 21 | ||||
-rw-r--r-- | include/linux/rwsem.h | 25 |
3 files changed, 209 insertions, 3 deletions
diff --git a/include/asm-generic/qrwlock.h b/include/asm-generic/qrwlock.h new file mode 100644 index 000000000000..6383d54bf983 --- /dev/null +++ b/include/asm-generic/qrwlock.h | |||
@@ -0,0 +1,166 @@ | |||
1 | /* | ||
2 | * Queue read/write lock | ||
3 | * | ||
4 | * This program is free software; you can redistribute it and/or modify | ||
5 | * it under the terms of the GNU General Public License as published by | ||
6 | * the Free Software Foundation; either version 2 of the License, or | ||
7 | * (at your option) any later version. | ||
8 | * | ||
9 | * This program is distributed in the hope that it will be useful, | ||
10 | * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
11 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
12 | * GNU General Public License for more details. | ||
13 | * | ||
14 | * (C) Copyright 2013-2014 Hewlett-Packard Development Company, L.P. | ||
15 | * | ||
16 | * Authors: Waiman Long <waiman.long@hp.com> | ||
17 | */ | ||
18 | #ifndef __ASM_GENERIC_QRWLOCK_H | ||
19 | #define __ASM_GENERIC_QRWLOCK_H | ||
20 | |||
21 | #include <linux/atomic.h> | ||
22 | #include <asm/barrier.h> | ||
23 | #include <asm/processor.h> | ||
24 | |||
25 | #include <asm-generic/qrwlock_types.h> | ||
26 | |||
27 | /* | ||
28 | * Writer states & reader shift and bias | ||
29 | */ | ||
30 | #define _QW_WAITING 1 /* A writer is waiting */ | ||
31 | #define _QW_LOCKED 0xff /* A writer holds the lock */ | ||
32 | #define _QW_WMASK 0xff /* Writer mask */ | ||
33 | #define _QR_SHIFT 8 /* Reader count shift */ | ||
34 | #define _QR_BIAS (1U << _QR_SHIFT) | ||
35 | |||
36 | /* | ||
37 | * External function declarations | ||
38 | */ | ||
39 | extern void queue_read_lock_slowpath(struct qrwlock *lock); | ||
40 | extern void queue_write_lock_slowpath(struct qrwlock *lock); | ||
41 | |||
42 | /** | ||
43 | * queue_read_can_lock- would read_trylock() succeed? | ||
44 | * @lock: Pointer to queue rwlock structure | ||
45 | */ | ||
46 | static inline int queue_read_can_lock(struct qrwlock *lock) | ||
47 | { | ||
48 | return !(atomic_read(&lock->cnts) & _QW_WMASK); | ||
49 | } | ||
50 | |||
51 | /** | ||
52 | * queue_write_can_lock- would write_trylock() succeed? | ||
53 | * @lock: Pointer to queue rwlock structure | ||
54 | */ | ||
55 | static inline int queue_write_can_lock(struct qrwlock *lock) | ||
56 | { | ||
57 | return !atomic_read(&lock->cnts); | ||
58 | } | ||
59 | |||
60 | /** | ||
61 | * queue_read_trylock - try to acquire read lock of a queue rwlock | ||
62 | * @lock : Pointer to queue rwlock structure | ||
63 | * Return: 1 if lock acquired, 0 if failed | ||
64 | */ | ||
65 | static inline int queue_read_trylock(struct qrwlock *lock) | ||
66 | { | ||
67 | u32 cnts; | ||
68 | |||
69 | cnts = atomic_read(&lock->cnts); | ||
70 | if (likely(!(cnts & _QW_WMASK))) { | ||
71 | cnts = (u32)atomic_add_return(_QR_BIAS, &lock->cnts); | ||
72 | if (likely(!(cnts & _QW_WMASK))) | ||
73 | return 1; | ||
74 | atomic_sub(_QR_BIAS, &lock->cnts); | ||
75 | } | ||
76 | return 0; | ||
77 | } | ||
78 | |||
79 | /** | ||
80 | * queue_write_trylock - try to acquire write lock of a queue rwlock | ||
81 | * @lock : Pointer to queue rwlock structure | ||
82 | * Return: 1 if lock acquired, 0 if failed | ||
83 | */ | ||
84 | static inline int queue_write_trylock(struct qrwlock *lock) | ||
85 | { | ||
86 | u32 cnts; | ||
87 | |||
88 | cnts = atomic_read(&lock->cnts); | ||
89 | if (unlikely(cnts)) | ||
90 | return 0; | ||
91 | |||
92 | return likely(atomic_cmpxchg(&lock->cnts, | ||
93 | cnts, cnts | _QW_LOCKED) == cnts); | ||
94 | } | ||
95 | /** | ||
96 | * queue_read_lock - acquire read lock of a queue rwlock | ||
97 | * @lock: Pointer to queue rwlock structure | ||
98 | */ | ||
99 | static inline void queue_read_lock(struct qrwlock *lock) | ||
100 | { | ||
101 | u32 cnts; | ||
102 | |||
103 | cnts = atomic_add_return(_QR_BIAS, &lock->cnts); | ||
104 | if (likely(!(cnts & _QW_WMASK))) | ||
105 | return; | ||
106 | |||
107 | /* The slowpath will decrement the reader count, if necessary. */ | ||
108 | queue_read_lock_slowpath(lock); | ||
109 | } | ||
110 | |||
111 | /** | ||
112 | * queue_write_lock - acquire write lock of a queue rwlock | ||
113 | * @lock : Pointer to queue rwlock structure | ||
114 | */ | ||
115 | static inline void queue_write_lock(struct qrwlock *lock) | ||
116 | { | ||
117 | /* Optimize for the unfair lock case where the fair flag is 0. */ | ||
118 | if (atomic_cmpxchg(&lock->cnts, 0, _QW_LOCKED) == 0) | ||
119 | return; | ||
120 | |||
121 | queue_write_lock_slowpath(lock); | ||
122 | } | ||
123 | |||
124 | /** | ||
125 | * queue_read_unlock - release read lock of a queue rwlock | ||
126 | * @lock : Pointer to queue rwlock structure | ||
127 | */ | ||
128 | static inline void queue_read_unlock(struct qrwlock *lock) | ||
129 | { | ||
130 | /* | ||
131 | * Atomically decrement the reader count | ||
132 | */ | ||
133 | smp_mb__before_atomic(); | ||
134 | atomic_sub(_QR_BIAS, &lock->cnts); | ||
135 | } | ||
136 | |||
137 | #ifndef queue_write_unlock | ||
138 | /** | ||
139 | * queue_write_unlock - release write lock of a queue rwlock | ||
140 | * @lock : Pointer to queue rwlock structure | ||
141 | */ | ||
142 | static inline void queue_write_unlock(struct qrwlock *lock) | ||
143 | { | ||
144 | /* | ||
145 | * If the writer field is atomic, it can be cleared directly. | ||
146 | * Otherwise, an atomic subtraction will be used to clear it. | ||
147 | */ | ||
148 | smp_mb__before_atomic(); | ||
149 | atomic_sub(_QW_LOCKED, &lock->cnts); | ||
150 | } | ||
151 | #endif | ||
152 | |||
153 | /* | ||
154 | * Remapping rwlock architecture specific functions to the corresponding | ||
155 | * queue rwlock functions. | ||
156 | */ | ||
157 | #define arch_read_can_lock(l) queue_read_can_lock(l) | ||
158 | #define arch_write_can_lock(l) queue_write_can_lock(l) | ||
159 | #define arch_read_lock(l) queue_read_lock(l) | ||
160 | #define arch_write_lock(l) queue_write_lock(l) | ||
161 | #define arch_read_trylock(l) queue_read_trylock(l) | ||
162 | #define arch_write_trylock(l) queue_write_trylock(l) | ||
163 | #define arch_read_unlock(l) queue_read_unlock(l) | ||
164 | #define arch_write_unlock(l) queue_write_unlock(l) | ||
165 | |||
166 | #endif /* __ASM_GENERIC_QRWLOCK_H */ | ||
diff --git a/include/asm-generic/qrwlock_types.h b/include/asm-generic/qrwlock_types.h new file mode 100644 index 000000000000..4d76f24df518 --- /dev/null +++ b/include/asm-generic/qrwlock_types.h | |||
@@ -0,0 +1,21 @@ | |||
1 | #ifndef __ASM_GENERIC_QRWLOCK_TYPES_H | ||
2 | #define __ASM_GENERIC_QRWLOCK_TYPES_H | ||
3 | |||
4 | #include <linux/types.h> | ||
5 | #include <asm/spinlock_types.h> | ||
6 | |||
7 | /* | ||
8 | * The queue read/write lock data structure | ||
9 | */ | ||
10 | |||
11 | typedef struct qrwlock { | ||
12 | atomic_t cnts; | ||
13 | arch_spinlock_t lock; | ||
14 | } arch_rwlock_t; | ||
15 | |||
16 | #define __ARCH_RW_LOCK_UNLOCKED { \ | ||
17 | .cnts = ATOMIC_INIT(0), \ | ||
18 | .lock = __ARCH_SPIN_LOCK_UNLOCKED, \ | ||
19 | } | ||
20 | |||
21 | #endif /* __ASM_GENERIC_QRWLOCK_TYPES_H */ | ||
diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h index 03f3b05e8ec1..8d79708146aa 100644 --- a/include/linux/rwsem.h +++ b/include/linux/rwsem.h | |||
@@ -16,6 +16,7 @@ | |||
16 | 16 | ||
17 | #include <linux/atomic.h> | 17 | #include <linux/atomic.h> |
18 | 18 | ||
19 | struct optimistic_spin_queue; | ||
19 | struct rw_semaphore; | 20 | struct rw_semaphore; |
20 | 21 | ||
21 | #ifdef CONFIG_RWSEM_GENERIC_SPINLOCK | 22 | #ifdef CONFIG_RWSEM_GENERIC_SPINLOCK |
@@ -23,9 +24,17 @@ struct rw_semaphore; | |||
23 | #else | 24 | #else |
24 | /* All arch specific implementations share the same struct */ | 25 | /* All arch specific implementations share the same struct */ |
25 | struct rw_semaphore { | 26 | struct rw_semaphore { |
26 | long count; | 27 | long count; |
27 | raw_spinlock_t wait_lock; | 28 | raw_spinlock_t wait_lock; |
28 | struct list_head wait_list; | 29 | struct list_head wait_list; |
30 | #ifdef CONFIG_SMP | ||
31 | /* | ||
32 | * Write owner. Used as a speculative check to see | ||
33 | * if the owner is running on the cpu. | ||
34 | */ | ||
35 | struct task_struct *owner; | ||
36 | struct optimistic_spin_queue *osq; /* spinner MCS lock */ | ||
37 | #endif | ||
29 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | 38 | #ifdef CONFIG_DEBUG_LOCK_ALLOC |
30 | struct lockdep_map dep_map; | 39 | struct lockdep_map dep_map; |
31 | #endif | 40 | #endif |
@@ -55,11 +64,21 @@ static inline int rwsem_is_locked(struct rw_semaphore *sem) | |||
55 | # define __RWSEM_DEP_MAP_INIT(lockname) | 64 | # define __RWSEM_DEP_MAP_INIT(lockname) |
56 | #endif | 65 | #endif |
57 | 66 | ||
67 | #if defined(CONFIG_SMP) && !defined(CONFIG_RWSEM_GENERIC_SPINLOCK) | ||
68 | #define __RWSEM_INITIALIZER(name) \ | ||
69 | { RWSEM_UNLOCKED_VALUE, \ | ||
70 | __RAW_SPIN_LOCK_UNLOCKED(name.wait_lock), \ | ||
71 | LIST_HEAD_INIT((name).wait_list), \ | ||
72 | NULL, /* owner */ \ | ||
73 | NULL /* mcs lock */ \ | ||
74 | __RWSEM_DEP_MAP_INIT(name) } | ||
75 | #else | ||
58 | #define __RWSEM_INITIALIZER(name) \ | 76 | #define __RWSEM_INITIALIZER(name) \ |
59 | { RWSEM_UNLOCKED_VALUE, \ | 77 | { RWSEM_UNLOCKED_VALUE, \ |
60 | __RAW_SPIN_LOCK_UNLOCKED(name.wait_lock), \ | 78 | __RAW_SPIN_LOCK_UNLOCKED(name.wait_lock), \ |
61 | LIST_HEAD_INIT((name).wait_list) \ | 79 | LIST_HEAD_INIT((name).wait_list) \ |
62 | __RWSEM_DEP_MAP_INIT(name) } | 80 | __RWSEM_DEP_MAP_INIT(name) } |
81 | #endif | ||
63 | 82 | ||
64 | #define DECLARE_RWSEM(name) \ | 83 | #define DECLARE_RWSEM(name) \ |
65 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) | 84 | struct rw_semaphore name = __RWSEM_INITIALIZER(name) |