diff options
author | Mathieu Desnoyers <mathieu.desnoyers@efficios.com> | 2014-04-09 17:06:08 -0400 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2014-04-09 20:02:55 -0400 |
commit | abb43f6998eb6466ea392d3757e673bbdb6ae171 (patch) | |
tree | 068d361c31e1d9e7668c19dbe6324523eac718f9 /include | |
parent | b725dfea24b89de672c055b34b22398283a3f4bc (diff) |
tracing: Fix anonymous unions in struct ftrace_event_call
gcc <= 4.5.x has significant limitations with respect to initialization
of anonymous unions within structures. They need to be surrounded by
brackets, _and_ they need to be initialized in the same order in which
they appear in the structure declaration.
Link: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676
Link: http://lkml.kernel.org/r/1397077568-3156-1-git-send-email-mathieu.desnoyers@efficios.com
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'include')
-rw-r--r-- | include/linux/syscalls.h | 8 | ||||
-rw-r--r-- | include/trace/ftrace.h | 12 |
2 files changed, 15 insertions, 5 deletions
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h index 1e67b7a5968c..af94c98087c4 100644 --- a/include/linux/syscalls.h +++ b/include/linux/syscalls.h | |||
@@ -119,8 +119,10 @@ extern struct trace_event_functions exit_syscall_print_funcs; | |||
119 | static struct syscall_metadata __syscall_meta_##sname; \ | 119 | static struct syscall_metadata __syscall_meta_##sname; \ |
120 | static struct ftrace_event_call __used \ | 120 | static struct ftrace_event_call __used \ |
121 | event_enter_##sname = { \ | 121 | event_enter_##sname = { \ |
122 | .name = "sys_enter"#sname, \ | ||
123 | .class = &event_class_syscall_enter, \ | 122 | .class = &event_class_syscall_enter, \ |
123 | { \ | ||
124 | .name = "sys_enter"#sname, \ | ||
125 | }, \ | ||
124 | .event.funcs = &enter_syscall_print_funcs, \ | 126 | .event.funcs = &enter_syscall_print_funcs, \ |
125 | .data = (void *)&__syscall_meta_##sname,\ | 127 | .data = (void *)&__syscall_meta_##sname,\ |
126 | .flags = TRACE_EVENT_FL_CAP_ANY, \ | 128 | .flags = TRACE_EVENT_FL_CAP_ANY, \ |
@@ -133,8 +135,10 @@ extern struct trace_event_functions exit_syscall_print_funcs; | |||
133 | static struct syscall_metadata __syscall_meta_##sname; \ | 135 | static struct syscall_metadata __syscall_meta_##sname; \ |
134 | static struct ftrace_event_call __used \ | 136 | static struct ftrace_event_call __used \ |
135 | event_exit_##sname = { \ | 137 | event_exit_##sname = { \ |
136 | .name = "sys_exit"#sname, \ | ||
137 | .class = &event_class_syscall_exit, \ | 138 | .class = &event_class_syscall_exit, \ |
139 | { \ | ||
140 | .name = "sys_exit"#sname, \ | ||
141 | }, \ | ||
138 | .event.funcs = &exit_syscall_print_funcs, \ | 142 | .event.funcs = &exit_syscall_print_funcs, \ |
139 | .data = (void *)&__syscall_meta_##sname,\ | 143 | .data = (void *)&__syscall_meta_##sname,\ |
140 | .flags = TRACE_EVENT_FL_CAP_ANY, \ | 144 | .flags = TRACE_EVENT_FL_CAP_ANY, \ |
diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h index 9c44c11cd9bb..0a1a4f7caf09 100644 --- a/include/trace/ftrace.h +++ b/include/trace/ftrace.h | |||
@@ -470,8 +470,10 @@ static inline notrace int ftrace_get_offsets_##call( \ | |||
470 | * }; | 470 | * }; |
471 | * | 471 | * |
472 | * static struct ftrace_event_call event_<call> = { | 472 | * static struct ftrace_event_call event_<call> = { |
473 | * .tp = &__tracepoint_<call>, | ||
474 | * .class = event_class_<template>, | 473 | * .class = event_class_<template>, |
474 | * { | ||
475 | * .tp = &__tracepoint_<call>, | ||
476 | * }, | ||
475 | * .event = &ftrace_event_type_<call>, | 477 | * .event = &ftrace_event_type_<call>, |
476 | * .print_fmt = print_fmt_<call>, | 478 | * .print_fmt = print_fmt_<call>, |
477 | * .flags = TRACE_EVENT_FL_TRACEPOINT, | 479 | * .flags = TRACE_EVENT_FL_TRACEPOINT, |
@@ -606,8 +608,10 @@ static struct ftrace_event_class __used __refdata event_class_##call = { \ | |||
606 | #define DEFINE_EVENT(template, call, proto, args) \ | 608 | #define DEFINE_EVENT(template, call, proto, args) \ |
607 | \ | 609 | \ |
608 | static struct ftrace_event_call __used event_##call = { \ | 610 | static struct ftrace_event_call __used event_##call = { \ |
609 | .tp = &__tracepoint_##call, \ | ||
610 | .class = &event_class_##template, \ | 611 | .class = &event_class_##template, \ |
612 | { \ | ||
613 | .tp = &__tracepoint_##call, \ | ||
614 | }, \ | ||
611 | .event.funcs = &ftrace_event_type_funcs_##template, \ | 615 | .event.funcs = &ftrace_event_type_funcs_##template, \ |
612 | .print_fmt = print_fmt_##template, \ | 616 | .print_fmt = print_fmt_##template, \ |
613 | .flags = TRACE_EVENT_FL_TRACEPOINT, \ | 617 | .flags = TRACE_EVENT_FL_TRACEPOINT, \ |
@@ -621,8 +625,10 @@ __attribute__((section("_ftrace_events"))) *__event_##call = &event_##call | |||
621 | static const char print_fmt_##call[] = print; \ | 625 | static const char print_fmt_##call[] = print; \ |
622 | \ | 626 | \ |
623 | static struct ftrace_event_call __used event_##call = { \ | 627 | static struct ftrace_event_call __used event_##call = { \ |
624 | .tp = &__tracepoint_##call, \ | ||
625 | .class = &event_class_##template, \ | 628 | .class = &event_class_##template, \ |
629 | { \ | ||
630 | .tp = &__tracepoint_##call, \ | ||
631 | }, \ | ||
626 | .event.funcs = &ftrace_event_type_funcs_##call, \ | 632 | .event.funcs = &ftrace_event_type_funcs_##call, \ |
627 | .print_fmt = print_fmt_##call, \ | 633 | .print_fmt = print_fmt_##call, \ |
628 | .flags = TRACE_EVENT_FL_TRACEPOINT, \ | 634 | .flags = TRACE_EVENT_FL_TRACEPOINT, \ |