diff options
| author | Eliezer Tamir <eliezer.tamir@linux.intel.com> | 2013-06-28 08:59:35 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-07-01 17:06:47 -0400 |
| commit | 91e2fd337839319c7745e2cb84cfbf8cf1426a1a (patch) | |
| tree | 1a832c8fb04fc687dfd40e4a4b69b15d60049172 /include | |
| parent | ad6276e0fe724b1c8ac3a0bf138d151665ab2349 (diff) | |
net: avoid calling sched_clock when LLS is off
Change Low Latency Sockets code for select and poll so that
when LLS is disabled sched_clock() is never called.
Also, avoid sending POLL_LL to sockets if disabled.
Reported-by: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Eliezer Tamir <eliezer.tamir@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/ll_poll.h | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/include/net/ll_poll.h b/include/net/ll_poll.h index 6d45e6f6ff4c..6c06f7c0a22d 100644 --- a/include/net/ll_poll.h +++ b/include/net/ll_poll.h | |||
| @@ -37,6 +37,11 @@ extern unsigned int sysctl_net_ll_poll __read_mostly; | |||
| 37 | #define LL_FLUSH_FAILED -1 | 37 | #define LL_FLUSH_FAILED -1 |
| 38 | #define LL_FLUSH_BUSY -2 | 38 | #define LL_FLUSH_BUSY -2 |
| 39 | 39 | ||
| 40 | static inline unsigned int ll_get_flag(void) | ||
| 41 | { | ||
| 42 | return sysctl_net_ll_poll ? POLL_LL : 0; | ||
| 43 | } | ||
| 44 | |||
| 40 | /* a wrapper to make debug_smp_processor_id() happy | 45 | /* a wrapper to make debug_smp_processor_id() happy |
| 41 | * we can use sched_clock() because we don't care much about precision | 46 | * we can use sched_clock() because we don't care much about precision |
| 42 | * we only care that the average is bounded | 47 | * we only care that the average is bounded |
| @@ -67,10 +72,14 @@ static inline u64 ll_sk_end_time(struct sock *sk) | |||
| 67 | return ((u64)ACCESS_ONCE(sk->sk_ll_usec) << 10) + ll_sched_clock(); | 72 | return ((u64)ACCESS_ONCE(sk->sk_ll_usec) << 10) + ll_sched_clock(); |
| 68 | } | 73 | } |
| 69 | 74 | ||
| 70 | /* in poll/select we use the global sysctl_net_ll_poll value */ | 75 | /* in poll/select we use the global sysctl_net_ll_poll value |
| 76 | * only call sched_clock() if enabled | ||
| 77 | */ | ||
| 71 | static inline u64 ll_end_time(void) | 78 | static inline u64 ll_end_time(void) |
| 72 | { | 79 | { |
| 73 | return ((u64)ACCESS_ONCE(sysctl_net_ll_poll) << 10) + ll_sched_clock(); | 80 | u64 end_time = ACCESS_ONCE(sysctl_net_ll_poll); |
| 81 | |||
| 82 | return end_time ? (end_time << 10) + ll_sched_clock() : 0; | ||
| 74 | } | 83 | } |
| 75 | 84 | ||
| 76 | static inline bool sk_valid_ll(struct sock *sk) | 85 | static inline bool sk_valid_ll(struct sock *sk) |
| @@ -141,6 +150,10 @@ static inline void sk_mark_ll(struct sock *sk, struct sk_buff *skb) | |||
| 141 | } | 150 | } |
| 142 | 151 | ||
| 143 | #else /* CONFIG_NET_LL_RX_POLL */ | 152 | #else /* CONFIG_NET_LL_RX_POLL */ |
| 153 | static inline unsigned long ll_get_flag(void) | ||
| 154 | { | ||
| 155 | return 0; | ||
| 156 | } | ||
| 144 | 157 | ||
| 145 | static inline u64 sk_ll_end_time(struct sock *sk) | 158 | static inline u64 sk_ll_end_time(struct sock *sk) |
| 146 | { | 159 | { |
