diff options
author | Darrick J. Wong <djwong@us.ibm.com> | 2007-11-05 14:52:14 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@HansenPartnership.com> | 2008-01-11 19:22:41 -0500 |
commit | 8ee24023ef43c77cdaea1add00e1e45cc4fc3261 (patch) | |
tree | d36320fa2a3ff4e8d98ff17a31cbe6b292c1155f /include | |
parent | 5929faf3334f4c69f3bb02be59d7c127e0cefa1f (diff) |
[SCSI] libsas: Fix various sparse complaints
Annotate sas_queuecommand with locking details, and clean up a few
more sparse warnings about static/non-static declarations.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Diffstat (limited to 'include')
-rw-r--r-- | include/scsi/libsas.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h index e42374cebf95..93248cd48373 100644 --- a/include/scsi/libsas.h +++ b/include/scsi/libsas.h | |||
@@ -563,7 +563,7 @@ struct sas_task { | |||
563 | struct work_struct abort_work; | 563 | struct work_struct abort_work; |
564 | }; | 564 | }; |
565 | 565 | ||
566 | 566 | extern struct kmem_cache *sas_task_cache; | |
567 | 567 | ||
568 | #define SAS_TASK_STATE_PENDING 1 | 568 | #define SAS_TASK_STATE_PENDING 1 |
569 | #define SAS_TASK_STATE_DONE 2 | 569 | #define SAS_TASK_STATE_DONE 2 |
@@ -573,7 +573,6 @@ struct sas_task { | |||
573 | 573 | ||
574 | static inline struct sas_task *sas_alloc_task(gfp_t flags) | 574 | static inline struct sas_task *sas_alloc_task(gfp_t flags) |
575 | { | 575 | { |
576 | extern struct kmem_cache *sas_task_cache; | ||
577 | struct sas_task *task = kmem_cache_zalloc(sas_task_cache, flags); | 576 | struct sas_task *task = kmem_cache_zalloc(sas_task_cache, flags); |
578 | 577 | ||
579 | if (task) { | 578 | if (task) { |
@@ -590,7 +589,6 @@ static inline struct sas_task *sas_alloc_task(gfp_t flags) | |||
590 | static inline void sas_free_task(struct sas_task *task) | 589 | static inline void sas_free_task(struct sas_task *task) |
591 | { | 590 | { |
592 | if (task) { | 591 | if (task) { |
593 | extern struct kmem_cache *sas_task_cache; | ||
594 | BUG_ON(!list_empty(&task->list)); | 592 | BUG_ON(!list_empty(&task->list)); |
595 | kmem_cache_free(sas_task_cache, task); | 593 | kmem_cache_free(sas_task_cache, task); |
596 | } | 594 | } |