x86 cpufreq, perf: Make trace_power_frequency cpufreq driver independent

and fix the broken case if a core's frequency depends on others.

trace_power_frequency was only implemented in a rather ungeneric
way in acpi-cpufreq driver's target() function only.

-> Move the call to trace_power_frequency to
   cpufreq.c:cpufreq_notify_transition() where CPUFREQ_POSTCHANGE
   notifier is triggered.
   This will support power frequency tracing by all cpufreq
   drivers.

trace_power_frequency did not trace frequency changes correctly
when the userspace governor was used or when CPU cores'
frequency depend on each other.

-> Moving this into the CPUFREQ_POSTCHANGE notifier and pass the cpu
   which gets switched automatically fixes this.

Robert Schoene provided some important fixes on top of my
initial quick shot version which are integrated in this patch:
- Forgot some changes in power_end trace (TP_printk/variable names)
- Variable dummy in power_end must now be cpu_id
- Use static 64 bit variable instead of unsigned int for cpu_id

[akpm@linux-foundation.org: build fix]
Signed-off-by: Thomas Renninger <trenn@suse.de>
Cc: davej@codemonkey.org.uk
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Cc: Dave Jones <davej@codemonkey.org.uk>
Acked-by: Arjan van de Ven <arjan@infradead.org>
Cc: Robert Schoene <robert.schoene@tu-dresden.de>
Tested-by: Robert Schoene <robert.schoene@tu-dresden.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

1 files changed, 15 insertions, 12 deletions

diff --git a/include/trace/events/power.h b/include/trace/events/power.h
index c4efe9b8280d..35a2a6e7bf1e 100644
--- a/include/trace/events/power.h
+++ b/include/trace/events/power.h
@@ -18,52 +18,55 @@ enum {
 
 DECLARE_EVENT_CLASS(power,
 
-        TP_PROTO(unsigned int type, unsigned int state),
+        TP_PROTO(unsigned int type, unsigned int state, unsigned int cpu_id),
 
-        TP_ARGS(type, state),
+        TP_ARGS(type, state, cpu_id),
 
         TP_STRUCT__entry(
                 __field(        u64,            type            )
                 __field(        u64,            state           )
+                __field(        u64,            cpu_id          )
         ),
 
         TP_fast_assign(
                 __entry->type = type;
                 __entry->state = state;
+                __entry->cpu_id = cpu_id;
         ),
 
-        TP_printk("type=%lu state=%lu", (unsigned long)__entry->type, (unsigned long)__entry->state)
+        TP_printk("type=%lu state=%lu cpu_id=%lu", (unsigned long)__entry->type,
+                (unsigned long)__entry->state, (unsigned long)__entry->cpu_id)
 );
 
 DEFINE_EVENT(power, power_start,
 
-        TP_PROTO(unsigned int type, unsigned int state),
+        TP_PROTO(unsigned int type, unsigned int state, unsigned int cpu_id),
 
-        TP_ARGS(type, state)
+        TP_ARGS(type, state, cpu_id)
 );
 
 DEFINE_EVENT(power, power_frequency,
 
-        TP_PROTO(unsigned int type, unsigned int state),
+        TP_PROTO(unsigned int type, unsigned int state, unsigned int cpu_id),
 
-        TP_ARGS(type, state)
+        TP_ARGS(type, state, cpu_id)
 );
 
 TRACE_EVENT(power_end,
 
-        TP_PROTO(int dummy),
+        TP_PROTO(unsigned int cpu_id),
 
-        TP_ARGS(dummy),
+        TP_ARGS(cpu_id),
 
         TP_STRUCT__entry(
-                __field(        u64,            dummy           )
+                __field(        u64,            cpu_id          )
         ),
 
         TP_fast_assign(
-                __entry->dummy = 0xffff;
+                __entry->cpu_id = cpu_id;
         ),
 
-        TP_printk("dummy=%lu", (unsigned long)__entry->dummy)
+        TP_printk("cpu_id=%lu", (unsigned long)__entry->cpu_id)
 
 );