diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2012-09-14 12:52:10 -0400 |
|---|---|---|
| committer | Oleg Nesterov <oleg@redhat.com> | 2012-09-29 15:21:53 -0400 |
| commit | 1b08e907211cdc744f54871736005d9f3e7f182c (patch) | |
| tree | df62046438501ecd89e0bac1fb9b73edaf622e15 /include | |
| parent | 0578a97098dab967ece4b025fe5eb4984c4c86c0 (diff) | |
uprobes: Kill UTASK_BP_HIT state
Kill UTASK_BP_HIT state, it buys nothing but complicates the code.
It is only used in uprobe_notify_resume() to decide who should be
called, we can check utask->active_uprobe != NULL instead. And this
allows us to simplify handle_swbp(), no need to clear utask->state.
Likewise we could kill UTASK_SSTEP, but UTASK_BP_HIT is worse and
imho should die. The problem is, it creates the special case when
task->utask is NULL, we can't distinguish RUNNING and BP_HIT. With
this patch utask == NULL always means RUNNING.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/linux/uprobes.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h index e6f0331e3d45..18d839da6517 100644 --- a/include/linux/uprobes.h +++ b/include/linux/uprobes.h | |||
| @@ -59,7 +59,6 @@ struct uprobe_consumer { | |||
| 59 | #ifdef CONFIG_UPROBES | 59 | #ifdef CONFIG_UPROBES |
| 60 | enum uprobe_task_state { | 60 | enum uprobe_task_state { |
| 61 | UTASK_RUNNING, | 61 | UTASK_RUNNING, |
| 62 | UTASK_BP_HIT, | ||
| 63 | UTASK_SSTEP, | 62 | UTASK_SSTEP, |
| 64 | UTASK_SSTEP_ACK, | 63 | UTASK_SSTEP_ACK, |
| 65 | UTASK_SSTEP_TRAPPED, | 64 | UTASK_SSTEP_TRAPPED, |