diff options
| author | Joe Perches <joe@perches.com> | 2011-10-31 20:11:33 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-10-31 20:30:54 -0400 |
| commit | b9075fa968a0a4347aef35e235e2995c0e57dddd (patch) | |
| tree | cf9f9716784e790d8a43339653256d9cf9178ff3 /include/xen | |
| parent | ae29bc92da01a2e9d278a9a58c3b307d41cc0254 (diff) | |
treewide: use __printf not __attribute__((format(printf,...)))
Standardize the style for compiler based printf format verification.
Standardized the location of __printf too.
Done via script and a little typing.
$ grep -rPl --include=*.[ch] -w "__attribute__" * | \
grep -vP "^(tools|scripts|include/linux/compiler-gcc.h)" | \
xargs perl -n -i -e 'local $/; while (<>) { s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.+)\s*,\s*(.+)\s*\)\s*\)\s*\)/__printf($1, $2)/g ; print; }'
[akpm@linux-foundation.org: revert arch bits]
Signed-off-by: Joe Perches <joe@perches.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/xen')
| -rw-r--r-- | include/xen/hvc-console.h | 4 | ||||
| -rw-r--r-- | include/xen/xenbus.h | 12 |
2 files changed, 8 insertions, 8 deletions
diff --git a/include/xen/hvc-console.h b/include/xen/hvc-console.h index 901724dc528d..b62dfef15f61 100644 --- a/include/xen/hvc-console.h +++ b/include/xen/hvc-console.h | |||
| @@ -6,12 +6,12 @@ extern struct console xenboot_console; | |||
| 6 | #ifdef CONFIG_HVC_XEN | 6 | #ifdef CONFIG_HVC_XEN |
| 7 | void xen_console_resume(void); | 7 | void xen_console_resume(void); |
| 8 | void xen_raw_console_write(const char *str); | 8 | void xen_raw_console_write(const char *str); |
| 9 | __attribute__((format(printf, 1, 2))) | 9 | __printf(1, 2) |
| 10 | void xen_raw_printk(const char *fmt, ...); | 10 | void xen_raw_printk(const char *fmt, ...); |
| 11 | #else | 11 | #else |
| 12 | static inline void xen_console_resume(void) { } | 12 | static inline void xen_console_resume(void) { } |
| 13 | static inline void xen_raw_console_write(const char *str) { } | 13 | static inline void xen_raw_console_write(const char *str) { } |
| 14 | static inline __attribute__((format(printf, 1, 2))) | 14 | static inline __printf(1, 2) |
| 15 | void xen_raw_printk(const char *fmt, ...) { } | 15 | void xen_raw_printk(const char *fmt, ...) { } |
| 16 | #endif | 16 | #endif |
| 17 | 17 | ||
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h index aceeca799fd7..b9f9fb5af0d8 100644 --- a/include/xen/xenbus.h +++ b/include/xen/xenbus.h | |||
| @@ -156,9 +156,9 @@ int xenbus_scanf(struct xenbus_transaction t, | |||
| 156 | __attribute__((format(scanf, 4, 5))); | 156 | __attribute__((format(scanf, 4, 5))); |
| 157 | 157 | ||
| 158 | /* Single printf and write: returns -errno or 0. */ | 158 | /* Single printf and write: returns -errno or 0. */ |
| 159 | __printf(4, 5) | ||
| 159 | int xenbus_printf(struct xenbus_transaction t, | 160 | int xenbus_printf(struct xenbus_transaction t, |
| 160 | const char *dir, const char *node, const char *fmt, ...) | 161 | const char *dir, const char *node, const char *fmt, ...); |
| 161 | __attribute__((format(printf, 4, 5))); | ||
| 162 | 162 | ||
| 163 | /* Generic read function: NULL-terminated triples of name, | 163 | /* Generic read function: NULL-terminated triples of name, |
| 164 | * sprintf-style type string, and pointer. Returns 0 or errno.*/ | 164 | * sprintf-style type string, and pointer. Returns 0 or errno.*/ |
| @@ -200,11 +200,11 @@ int xenbus_watch_path(struct xenbus_device *dev, const char *path, | |||
| 200 | struct xenbus_watch *watch, | 200 | struct xenbus_watch *watch, |
| 201 | void (*callback)(struct xenbus_watch *, | 201 | void (*callback)(struct xenbus_watch *, |
| 202 | const char **, unsigned int)); | 202 | const char **, unsigned int)); |
| 203 | __printf(4, 5) | ||
| 203 | int xenbus_watch_pathfmt(struct xenbus_device *dev, struct xenbus_watch *watch, | 204 | int xenbus_watch_pathfmt(struct xenbus_device *dev, struct xenbus_watch *watch, |
| 204 | void (*callback)(struct xenbus_watch *, | 205 | void (*callback)(struct xenbus_watch *, |
| 205 | const char **, unsigned int), | 206 | const char **, unsigned int), |
| 206 | const char *pathfmt, ...) | 207 | const char *pathfmt, ...); |
| 207 | __attribute__ ((format (printf, 4, 5))); | ||
| 208 | 208 | ||
| 209 | int xenbus_switch_state(struct xenbus_device *dev, enum xenbus_state new_state); | 209 | int xenbus_switch_state(struct xenbus_device *dev, enum xenbus_state new_state); |
| 210 | int xenbus_grant_ring(struct xenbus_device *dev, unsigned long ring_mfn); | 210 | int xenbus_grant_ring(struct xenbus_device *dev, unsigned long ring_mfn); |
| @@ -223,9 +223,9 @@ int xenbus_free_evtchn(struct xenbus_device *dev, int port); | |||
| 223 | 223 | ||
| 224 | enum xenbus_state xenbus_read_driver_state(const char *path); | 224 | enum xenbus_state xenbus_read_driver_state(const char *path); |
| 225 | 225 | ||
| 226 | __attribute__((format(printf, 3, 4))) | 226 | __printf(3, 4) |
| 227 | void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...); | 227 | void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt, ...); |
| 228 | __attribute__((format(printf, 3, 4))) | 228 | __printf(3, 4) |
| 229 | void xenbus_dev_fatal(struct xenbus_device *dev, int err, const char *fmt, ...); | 229 | void xenbus_dev_fatal(struct xenbus_device *dev, int err, const char *fmt, ...); |
| 230 | 230 | ||
| 231 | const char *xenbus_strstate(enum xenbus_state state); | 231 | const char *xenbus_strstate(enum xenbus_state state); |
