iscsi-target: Drop legacy iscsi_target_tq.c logic

Now that iscsi_conn allocates new [rx,tx] threads using kthread.h
primitives on the fly, and kthread_stop() is called directly during
connection shutdown, it's time to go ahead and drop iscsi_target_tq.c
legacy code.

The use of multiple struct completion in iscsi_activate_thread_set()
has been proven to cause issues during repeated iser login/logout.

Tested-by: Sagi Grimberg <sagig@mellanox.com>
Cc: Slava Shwartsman <valyushash@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

1 files changed, 2 insertions, 4 deletions

diff --git a/include/target/iscsi/iscsi_target_core.h b/include/target/iscsi/iscsi_target_core.h
index dd0f3abde75d..0e394a031c28 100644
--- a/include/target/iscsi/iscsi_target_core.h
+++ b/include/target/iscsi/iscsi_target_core.h
@@ -20,6 +20,8 @@
 #define ISCSIT_MIN_TAGS                 16
 #define ISCSIT_EXTRA_TAGS               8
 #define ISCSIT_TCP_BACKLOG              256
+#define ISCSI_RX_THREAD_NAME            "iscsi_trx"
+#define ISCSI_TX_THREAD_NAME            "iscsi_ttx"
 
 /* struct iscsi_node_attrib sanity values */
 #define NA_DATAOUT_TIMEOUT              3
@@ -600,8 +602,6 @@ struct iscsi_conn {
         struct iscsi_tpg_np     *tpg_np;
         /* Pointer to parent session */
         struct iscsi_session    *sess;
-        /* Pointer to thread_set in use for this conn's threads */
-        struct iscsi_thread_set *thread_set;
         int                     bitmap_id;
         int                     rx_thread_active;
         struct task_struct      *rx_thread;
@@ -877,8 +877,6 @@ struct iscsit_global {
         u32                     auth_id;
         u32                     inactive_ts;
 #define ISCSIT_BITMAP_BITS      262144
-        /* Thread Set bitmap count */
-        int                     ts_bitmap_count;
         /* Thread Set bitmap pointer */
         unsigned long           *ts_bitmap;
         spinlock_t              ts_bitmap_lock;