target: Make all control CDBs scatter-gather

Previously, some control CDBs did not allocate memory in pages for their
data buffer, but just did a kmalloc. This patch makes all cdbs allocate
pages.

This has the benefit of streamlining some paths that had to behave
differently when we used two allocation methods. The downside is that
all accesses to the data buffer need to kmap it before use, and need to
handle data in page-sized chunks if more than a page is needed for a given
command's data buffer.

Finally, note that cdbs with no data buffers are handled a little
differently. Before, SCSI_NON_DATA_CDBs would not call get_mem at all
(they'd be in the final else in transport_allocate_resources) but now
these will make it into generic_get_mem, but just not allocate any
buffers.

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

2 files changed, 3 insertions, 8 deletions

diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
index 81deb399bf6a..f67ca98394d3 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -109,7 +109,6 @@ enum se_cmd_flags_table {
         SCF_EMULATED_TASK_SENSE         = 0x00000004,
         SCF_SCSI_DATA_SG_IO_CDB         = 0x00000008,
         SCF_SCSI_CONTROL_SG_IO_CDB      = 0x00000010,
-        SCF_SCSI_CONTROL_NONSG_IO_CDB   = 0x00000020,
         SCF_SCSI_NON_DATA_CDB           = 0x00000040,
         SCF_SCSI_CDB_EXCEPTION          = 0x00000080,
         SCF_SCSI_RESERVATION_CONFLICT   = 0x00000100,
@@ -123,7 +122,6 @@ enum se_cmd_flags_table {
         SCF_ALUA_NON_OPTIMIZED          = 0x00040000,
         SCF_DELAYED_CMD_FROM_SAM_ATTR   = 0x00080000,
         SCF_UNUSED                      = 0x00100000,
-        SCF_PASSTHROUGH_CONTIG_TO_SG    = 0x00200000,
         SCF_PASSTHROUGH_SG_TO_MEM_NOALLOC = 0x00400000,
         SCF_EMULATE_CDB_ASYNC           = 0x01000000,
         SCF_EMULATE_QUEUE_FULL          = 0x02000000,
@@ -516,8 +514,7 @@ struct se_cmd {
         struct completion       transport_lun_fe_stop_comp;
         struct completion       transport_lun_stop_comp;
         struct scatterlist      *t_tasks_sg_chained;
-        struct scatterlist      t_tasks_sg_bounce;
-        void                    *t_task_buf;
+
         /*
          * Used for pre-registered fabric SGL passthrough WRITE and READ
          * with the special SCF_PASSTHROUGH_CONTIG_TO_SG case for TCM_Loop
diff --git a/include/target/target_core_transport.h b/include/target/target_core_transport.h
index b27ce1af698b..123df9238c68 100644
--- a/include/target/target_core_transport.h
+++ b/include/target/target_core_transport.h
@@ -165,6 +165,8 @@ extern void transport_init_se_cmd(struct se_cmd *,
                                         struct target_core_fabric_ops *,
                                         struct se_session *, u32, int, int,
                                         unsigned char *);
+void *transport_kmap_first_data_page(struct se_cmd *cmd);
+void transport_kunmap_first_data_page(struct se_cmd *cmd);
 extern void transport_free_se_cmd(struct se_cmd *);
 extern int transport_generic_allocate_tasks(struct se_cmd *, unsigned char *);
 extern int transport_generic_handle_cdb(struct se_cmd *);
@@ -237,10 +239,6 @@ struct se_subsystem_api {
          */
         int (*cdb_none)(struct se_task *);
         /*
-         * For SCF_SCSI_CONTROL_NONSG_IO_CDB
-         */
-        int (*map_task_non_SG)(struct se_task *);
-        /*
          * For SCF_SCSI_DATA_SG_IO_CDB and SCF_SCSI_CONTROL_SG_IO_CDB
          */
         int (*map_task_SG)(struct se_task *);