scsi: Conditionally compile in constants.c

Instead of having constants.c littered with ifdef statements we should
be moving dummy functions into the header and condintionally compile in
constants.c if selected. And update the Kconfig description to reflect
the actual size difference.

Suggested-by: Christoph Hellwig <hch@infradead.org>
Tested-by: Robert Elliott <elliott@hp.com>
Reviewed-by: Robert Elliott <elliott@hp.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>

1 files changed, 64 insertions, 4 deletions

diff --git a/include/scsi/scsi_dbg.h b/include/scsi/scsi_dbg.h
index 365b6745dc10..f8170e90b49d 100644
--- a/include/scsi/scsi_dbg.h
+++ b/include/scsi/scsi_dbg.h
@@ -7,7 +7,6 @@ struct scsi_sense_hdr;
 
 #define SCSI_LOG_BUFSIZE 128
 
-extern bool scsi_opcode_sa_name(int, int, const char **, const char **);
 extern void scsi_print_command(struct scsi_cmnd *);
 extern size_t __scsi_format_command(char *, size_t,
                                    const unsigned char *, size_t);
@@ -22,11 +21,72 @@ extern void __scsi_print_sense(const struct scsi_device *, const char *name,
                                const unsigned char *sense_buffer,
                                int sense_len);
 extern void scsi_print_result(const struct scsi_cmnd *, const char *, int);
-extern const char *scsi_hostbyte_string(int);
-extern const char *scsi_driverbyte_string(int);
-extern const char *scsi_mlreturn_string(int);
+
+#ifdef CONFIG_SCSI_CONSTANTS
+extern bool scsi_opcode_sa_name(int, int, const char **, const char **);
 extern const char *scsi_sense_key_string(unsigned char);
 extern const char *scsi_extd_sense_format(unsigned char, unsigned char,
                                           const char **);
+extern const char *scsi_mlreturn_string(int);
+extern const char *scsi_hostbyte_string(int);
+extern const char *scsi_driverbyte_string(int);
+#else
+static inline bool
+scsi_opcode_sa_name(int cmd, int sa,
+                    const char **cdb_name, const char **sa_name)
+{
+        *cdb_name = NULL;
+        switch (cmd) {
+        case VARIABLE_LENGTH_CMD:
+        case MAINTENANCE_IN:
+        case MAINTENANCE_OUT:
+        case PERSISTENT_RESERVE_IN:
+        case PERSISTENT_RESERVE_OUT:
+        case SERVICE_ACTION_IN_12:
+        case SERVICE_ACTION_OUT_12:
+        case SERVICE_ACTION_BIDIRECTIONAL:
+        case SERVICE_ACTION_IN_16:
+        case SERVICE_ACTION_OUT_16:
+        case EXTENDED_COPY:
+        case RECEIVE_COPY_RESULTS:
+                *sa_name = NULL;
+                return true;
+        default:
+                return false;
+        }
+}
+
+static inline const char *
+scsi_sense_key_string(unsigned char key)
+{
+        return NULL;
+}
+
+static inline const char *
+scsi_extd_sense_format(unsigned char asc, unsigned char ascq, const char **fmt)
+{
+        *fmt = NULL;
+        return NULL;
+}
+
+static inline const char *
+scsi_mlreturn_string(int result)
+{
+        return NULL;
+}
+
+static inline const char *
+scsi_hostbyte_string(int result)
+{
+        return NULL;
+}
+
+static inline const char *
+scsi_driverbyte_string(int result)
+{
+        return NULL;
+}
+
+#endif
 
 #endif /* _SCSI_SCSI_DBG_H */