diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2012-12-28 11:58:38 -0500 |
|---|---|---|
| committer | Oleg Nesterov <oleg@redhat.com> | 2013-02-08 11:47:10 -0500 |
| commit | 8a7f2fa0dea3b019500961b86d765e6fdd4bffb2 (patch) | |
| tree | c6c467e02da75a9e92f8541cf8889dbd0e2fe5fb /include/linux | |
| parent | 806a98bdf2a862fef0fc880399d677b35ba525ff (diff) | |
uprobes: Reintroduce uprobe_consumer->filter()
Finally add uprobe_consumer->filter() and change consumer_filter()
to actually call this method.
Note that ->filter() accepts mm_struct, not task_struct. Because:
1. We do not have for_each_mm_user(mm, task).
2. Even if we implement for_each_mm_user(), ->filter() can
use it itself.
3. It is not clear who will actually need this interface to
do the "nontrivial" filtering.
Another argument is "enum uprobe_filter_ctx", consumer->filter() can
use it to figure out why/where it was called. For example, perhaps
we can add UPROBE_FILTER_PRE_REGISTER used by build_map_info() to
quickly "nack" the unwanted mm's. In this case consumer should know
that it is called under ->i_mmap_mutex.
See the previous discussion at http://marc.info/?t=135214229700002
Perhaps we should pass more arguments, vma/vaddr?
Note: this patch obviously can't help to filter out the child created
by fork(), this will be addressed later.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/uprobes.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h index 83742b91ff73..c2df6934fdc6 100644 --- a/include/linux/uprobes.h +++ b/include/linux/uprobes.h | |||
| @@ -35,8 +35,17 @@ struct inode; | |||
| 35 | # include <asm/uprobes.h> | 35 | # include <asm/uprobes.h> |
| 36 | #endif | 36 | #endif |
| 37 | 37 | ||
| 38 | enum uprobe_filter_ctx { | ||
| 39 | UPROBE_FILTER_REGISTER, | ||
| 40 | UPROBE_FILTER_UNREGISTER, | ||
| 41 | UPROBE_FILTER_MMAP, | ||
| 42 | }; | ||
| 43 | |||
| 38 | struct uprobe_consumer { | 44 | struct uprobe_consumer { |
| 39 | int (*handler)(struct uprobe_consumer *self, struct pt_regs *regs); | 45 | int (*handler)(struct uprobe_consumer *self, struct pt_regs *regs); |
| 46 | bool (*filter)(struct uprobe_consumer *self, | ||
| 47 | enum uprobe_filter_ctx ctx, | ||
| 48 | struct mm_struct *mm); | ||
| 40 | 49 | ||
| 41 | struct uprobe_consumer *next; | 50 | struct uprobe_consumer *next; |
| 42 | }; | 51 | }; |
