diff options
| author | Joseph Gasparakis <joseph.gasparakis@intel.com> | 2013-09-13 10:34:13 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-09-15 22:18:13 -0400 |
| commit | 35e4237973665c8a1ad4e3f7a7cb87573deaa24a (patch) | |
| tree | ce2529c137ec6b1da4f81aa77c2882706bd0c80c /include/linux | |
| parent | 5c44bbdab5fd7831859cf0d38626317ffcf39558 (diff) | |
vxlan: Fix sparse warnings
This patch fixes sparse warnings when incorrectly handling the port number
and using int instead of unsigned int iterating through &vn->sock_list[].
Keeping the port as __be16 also makes things clearer wrt endianess.
Also, it was pointed out that vxlan_get_rx_port() had unnecessary checks
which got removed.
Signed-off-by: Joseph Gasparakis <joseph.gasparakis@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/netdevice.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 041b42a305f6..3de49aca4519 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h | |||
| @@ -950,14 +950,14 @@ struct netdev_phys_port_id { | |||
| 950 | * multiple net devices on single physical port. | 950 | * multiple net devices on single physical port. |
| 951 | * | 951 | * |
| 952 | * void (*ndo_add_vxlan_port)(struct net_device *dev, | 952 | * void (*ndo_add_vxlan_port)(struct net_device *dev, |
| 953 | * sa_family_t sa_family, __u16 port); | 953 | * sa_family_t sa_family, __be16 port); |
| 954 | * Called by vxlan to notiy a driver about the UDP port and socket | 954 | * Called by vxlan to notiy a driver about the UDP port and socket |
| 955 | * address family that vxlan is listnening to. It is called only when | 955 | * address family that vxlan is listnening to. It is called only when |
| 956 | * a new port starts listening. The operation is protected by the | 956 | * a new port starts listening. The operation is protected by the |
| 957 | * vxlan_net->sock_lock. | 957 | * vxlan_net->sock_lock. |
| 958 | * | 958 | * |
| 959 | * void (*ndo_del_vxlan_port)(struct net_device *dev, | 959 | * void (*ndo_del_vxlan_port)(struct net_device *dev, |
| 960 | * sa_family_t sa_family, __u16 port); | 960 | * sa_family_t sa_family, __be16 port); |
| 961 | * Called by vxlan to notify the driver about a UDP port and socket | 961 | * Called by vxlan to notify the driver about a UDP port and socket |
| 962 | * address family that vxlan is not listening to anymore. The operation | 962 | * address family that vxlan is not listening to anymore. The operation |
| 963 | * is protected by the vxlan_net->sock_lock. | 963 | * is protected by the vxlan_net->sock_lock. |
| @@ -1093,10 +1093,10 @@ struct net_device_ops { | |||
| 1093 | struct netdev_phys_port_id *ppid); | 1093 | struct netdev_phys_port_id *ppid); |
| 1094 | void (*ndo_add_vxlan_port)(struct net_device *dev, | 1094 | void (*ndo_add_vxlan_port)(struct net_device *dev, |
| 1095 | sa_family_t sa_family, | 1095 | sa_family_t sa_family, |
| 1096 | __u16 port); | 1096 | __be16 port); |
| 1097 | void (*ndo_del_vxlan_port)(struct net_device *dev, | 1097 | void (*ndo_del_vxlan_port)(struct net_device *dev, |
| 1098 | sa_family_t sa_family, | 1098 | sa_family_t sa_family, |
| 1099 | __u16 port); | 1099 | __be16 port); |
| 1100 | }; | 1100 | }; |
| 1101 | 1101 | ||
| 1102 | /* | 1102 | /* |
