diff options
author | Manfred Spraul <manfred@colorfullife.com> | 2010-05-26 17:43:42 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-27 12:12:49 -0400 |
commit | 31a7c4746e9925512afab30557dd445d677cc802 (patch) | |
tree | 7f7b39331aa51b77c159b046d406b12aec24de11 /include/linux/sem.h | |
parent | 0a2b9d4c79671b05956806ede5d054e03ae56280 (diff) |
ipc/sem.c: cacheline align the ipc spinlock for semaphores
Cacheline align the spinlock for sysv semaphores. Without the patch, the
spinlock and sem_otime [written by every semop that modified the array]
and sem_base [read in the hot path of try_atomic_semop()] can be in the
same cacheline.
Signed-off-by: Manfred Spraul <manfred@colorfullife.com>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Zach Brown <zach.brown@oracle.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/sem.h')
-rw-r--r-- | include/linux/sem.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/linux/sem.h b/include/linux/sem.h index 8a4adbef8a0f..f2961afa2f66 100644 --- a/include/linux/sem.h +++ b/include/linux/sem.h | |||
@@ -79,6 +79,7 @@ struct seminfo { | |||
79 | #ifdef __KERNEL__ | 79 | #ifdef __KERNEL__ |
80 | #include <asm/atomic.h> | 80 | #include <asm/atomic.h> |
81 | #include <linux/rcupdate.h> | 81 | #include <linux/rcupdate.h> |
82 | #include <linux/cache.h> | ||
82 | 83 | ||
83 | struct task_struct; | 84 | struct task_struct; |
84 | 85 | ||
@@ -91,7 +92,8 @@ struct sem { | |||
91 | 92 | ||
92 | /* One sem_array data structure for each set of semaphores in the system. */ | 93 | /* One sem_array data structure for each set of semaphores in the system. */ |
93 | struct sem_array { | 94 | struct sem_array { |
94 | struct kern_ipc_perm sem_perm; /* permissions .. see ipc.h */ | 95 | struct kern_ipc_perm ____cacheline_aligned_in_smp |
96 | sem_perm; /* permissions .. see ipc.h */ | ||
95 | time_t sem_otime; /* last semop time */ | 97 | time_t sem_otime; /* last semop time */ |
96 | time_t sem_ctime; /* last change time */ | 98 | time_t sem_ctime; /* last change time */ |
97 | struct sem *sem_base; /* ptr to first semaphore in array */ | 99 | struct sem *sem_base; /* ptr to first semaphore in array */ |