aboutsummaryrefslogtreecommitdiffstats
path: root/include/linux/percpu-rwsem.h
diff options
context:
space:
mode:
authorMikulas Patocka <mpatocka@redhat.com>2012-10-22 19:39:16 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2012-10-28 13:59:36 -0400
commit1bf11c53535ab87e3bf14ecdf6747bf46f601c5d (patch)
tree9170fa956be0f564b988a88685eb82584347c2cf /include/linux/percpu-rwsem.h
parent5c1eabe68501d1e1b1586c7f4c46cc531828c4ab (diff)
percpu-rw-semaphores: use rcu_read_lock_sched
Use rcu_read_lock_sched / rcu_read_unlock_sched / synchronize_sched instead of rcu_read_lock / rcu_read_unlock / synchronize_rcu. This is an optimization. The RCU-protected region is very small, so there will be no latency problems if we disable preempt in this region. So we use rcu_read_lock_sched / rcu_read_unlock_sched that translates to preempt_disable / preempt_disable. It is smaller (and supposedly faster) than preemptible rcu_read_lock / rcu_read_unlock. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/percpu-rwsem.h')
-rw-r--r--include/linux/percpu-rwsem.h8
1 files changed, 4 insertions, 4 deletions
diff --git a/include/linux/percpu-rwsem.h b/include/linux/percpu-rwsem.h
index 18f35b54286c..250a4acddb2b 100644
--- a/include/linux/percpu-rwsem.h
+++ b/include/linux/percpu-rwsem.h
@@ -17,16 +17,16 @@ struct percpu_rw_semaphore {
17 17
18static inline void percpu_down_read(struct percpu_rw_semaphore *p) 18static inline void percpu_down_read(struct percpu_rw_semaphore *p)
19{ 19{
20 rcu_read_lock(); 20 rcu_read_lock_sched();
21 if (unlikely(p->locked)) { 21 if (unlikely(p->locked)) {
22 rcu_read_unlock(); 22 rcu_read_unlock_sched();
23 mutex_lock(&p->mtx); 23 mutex_lock(&p->mtx);
24 this_cpu_inc(*p->counters); 24 this_cpu_inc(*p->counters);
25 mutex_unlock(&p->mtx); 25 mutex_unlock(&p->mtx);
26 return; 26 return;
27 } 27 }
28 this_cpu_inc(*p->counters); 28 this_cpu_inc(*p->counters);
29 rcu_read_unlock(); 29 rcu_read_unlock_sched();
30 light_mb(); /* A, between read of p->locked and read of data, paired with D */ 30 light_mb(); /* A, between read of p->locked and read of data, paired with D */
31} 31}
32 32
@@ -51,7 +51,7 @@ static inline void percpu_down_write(struct percpu_rw_semaphore *p)
51{ 51{
52 mutex_lock(&p->mtx); 52 mutex_lock(&p->mtx);
53 p->locked = true; 53 p->locked = true;
54 synchronize_rcu(); 54 synchronize_sched(); /* make sure that all readers exit the rcu_read_lock_sched region */
55 while (__percpu_count(p->counters)) 55 while (__percpu_count(p->counters))
56 msleep(1); 56 msleep(1);
57 heavy_mb(); /* C, between read of p->counter and write to data, paired with B */ 57 heavy_mb(); /* C, between read of p->counter and write to data, paired with B */