diff options
author | Christoph Lameter <clameter@engr.sgi.com> | 2007-03-05 03:30:33 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-03-05 10:57:51 -0500 |
commit | 0dc952dc3e6d96d554a19fa7bee3f3b1d55e3cff (patch) | |
tree | 1dcf2ff93784716143b7acef816888a71a9504c2 /include/linux/migrate.h | |
parent | 1f2b69f9bdce8461341e5fb864568a2ee90079c8 (diff) |
[PATCH] Page migration: Fix vma flag checking
Currently we do not check for vma flags if sys_move_pages is called to move
individual pages. If sys_migrate_pages is called to move pages then we
check for vm_flags that indicate a non migratable vma but that still
includes VM_LOCKED and we can migrate mlocked pages.
Extract the vma_migratable check from mm/mempolicy.c, fix it and put it
into migrate.h so that is can be used from both locations.
Problem was spotted by Lee Schermerhorn
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/migrate.h')
-rw-r--r-- | include/linux/migrate.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/include/linux/migrate.h b/include/linux/migrate.h index 48148e0cdbd1..75e55dcdeb18 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h | |||
@@ -5,6 +5,14 @@ | |||
5 | 5 | ||
6 | typedef struct page *new_page_t(struct page *, unsigned long private, int **); | 6 | typedef struct page *new_page_t(struct page *, unsigned long private, int **); |
7 | 7 | ||
8 | /* Check if a vma is migratable */ | ||
9 | static inline int vma_migratable(struct vm_area_struct *vma) | ||
10 | { | ||
11 | if (vma->vm_flags & (VM_IO|VM_HUGETLB|VM_PFNMAP|VM_RESERVED)) | ||
12 | return 0; | ||
13 | return 1; | ||
14 | } | ||
15 | |||
8 | #ifdef CONFIG_MIGRATION | 16 | #ifdef CONFIG_MIGRATION |
9 | extern int isolate_lru_page(struct page *p, struct list_head *pagelist); | 17 | extern int isolate_lru_page(struct page *p, struct list_head *pagelist); |
10 | extern int putback_lru_pages(struct list_head *l); | 18 | extern int putback_lru_pages(struct list_head *l); |