diff options
author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2013-12-19 10:28:29 -0500 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2014-01-07 03:41:15 -0500 |
commit | 7e170c6e4f7501bea900aa66b2b27a6ce5001e25 (patch) | |
tree | 76eea8291945b24d8bbbf215243f7239c9728a08 /include/linux/mfd/ti_am335x_tscadc.h | |
parent | 3466bd2273b81a0a29d0e134ba1c78b64b84f40b (diff) |
mfd: ti_am335x_tscadc: Don't read back REG_SE
The purpose of reg_se_cache has been defeated. It should avoid the
read-back of the register to avoid the latency and the fact that the
bits are reset to 0 after the individual conversation took place.
The reason why this is required like this to work, is that read-back of
the register removes the bits of the ADC so they do not start another
conversation after the register is re-written from the TSC side for the
update.
To avoid the not required read-back I introduce a "set once" variant which
does not update the cache mask. After the conversation completes, the
bit is removed from the SE register anyway and we don't plan a new
conversation "any time soon". The current set function is renamed to
set_cache to distinguish the two operations.
This is a small preparation for a larger sync-rework.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'include/linux/mfd/ti_am335x_tscadc.h')
-rw-r--r-- | include/linux/mfd/ti_am335x_tscadc.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h index 1fe72199e670..2fa9c0613da4 100644 --- a/include/linux/mfd/ti_am335x_tscadc.h +++ b/include/linux/mfd/ti_am335x_tscadc.h | |||
@@ -176,7 +176,8 @@ static inline struct ti_tscadc_dev *ti_tscadc_dev_get(struct platform_device *p) | |||
176 | return *tscadc_dev; | 176 | return *tscadc_dev; |
177 | } | 177 | } |
178 | 178 | ||
179 | void am335x_tsc_se_set(struct ti_tscadc_dev *tsadc, u32 val); | 179 | void am335x_tsc_se_set_cache(struct ti_tscadc_dev *tsadc, u32 val); |
180 | void am335x_tsc_se_set_once(struct ti_tscadc_dev *tsadc, u32 val); | ||
180 | void am335x_tsc_se_clr(struct ti_tscadc_dev *tsadc, u32 val); | 181 | void am335x_tsc_se_clr(struct ti_tscadc_dev *tsadc, u32 val); |
181 | 182 | ||
182 | #endif | 183 | #endif |