diff options
author | Jim Cromie <jim.cromie@gmail.com> | 2011-12-19 17:11:18 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2012-01-24 15:46:44 -0500 |
commit | b558c96ffa53f4b3dd52b774e4fb7a52982ab52b (patch) | |
tree | c178b95b2f1bb9e146d4f33f287ab37c2dab119a /include/linux/device.h | |
parent | 87e6f968339bcdda56b39572c7e63331192296a0 (diff) |
dynamic_debug: make dynamic-debug supersede DEBUG ccflag
If CONFIG_DYNAMIC_DEBUG is defined, honor it over DEBUG, so that
pr_debug()s are controllable, instead of always-on. When DEBUG is
also defined, change _DPRINTK_FLAGS_DEFAULT to enable printing by
default.
Also adding _DPRINTK_FLAGS_INCL_MODNAME would be nice, but there are
numerous cases of pr_debug(NAME ": ...), which would result in double
printing of module-name. So defer this until things settle.
Cc: David Miller <davem@davemloft.net>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Signed-off-by: Jason Baron <jbaron@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'include/linux/device.h')
-rw-r--r-- | include/linux/device.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/include/linux/device.h b/include/linux/device.h index 5b3adb8f9588..a782d7ff9e8b 100644 --- a/include/linux/device.h +++ b/include/linux/device.h | |||
@@ -945,14 +945,14 @@ int _dev_info(const struct device *dev, const char *fmt, ...) | |||
945 | 945 | ||
946 | #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg) | 946 | #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg) |
947 | 947 | ||
948 | #if defined(DEBUG) | 948 | #if defined(CONFIG_DYNAMIC_DEBUG) |
949 | #define dev_dbg(dev, format, arg...) \ | ||
950 | dev_printk(KERN_DEBUG, dev, format, ##arg) | ||
951 | #elif defined(CONFIG_DYNAMIC_DEBUG) | ||
952 | #define dev_dbg(dev, format, ...) \ | 949 | #define dev_dbg(dev, format, ...) \ |
953 | do { \ | 950 | do { \ |
954 | dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \ | 951 | dynamic_dev_dbg(dev, format, ##__VA_ARGS__); \ |
955 | } while (0) | 952 | } while (0) |
953 | #elif defined(DEBUG) | ||
954 | #define dev_dbg(dev, format, arg...) \ | ||
955 | dev_printk(KERN_DEBUG, dev, format, ##arg) | ||
956 | #else | 956 | #else |
957 | #define dev_dbg(dev, format, arg...) \ | 957 | #define dev_dbg(dev, format, arg...) \ |
958 | ({ \ | 958 | ({ \ |