diff options
| author | Dave Airlie <airlied@redhat.com> | 2014-01-13 19:55:36 -0500 |
|---|---|---|
| committer | Dave Airlie <airlied@redhat.com> | 2014-01-13 19:55:36 -0500 |
| commit | faf096ffba2b1a4066e6d6dcd1243cc5f3d1fb23 (patch) | |
| tree | 4793c625d9eaae10f453b8c4d32543de86875402 /include/drm/ttm | |
| parent | a095c60bd06f204c98527aafd5fda6ef42b53eb5 (diff) | |
| parent | 94844cf06568d9592f985e4bd0b9d759a56043c6 (diff) | |
Merge tag 'vmwgfx-next-2014-01-13' of git://people.freedesktop.org/~thomash/linux into drm-next
Anyway, nothing big here, Three more code cleanup patches from Rashika
Kheria, and one TTM/vmwgfx patch from me that tightens security around TTM
objects enough for them to opened using prime objects from render nodes:
Previously any client could access a shared buffer using the "name", also
without actually opening it. Now a reference is required, and for render nodes
such a reference is intended to only be obtainable using a prime fd.
vmwgfx-next 2014-01-13 pull request
* tag 'vmwgfx-next-2014-01-13' of git://people.freedesktop.org/~thomash/linux:
drivers: gpu: Mark functions as static in vmwgfx_fence.c
drivers: gpu: Mark functions as static in vmwgfx_buffer.c
drivers: gpu: Mark functions as static in vmwgfx_kms.c
drm/ttm: ttm object security fixes for render nodes
Diffstat (limited to 'include/drm/ttm')
| -rw-r--r-- | include/drm/ttm/ttm_object.h | 18 |
1 files changed, 16 insertions, 2 deletions
diff --git a/include/drm/ttm/ttm_object.h b/include/drm/ttm/ttm_object.h index 58b029894eb3..0097cc03034e 100644 --- a/include/drm/ttm/ttm_object.h +++ b/include/drm/ttm/ttm_object.h | |||
| @@ -190,14 +190,26 @@ extern int ttm_base_object_init(struct ttm_object_file *tfile, | |||
| 190 | * @key: Hash key | 190 | * @key: Hash key |
| 191 | * | 191 | * |
| 192 | * Looks up a struct ttm_base_object with the key @key. | 192 | * Looks up a struct ttm_base_object with the key @key. |
| 193 | * Also verifies that the object is visible to the application, by | ||
| 194 | * comparing the @tfile argument and checking the object shareable flag. | ||
| 195 | */ | 193 | */ |
| 196 | 194 | ||
| 197 | extern struct ttm_base_object *ttm_base_object_lookup(struct ttm_object_file | 195 | extern struct ttm_base_object *ttm_base_object_lookup(struct ttm_object_file |
| 198 | *tfile, uint32_t key); | 196 | *tfile, uint32_t key); |
| 199 | 197 | ||
| 200 | /** | 198 | /** |
| 199 | * ttm_base_object_lookup_for_ref | ||
| 200 | * | ||
| 201 | * @tdev: Pointer to a struct ttm_object_device. | ||
| 202 | * @key: Hash key | ||
| 203 | * | ||
| 204 | * Looks up a struct ttm_base_object with the key @key. | ||
| 205 | * This function should only be used when the struct tfile associated with the | ||
| 206 | * caller doesn't yet have a reference to the base object. | ||
| 207 | */ | ||
| 208 | |||
| 209 | extern struct ttm_base_object * | ||
| 210 | ttm_base_object_lookup_for_ref(struct ttm_object_device *tdev, uint32_t key); | ||
| 211 | |||
| 212 | /** | ||
| 201 | * ttm_base_object_unref | 213 | * ttm_base_object_unref |
| 202 | * | 214 | * |
| 203 | * @p_base: Pointer to a pointer referencing a struct ttm_base_object. | 215 | * @p_base: Pointer to a pointer referencing a struct ttm_base_object. |
| @@ -218,6 +230,8 @@ extern void ttm_base_object_unref(struct ttm_base_object **p_base); | |||
| 218 | * @existed: Upon completion, indicates that an identical reference object | 230 | * @existed: Upon completion, indicates that an identical reference object |
| 219 | * already existed, and the refcount was upped on that object instead. | 231 | * already existed, and the refcount was upped on that object instead. |
| 220 | * | 232 | * |
| 233 | * Checks that the base object is shareable and adds a ref object to it. | ||
| 234 | * | ||
| 221 | * Adding a ref object to a base object is basically like referencing the | 235 | * Adding a ref object to a base object is basically like referencing the |
| 222 | * base object, but a user-space application holds the reference. When the | 236 | * base object, but a user-space application holds the reference. When the |
| 223 | * file corresponding to @tfile is closed, all its reference objects are | 237 | * file corresponding to @tfile is closed, all its reference objects are |
