diff options
author | Lv Zheng <lv.zheng@intel.com> | 2013-12-06 03:52:05 -0500 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-12-06 19:24:33 -0500 |
commit | 27d50c82714f6477ac690034b37d202f76eb4f70 (patch) | |
tree | 67a1d4e0e73b7e0167a7406ec962718ae2d58305 /include/acpi/acpi_io.h | |
parent | c099eacbcaec4475936fbf73e499507728ce47e1 (diff) |
ACPI / i915: Fix incorrect <acpi/acpi.h> inclusions via <linux/acpi_io.h>
To avoid build problems and breaking dependencies between ACPI header
files, <acpi/acpi.h> should not be included directly by code outside
of the ACPI core subsystem. However, that is possible if
<linux/acpi_io.h> is included, because that file contains
a direct inclusion of <acpi/acpi.h>.
For this reason, remove the direct <acpi/acpi.h> inclusion from
<linux/acpi_io.h>, move that file from include/linux/ to include/acpi/
and make <linux/acpi.h> include it for CONFIG_ACPI set along with the
other ACPI header files. Accordingly, Remove the inclusions of
<linux/acpi_io.h> from everywhere.
Of course, that causes the contents of the new <acpi/acpi_io.h> file
to be available for CONFIG_ACPI set only, so intel_opregion.o that
depends on it should also depend on CONFIG_ACPI (and it really should
not be compiled for CONFIG_ACPI unset anyway).
References: https://01.org/linuxgraphics/sites/default/files/documentation/acpi_igd_opregion_spec.pdf
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
[rjw: Subject and changelog]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'include/acpi/acpi_io.h')
-rw-r--r-- | include/acpi/acpi_io.h | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/include/acpi/acpi_io.h b/include/acpi/acpi_io.h new file mode 100644 index 000000000000..2be858018c7f --- /dev/null +++ b/include/acpi/acpi_io.h | |||
@@ -0,0 +1,17 @@ | |||
1 | #ifndef _ACPI_IO_H_ | ||
2 | #define _ACPI_IO_H_ | ||
3 | |||
4 | #include <linux/io.h> | ||
5 | |||
6 | static inline void __iomem *acpi_os_ioremap(acpi_physical_address phys, | ||
7 | acpi_size size) | ||
8 | { | ||
9 | return ioremap_cache(phys, size); | ||
10 | } | ||
11 | |||
12 | void __iomem *acpi_os_get_iomem(acpi_physical_address phys, unsigned int size); | ||
13 | |||
14 | int acpi_os_map_generic_address(struct acpi_generic_address *addr); | ||
15 | void acpi_os_unmap_generic_address(struct acpi_generic_address *addr); | ||
16 | |||
17 | #endif | ||