diff options
author | David Sterba <dsterba@suse.cz> | 2013-04-26 10:56:29 -0400 |
---|---|---|
committer | Josef Bacik <jbacik@fusionio.com> | 2013-05-06 15:55:24 -0400 |
commit | f7a52a40cabea38b99b5053bc4f7cf45f4997603 (patch) | |
tree | c7563b9e64a26cc0065210fa56756e5a6da32d7c /fs | |
parent | 34c2b29079ba505a1803fa620b5f116f07e48258 (diff) |
btrfs: remove unused gfp mask parameter from release_extent_buffer callchain
It's unused since 0b32f4bbb423f02ac.
Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/btrfs/disk-io.c | 8 | ||||
-rw-r--r-- | fs/btrfs/extent_io.c | 13 | ||||
-rw-r--r-- | fs/btrfs/extent_io.h | 2 |
3 files changed, 7 insertions, 16 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index ac132d9637bb..2bc1ecf5e840 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c | |||
@@ -966,14 +966,8 @@ static int btree_releasepage(struct page *page, gfp_t gfp_flags) | |||
966 | { | 966 | { |
967 | if (PageWriteback(page) || PageDirty(page)) | 967 | if (PageWriteback(page) || PageDirty(page)) |
968 | return 0; | 968 | return 0; |
969 | /* | ||
970 | * We need to mask out eg. __GFP_HIGHMEM and __GFP_DMA32 as we're doing | ||
971 | * slab allocation from alloc_extent_state down the callchain where | ||
972 | * it'd hit a BUG_ON as those flags are not allowed. | ||
973 | */ | ||
974 | gfp_flags &= ~GFP_SLAB_BUG_MASK; | ||
975 | 969 | ||
976 | return try_release_extent_buffer(page, gfp_flags); | 970 | return try_release_extent_buffer(page); |
977 | } | 971 | } |
978 | 972 | ||
979 | static void btree_invalidatepage(struct page *page, unsigned long offset) | 973 | static void btree_invalidatepage(struct page *page, unsigned long offset) |
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 77c5914f6090..9b93e8076162 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c | |||
@@ -4450,7 +4450,7 @@ static inline void btrfs_release_extent_buffer_rcu(struct rcu_head *head) | |||
4450 | } | 4450 | } |
4451 | 4451 | ||
4452 | /* Expects to have eb->eb_lock already held */ | 4452 | /* Expects to have eb->eb_lock already held */ |
4453 | static int release_extent_buffer(struct extent_buffer *eb, gfp_t mask) | 4453 | static int release_extent_buffer(struct extent_buffer *eb) |
4454 | { | 4454 | { |
4455 | WARN_ON(atomic_read(&eb->refs) == 0); | 4455 | WARN_ON(atomic_read(&eb->refs) == 0); |
4456 | if (atomic_dec_and_test(&eb->refs)) { | 4456 | if (atomic_dec_and_test(&eb->refs)) { |
@@ -4508,7 +4508,7 @@ void free_extent_buffer(struct extent_buffer *eb) | |||
4508 | * I know this is terrible, but it's temporary until we stop tracking | 4508 | * I know this is terrible, but it's temporary until we stop tracking |
4509 | * the uptodate bits and such for the extent buffers. | 4509 | * the uptodate bits and such for the extent buffers. |
4510 | */ | 4510 | */ |
4511 | release_extent_buffer(eb, GFP_ATOMIC); | 4511 | release_extent_buffer(eb); |
4512 | } | 4512 | } |
4513 | 4513 | ||
4514 | void free_extent_buffer_stale(struct extent_buffer *eb) | 4514 | void free_extent_buffer_stale(struct extent_buffer *eb) |
@@ -4522,7 +4522,7 @@ void free_extent_buffer_stale(struct extent_buffer *eb) | |||
4522 | if (atomic_read(&eb->refs) == 2 && !extent_buffer_under_io(eb) && | 4522 | if (atomic_read(&eb->refs) == 2 && !extent_buffer_under_io(eb) && |
4523 | test_and_clear_bit(EXTENT_BUFFER_TREE_REF, &eb->bflags)) | 4523 | test_and_clear_bit(EXTENT_BUFFER_TREE_REF, &eb->bflags)) |
4524 | atomic_dec(&eb->refs); | 4524 | atomic_dec(&eb->refs); |
4525 | release_extent_buffer(eb, GFP_NOFS); | 4525 | release_extent_buffer(eb); |
4526 | } | 4526 | } |
4527 | 4527 | ||
4528 | void clear_extent_buffer_dirty(struct extent_buffer *eb) | 4528 | void clear_extent_buffer_dirty(struct extent_buffer *eb) |
@@ -5042,7 +5042,7 @@ void memmove_extent_buffer(struct extent_buffer *dst, unsigned long dst_offset, | |||
5042 | } | 5042 | } |
5043 | } | 5043 | } |
5044 | 5044 | ||
5045 | int try_release_extent_buffer(struct page *page, gfp_t mask) | 5045 | int try_release_extent_buffer(struct page *page) |
5046 | { | 5046 | { |
5047 | struct extent_buffer *eb; | 5047 | struct extent_buffer *eb; |
5048 | 5048 | ||
@@ -5072,9 +5072,6 @@ int try_release_extent_buffer(struct page *page, gfp_t mask) | |||
5072 | } | 5072 | } |
5073 | spin_unlock(&page->mapping->private_lock); | 5073 | spin_unlock(&page->mapping->private_lock); |
5074 | 5074 | ||
5075 | if ((mask & GFP_NOFS) == GFP_NOFS) | ||
5076 | mask = GFP_NOFS; | ||
5077 | |||
5078 | /* | 5075 | /* |
5079 | * If tree ref isn't set then we know the ref on this eb is a real ref, | 5076 | * If tree ref isn't set then we know the ref on this eb is a real ref, |
5080 | * so just return, this page will likely be freed soon anyway. | 5077 | * so just return, this page will likely be freed soon anyway. |
@@ -5084,5 +5081,5 @@ int try_release_extent_buffer(struct page *page, gfp_t mask) | |||
5084 | return 0; | 5081 | return 0; |
5085 | } | 5082 | } |
5086 | 5083 | ||
5087 | return release_extent_buffer(eb, mask); | 5084 | return release_extent_buffer(eb); |
5088 | } | 5085 | } |
diff --git a/fs/btrfs/extent_io.h b/fs/btrfs/extent_io.h index 9ebb4c7b86d1..3af58bf55ddc 100644 --- a/fs/btrfs/extent_io.h +++ b/fs/btrfs/extent_io.h | |||
@@ -189,7 +189,7 @@ void extent_io_tree_init(struct extent_io_tree *tree, | |||
189 | int try_release_extent_mapping(struct extent_map_tree *map, | 189 | int try_release_extent_mapping(struct extent_map_tree *map, |
190 | struct extent_io_tree *tree, struct page *page, | 190 | struct extent_io_tree *tree, struct page *page, |
191 | gfp_t mask); | 191 | gfp_t mask); |
192 | int try_release_extent_buffer(struct page *page, gfp_t mask); | 192 | int try_release_extent_buffer(struct page *page); |
193 | int lock_extent(struct extent_io_tree *tree, u64 start, u64 end); | 193 | int lock_extent(struct extent_io_tree *tree, u64 start, u64 end); |
194 | int lock_extent_bits(struct extent_io_tree *tree, u64 start, u64 end, | 194 | int lock_extent_bits(struct extent_io_tree *tree, u64 start, u64 end, |
195 | int bits, struct extent_state **cached); | 195 | int bits, struct extent_state **cached); |