diff options
| author | Namjae Jeon <namjae.jeon@samsung.com> | 2013-02-17 01:48:11 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2013-02-26 02:46:10 -0500 |
| commit | 94e07a7590ae855bae0536c42b3086fadc7c83a8 (patch) | |
| tree | a34b3acd03dc5da51b3307478dd572fbd6d22880 /fs | |
| parent | 182be684784334598eee1d90274e7f7aa0063616 (diff) | |
fs: encode_fh: return FILEID_INVALID if invalid fid_type
This patch is a follow up on below patch:
[PATCH] exportfs: add FILEID_INVALID to indicate invalid fid_type
commit: 216b6cbdcbd86b1db0754d58886b466ae31f5a63
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Acked-by: Sage Weil <sage@inktank.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/export.c | 4 | ||||
| -rw-r--r-- | fs/ceph/export.c | 4 | ||||
| -rw-r--r-- | fs/fuse/inode.c | 2 | ||||
| -rw-r--r-- | fs/gfs2/export.c | 4 | ||||
| -rw-r--r-- | fs/isofs/export.c | 4 | ||||
| -rw-r--r-- | fs/nilfs2/namei.c | 4 | ||||
| -rw-r--r-- | fs/ocfs2/export.c | 4 | ||||
| -rw-r--r-- | fs/reiserfs/inode.c | 4 | ||||
| -rw-r--r-- | fs/udf/namei.c | 4 | ||||
| -rw-r--r-- | fs/xfs/xfs_export.c | 4 |
10 files changed, 19 insertions, 19 deletions
diff --git a/fs/btrfs/export.c b/fs/btrfs/export.c index 614f34a899c2..81ee29eeb7ca 100644 --- a/fs/btrfs/export.c +++ b/fs/btrfs/export.c | |||
| @@ -22,10 +22,10 @@ static int btrfs_encode_fh(struct inode *inode, u32 *fh, int *max_len, | |||
| 22 | 22 | ||
| 23 | if (parent && (len < BTRFS_FID_SIZE_CONNECTABLE)) { | 23 | if (parent && (len < BTRFS_FID_SIZE_CONNECTABLE)) { |
| 24 | *max_len = BTRFS_FID_SIZE_CONNECTABLE; | 24 | *max_len = BTRFS_FID_SIZE_CONNECTABLE; |
| 25 | return 255; | 25 | return FILEID_INVALID; |
| 26 | } else if (len < BTRFS_FID_SIZE_NON_CONNECTABLE) { | 26 | } else if (len < BTRFS_FID_SIZE_NON_CONNECTABLE) { |
| 27 | *max_len = BTRFS_FID_SIZE_NON_CONNECTABLE; | 27 | *max_len = BTRFS_FID_SIZE_NON_CONNECTABLE; |
| 28 | return 255; | 28 | return FILEID_INVALID; |
| 29 | } | 29 | } |
| 30 | 30 | ||
| 31 | len = BTRFS_FID_SIZE_NON_CONNECTABLE; | 31 | len = BTRFS_FID_SIZE_NON_CONNECTABLE; |
diff --git a/fs/ceph/export.c b/fs/ceph/export.c index ca3ab3f9ca70..16796be53ca5 100644 --- a/fs/ceph/export.c +++ b/fs/ceph/export.c | |||
| @@ -81,7 +81,7 @@ static int ceph_encode_fh(struct inode *inode, u32 *rawfh, int *max_len, | |||
| 81 | if (parent_inode) { | 81 | if (parent_inode) { |
| 82 | /* nfsd wants connectable */ | 82 | /* nfsd wants connectable */ |
| 83 | *max_len = connected_handle_length; | 83 | *max_len = connected_handle_length; |
| 84 | type = 255; | 84 | type = FILEID_INVALID; |
| 85 | } else { | 85 | } else { |
| 86 | dout("encode_fh %p\n", dentry); | 86 | dout("encode_fh %p\n", dentry); |
| 87 | fh->ino = ceph_ino(inode); | 87 | fh->ino = ceph_ino(inode); |
| @@ -90,7 +90,7 @@ static int ceph_encode_fh(struct inode *inode, u32 *rawfh, int *max_len, | |||
| 90 | } | 90 | } |
| 91 | } else { | 91 | } else { |
| 92 | *max_len = handle_length; | 92 | *max_len = handle_length; |
| 93 | type = 255; | 93 | type = FILEID_INVALID; |
| 94 | } | 94 | } |
| 95 | if (dentry) | 95 | if (dentry) |
| 96 | dput(dentry); | 96 | dput(dentry); |
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 73ca6b72beaf..b730fda9aa4c 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c | |||
| @@ -678,7 +678,7 @@ static int fuse_encode_fh(struct inode *inode, u32 *fh, int *max_len, | |||
| 678 | 678 | ||
| 679 | if (*max_len < len) { | 679 | if (*max_len < len) { |
| 680 | *max_len = len; | 680 | *max_len = len; |
| 681 | return 255; | 681 | return FILEID_INVALID; |
| 682 | } | 682 | } |
| 683 | 683 | ||
| 684 | nodeid = get_fuse_inode(inode)->nodeid; | 684 | nodeid = get_fuse_inode(inode)->nodeid; |
diff --git a/fs/gfs2/export.c b/fs/gfs2/export.c index 4767774a5f3e..9973df4ff565 100644 --- a/fs/gfs2/export.c +++ b/fs/gfs2/export.c | |||
| @@ -37,10 +37,10 @@ static int gfs2_encode_fh(struct inode *inode, __u32 *p, int *len, | |||
| 37 | 37 | ||
| 38 | if (parent && (*len < GFS2_LARGE_FH_SIZE)) { | 38 | if (parent && (*len < GFS2_LARGE_FH_SIZE)) { |
| 39 | *len = GFS2_LARGE_FH_SIZE; | 39 | *len = GFS2_LARGE_FH_SIZE; |
| 40 | return 255; | 40 | return FILEID_INVALID; |
| 41 | } else if (*len < GFS2_SMALL_FH_SIZE) { | 41 | } else if (*len < GFS2_SMALL_FH_SIZE) { |
| 42 | *len = GFS2_SMALL_FH_SIZE; | 42 | *len = GFS2_SMALL_FH_SIZE; |
| 43 | return 255; | 43 | return FILEID_INVALID; |
| 44 | } | 44 | } |
| 45 | 45 | ||
| 46 | fh[0] = cpu_to_be32(ip->i_no_formal_ino >> 32); | 46 | fh[0] = cpu_to_be32(ip->i_no_formal_ino >> 32); |
diff --git a/fs/isofs/export.c b/fs/isofs/export.c index 2b4f2358eadb..12088d8de3fa 100644 --- a/fs/isofs/export.c +++ b/fs/isofs/export.c | |||
| @@ -125,10 +125,10 @@ isofs_export_encode_fh(struct inode *inode, | |||
| 125 | */ | 125 | */ |
| 126 | if (parent && (len < 5)) { | 126 | if (parent && (len < 5)) { |
| 127 | *max_len = 5; | 127 | *max_len = 5; |
| 128 | return 255; | 128 | return FILEID_INVALID; |
| 129 | } else if (len < 3) { | 129 | } else if (len < 3) { |
| 130 | *max_len = 3; | 130 | *max_len = 3; |
| 131 | return 255; | 131 | return FILEID_INVALID; |
| 132 | } | 132 | } |
| 133 | 133 | ||
| 134 | len = 3; | 134 | len = 3; |
diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c index 1d0c0b84c5a3..9de78f08989e 100644 --- a/fs/nilfs2/namei.c +++ b/fs/nilfs2/namei.c | |||
| @@ -517,11 +517,11 @@ static int nilfs_encode_fh(struct inode *inode, __u32 *fh, int *lenp, | |||
| 517 | 517 | ||
| 518 | if (parent && *lenp < NILFS_FID_SIZE_CONNECTABLE) { | 518 | if (parent && *lenp < NILFS_FID_SIZE_CONNECTABLE) { |
| 519 | *lenp = NILFS_FID_SIZE_CONNECTABLE; | 519 | *lenp = NILFS_FID_SIZE_CONNECTABLE; |
| 520 | return 255; | 520 | return FILEID_INVALID; |
| 521 | } | 521 | } |
| 522 | if (*lenp < NILFS_FID_SIZE_NON_CONNECTABLE) { | 522 | if (*lenp < NILFS_FID_SIZE_NON_CONNECTABLE) { |
| 523 | *lenp = NILFS_FID_SIZE_NON_CONNECTABLE; | 523 | *lenp = NILFS_FID_SIZE_NON_CONNECTABLE; |
| 524 | return 255; | 524 | return FILEID_INVALID; |
| 525 | } | 525 | } |
| 526 | 526 | ||
| 527 | fid->cno = root->cno; | 527 | fid->cno = root->cno; |
diff --git a/fs/ocfs2/export.c b/fs/ocfs2/export.c index 322216a5f0dd..29651167190d 100644 --- a/fs/ocfs2/export.c +++ b/fs/ocfs2/export.c | |||
| @@ -195,11 +195,11 @@ static int ocfs2_encode_fh(struct inode *inode, u32 *fh_in, int *max_len, | |||
| 195 | 195 | ||
| 196 | if (parent && (len < 6)) { | 196 | if (parent && (len < 6)) { |
| 197 | *max_len = 6; | 197 | *max_len = 6; |
| 198 | type = 255; | 198 | type = FILEID_INVALID; |
| 199 | goto bail; | 199 | goto bail; |
| 200 | } else if (len < 3) { | 200 | } else if (len < 3) { |
| 201 | *max_len = 3; | 201 | *max_len = 3; |
| 202 | type = 255; | 202 | type = FILEID_INVALID; |
| 203 | goto bail; | 203 | goto bail; |
| 204 | } | 204 | } |
| 205 | 205 | ||
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index 95d7680ead47..ea5061fd4f3e 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c | |||
| @@ -1603,10 +1603,10 @@ int reiserfs_encode_fh(struct inode *inode, __u32 * data, int *lenp, | |||
| 1603 | 1603 | ||
| 1604 | if (parent && (maxlen < 5)) { | 1604 | if (parent && (maxlen < 5)) { |
| 1605 | *lenp = 5; | 1605 | *lenp = 5; |
| 1606 | return 255; | 1606 | return FILEID_INVALID; |
| 1607 | } else if (maxlen < 3) { | 1607 | } else if (maxlen < 3) { |
| 1608 | *lenp = 3; | 1608 | *lenp = 3; |
| 1609 | return 255; | 1609 | return FILEID_INVALID; |
| 1610 | } | 1610 | } |
| 1611 | 1611 | ||
| 1612 | data[0] = inode->i_ino; | 1612 | data[0] = inode->i_ino; |
diff --git a/fs/udf/namei.c b/fs/udf/namei.c index 95fee278ab9d..102c072c6bbf 100644 --- a/fs/udf/namei.c +++ b/fs/udf/namei.c | |||
| @@ -1270,10 +1270,10 @@ static int udf_encode_fh(struct inode *inode, __u32 *fh, int *lenp, | |||
| 1270 | 1270 | ||
| 1271 | if (parent && (len < 5)) { | 1271 | if (parent && (len < 5)) { |
| 1272 | *lenp = 5; | 1272 | *lenp = 5; |
| 1273 | return 255; | 1273 | return FILEID_INVALID; |
| 1274 | } else if (len < 3) { | 1274 | } else if (len < 3) { |
| 1275 | *lenp = 3; | 1275 | *lenp = 3; |
| 1276 | return 255; | 1276 | return FILEID_INVALID; |
| 1277 | } | 1277 | } |
| 1278 | 1278 | ||
| 1279 | *lenp = 3; | 1279 | *lenp = 3; |
diff --git a/fs/xfs/xfs_export.c b/fs/xfs/xfs_export.c index a83611849cee..c585bc646395 100644 --- a/fs/xfs/xfs_export.c +++ b/fs/xfs/xfs_export.c | |||
| @@ -48,7 +48,7 @@ static int xfs_fileid_length(int fileid_type) | |||
| 48 | case FILEID_INO32_GEN_PARENT | XFS_FILEID_TYPE_64FLAG: | 48 | case FILEID_INO32_GEN_PARENT | XFS_FILEID_TYPE_64FLAG: |
| 49 | return 6; | 49 | return 6; |
| 50 | } | 50 | } |
| 51 | return 255; /* invalid */ | 51 | return FILEID_INVALID; |
| 52 | } | 52 | } |
| 53 | 53 | ||
| 54 | STATIC int | 54 | STATIC int |
| @@ -90,7 +90,7 @@ xfs_fs_encode_fh( | |||
| 90 | len = xfs_fileid_length(fileid_type); | 90 | len = xfs_fileid_length(fileid_type); |
| 91 | if (*max_len < len) { | 91 | if (*max_len < len) { |
| 92 | *max_len = len; | 92 | *max_len = len; |
| 93 | return 255; | 93 | return FILEID_INVALID; |
| 94 | } | 94 | } |
| 95 | *max_len = len; | 95 | *max_len = len; |
| 96 | 96 | ||
