aboutsummaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorMiao Xie <miaox@cn.fujitsu.com>2014-09-03 09:35:30 -0400
committerChris Mason <clm@fb.com>2014-09-17 16:38:29 -0400
commit90180da42c38a83b050452aa555d3d2df6ae2ad4 (patch)
treec9204e45bd710cf8cc1ed13dccd498e432dfda9e /fs
parent82f70d62f7923cc43128e75ae85366f137055b76 (diff)
Btrfs: cleanup unused num_can_discard in fs_devices
The member variants - num_can_discard - of fs_devices structure are set, but no one use them to do anything. so remove them. Signed-off-by: Miao Xie <miaox@cn.fujitsu.com> Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/btrfs/volumes.c16
-rw-r--r--fs/btrfs/volumes.h1
2 files changed, 2 insertions, 15 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index e9676a424309..483fc6d45299 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -720,8 +720,6 @@ static int __btrfs_close_devices(struct btrfs_fs_devices *fs_devices)
720 fs_devices->rw_devices--; 720 fs_devices->rw_devices--;
721 } 721 }
722 722
723 if (device->can_discard)
724 fs_devices->num_can_discard--;
725 if (device->missing) 723 if (device->missing)
726 fs_devices->missing_devices--; 724 fs_devices->missing_devices--;
727 725
@@ -828,10 +826,8 @@ static int __btrfs_open_devices(struct btrfs_fs_devices *fs_devices,
828 } 826 }
829 827
830 q = bdev_get_queue(bdev); 828 q = bdev_get_queue(bdev);
831 if (blk_queue_discard(q)) { 829 if (blk_queue_discard(q))
832 device->can_discard = 1; 830 device->can_discard = 1;
833 fs_devices->num_can_discard++;
834 }
835 831
836 device->bdev = bdev; 832 device->bdev = bdev;
837 device->in_fs_metadata = 0; 833 device->in_fs_metadata = 0;
@@ -1835,8 +1831,7 @@ void btrfs_rm_dev_replace_srcdev(struct btrfs_fs_info *fs_info,
1835 if (!fs_devices->seeding) 1831 if (!fs_devices->seeding)
1836 fs_devices->rw_devices++; 1832 fs_devices->rw_devices++;
1837 } 1833 }
1838 if (srcdev->can_discard) 1834
1839 fs_devices->num_can_discard--;
1840 if (srcdev->bdev) { 1835 if (srcdev->bdev) {
1841 fs_devices->open_devices--; 1836 fs_devices->open_devices--;
1842 1837
@@ -1886,8 +1881,6 @@ void btrfs_destroy_dev_replace_tgtdev(struct btrfs_fs_info *fs_info,
1886 fs_info->fs_devices->open_devices--; 1881 fs_info->fs_devices->open_devices--;
1887 } 1882 }
1888 fs_info->fs_devices->num_devices--; 1883 fs_info->fs_devices->num_devices--;
1889 if (tgtdev->can_discard)
1890 fs_info->fs_devices->num_can_discard++;
1891 1884
1892 next_device = list_entry(fs_info->fs_devices->devices.next, 1885 next_device = list_entry(fs_info->fs_devices->devices.next,
1893 struct btrfs_device, dev_list); 1886 struct btrfs_device, dev_list);
@@ -2008,7 +2001,6 @@ static int btrfs_prepare_sprout(struct btrfs_root *root)
2008 fs_devices->num_devices = 0; 2001 fs_devices->num_devices = 0;
2009 fs_devices->open_devices = 0; 2002 fs_devices->open_devices = 0;
2010 fs_devices->missing_devices = 0; 2003 fs_devices->missing_devices = 0;
2011 fs_devices->num_can_discard = 0;
2012 fs_devices->rotating = 0; 2004 fs_devices->rotating = 0;
2013 fs_devices->seed = seed_devices; 2005 fs_devices->seed = seed_devices;
2014 2006
@@ -2200,8 +2192,6 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
2200 root->fs_info->fs_devices->open_devices++; 2192 root->fs_info->fs_devices->open_devices++;
2201 root->fs_info->fs_devices->rw_devices++; 2193 root->fs_info->fs_devices->rw_devices++;
2202 root->fs_info->fs_devices->total_devices++; 2194 root->fs_info->fs_devices->total_devices++;
2203 if (device->can_discard)
2204 root->fs_info->fs_devices->num_can_discard++;
2205 root->fs_info->fs_devices->total_rw_bytes += device->total_bytes; 2195 root->fs_info->fs_devices->total_rw_bytes += device->total_bytes;
2206 2196
2207 spin_lock(&root->fs_info->free_chunk_lock); 2197 spin_lock(&root->fs_info->free_chunk_lock);
@@ -2371,8 +2361,6 @@ int btrfs_init_dev_replace_tgtdev(struct btrfs_root *root, char *device_path,
2371 list_add(&device->dev_list, &fs_info->fs_devices->devices); 2361 list_add(&device->dev_list, &fs_info->fs_devices->devices);
2372 fs_info->fs_devices->num_devices++; 2362 fs_info->fs_devices->num_devices++;
2373 fs_info->fs_devices->open_devices++; 2363 fs_info->fs_devices->open_devices++;
2374 if (device->can_discard)
2375 fs_info->fs_devices->num_can_discard++;
2376 mutex_unlock(&root->fs_info->fs_devices->device_list_mutex); 2364 mutex_unlock(&root->fs_info->fs_devices->device_list_mutex);
2377 2365
2378 *device_out = device; 2366 *device_out = device;
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index e894ac696889..37f8bff97df1 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -124,7 +124,6 @@ struct btrfs_fs_devices {
124 u64 rw_devices; 124 u64 rw_devices;
125 u64 missing_devices; 125 u64 missing_devices;
126 u64 total_rw_bytes; 126 u64 total_rw_bytes;
127 u64 num_can_discard;
128 u64 total_devices; 127 u64 total_devices;
129 struct block_device *latest_bdev; 128 struct block_device *latest_bdev;
130 129