diff options
author | Michal Hocko <mhocko@suse.cz> | 2011-06-15 18:08:11 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-06-15 23:03:59 -0400 |
commit | 7f81c8890c15a10f5220bebae3b6dfae4961962a (patch) | |
tree | 264cb58ffbadb340ce713420a44c00d59fda4e7a /fs | |
parent | b0825ee3a8c570df4873ee397fa453e67fdad5d7 (diff) |
fs/exec.c: use BUILD_BUG_ON for VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP
Commit a8bef8ff6ea1 ("mm: migration: avoid race between shift_arg_pages()
and rmap_walk() during migration by not migrating temporary stacks")
introduced a BUG_ON() to ensure that VM_STACK_FLAGS and
VM_STACK_INCOMPLETE_SETUP do not overlap. The check is a compile time
one, so BUILD_BUG_ON is more appropriate.
Signed-off-by: Michal Hocko <mhocko@suse.cz>
Cc: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/exec.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -277,7 +277,7 @@ static int __bprm_mm_init(struct linux_binprm *bprm) | |||
277 | * use STACK_TOP because that can depend on attributes which aren't | 277 | * use STACK_TOP because that can depend on attributes which aren't |
278 | * configured yet. | 278 | * configured yet. |
279 | */ | 279 | */ |
280 | BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP); | 280 | BUILD_BUG_ON(VM_STACK_FLAGS & VM_STACK_INCOMPLETE_SETUP); |
281 | vma->vm_end = STACK_TOP_MAX; | 281 | vma->vm_end = STACK_TOP_MAX; |
282 | vma->vm_start = vma->vm_end - PAGE_SIZE; | 282 | vma->vm_start = vma->vm_end - PAGE_SIZE; |
283 | vma->vm_flags = VM_STACK_FLAGS | VM_STACK_INCOMPLETE_SETUP; | 283 | vma->vm_flags = VM_STACK_FLAGS | VM_STACK_INCOMPLETE_SETUP; |