diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-09 19:42:10 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-09 19:42:10 -0400 |
commit | 70eba4226d9718946941c7be0c8cb66d431e7686 (patch) | |
tree | 822ba5d9751731d954895e69cf1456cb803ff944 /fs | |
parent | 2d4fe27850420606155fb1f7d18ab2b40153e67b (diff) | |
parent | 47110b88912a997f25d42373e339804d51da98de (diff) |
Merge tag 'please-pull-pstore' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux
Pull trivial pstore update from Tony Luck:
"Couple of pstore cleanups"
It turns out that the kmemdup() conversion ends up being undone by the
fact that the memory block also needed the ecc information (see commit
bd08ec33b5c2: "pstore/ram: Restore ecc information block"), so all that
remains after merging is the error return code change.
* tag 'please-pull-pstore' of git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux:
pstore/ram: fix error return code in ramoops_probe()
fs: pstore: Replaced calls to kmalloc and memcpy with kmemdup
Diffstat (limited to 'fs')
-rw-r--r-- | fs/pstore/ram.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 32cbd7c8a90c..1376e5a8f0d6 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c | |||
@@ -438,6 +438,7 @@ static int ramoops_probe(struct platform_device *pdev) | |||
438 | pr_err("memory size too small, minimum is %zu\n", | 438 | pr_err("memory size too small, minimum is %zu\n", |
439 | cxt->console_size + cxt->record_size + | 439 | cxt->console_size + cxt->record_size + |
440 | cxt->ftrace_size); | 440 | cxt->ftrace_size); |
441 | err = -EINVAL; | ||
441 | goto fail_cnt; | 442 | goto fail_cnt; |
442 | } | 443 | } |
443 | 444 | ||
@@ -455,6 +456,7 @@ static int ramoops_probe(struct platform_device *pdev) | |||
455 | spin_lock_init(&cxt->pstore.buf_lock); | 456 | spin_lock_init(&cxt->pstore.buf_lock); |
456 | if (!cxt->pstore.buf) { | 457 | if (!cxt->pstore.buf) { |
457 | pr_err("cannot allocate pstore buffer\n"); | 458 | pr_err("cannot allocate pstore buffer\n"); |
459 | err = -ENOMEM; | ||
458 | goto fail_clear; | 460 | goto fail_clear; |
459 | } | 461 | } |
460 | 462 | ||