diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2014-01-15 20:23:34 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-01-15 20:23:34 -0500 |
commit | 70b23ce347c025a06339abd995b1df4a9fe096ba (patch) | |
tree | 4e1c929cf0f8e86a033980968dddff5e800c3fda /fs | |
parent | a9bdddb8dd711d70c5e0068fd8ad5ae5f4419359 (diff) | |
parent | f9b0e058cbd04ada76b13afffa7e1df830543c24 (diff) |
Merge tag 'writeback-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux
Pull writeback fix from Wu Fengguang:
"Fix data corruption on NFS writeback.
It has been in linux-next for one month"
* tag 'writeback-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/wfg/linux:
writeback: Fix data corruption on NFS
Diffstat (limited to 'fs')
-rw-r--r-- | fs/fs-writeback.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 1f4a10ece2f1..e0259a163f98 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
@@ -516,13 +516,16 @@ writeback_single_inode(struct inode *inode, struct bdi_writeback *wb, | |||
516 | } | 516 | } |
517 | WARN_ON(inode->i_state & I_SYNC); | 517 | WARN_ON(inode->i_state & I_SYNC); |
518 | /* | 518 | /* |
519 | * Skip inode if it is clean. We don't want to mess with writeback | 519 | * Skip inode if it is clean and we have no outstanding writeback in |
520 | * lists in this function since flusher thread may be doing for example | 520 | * WB_SYNC_ALL mode. We don't want to mess with writeback lists in this |
521 | * sync in parallel and if we move the inode, it could get skipped. So | 521 | * function since flusher thread may be doing for example sync in |
522 | * here we make sure inode is on some writeback list and leave it there | 522 | * parallel and if we move the inode, it could get skipped. So here we |
523 | * unless we have completely cleaned the inode. | 523 | * make sure inode is on some writeback list and leave it there unless |
524 | * we have completely cleaned the inode. | ||
524 | */ | 525 | */ |
525 | if (!(inode->i_state & I_DIRTY)) | 526 | if (!(inode->i_state & I_DIRTY) && |
527 | (wbc->sync_mode != WB_SYNC_ALL || | ||
528 | !mapping_tagged(inode->i_mapping, PAGECACHE_TAG_WRITEBACK))) | ||
526 | goto out; | 529 | goto out; |
527 | inode->i_state |= I_SYNC; | 530 | inode->i_state |= I_SYNC; |
528 | spin_unlock(&inode->i_lock); | 531 | spin_unlock(&inode->i_lock); |