diff options
| author | Josef Bacik <jbacik@fusionio.com> | 2013-04-17 12:16:59 -0400 |
|---|---|---|
| committer | Josef Bacik <jbacik@fusionio.com> | 2013-05-06 15:55:00 -0400 |
| commit | 62dbd7176e196cd042c5542696981b268264fe92 (patch) | |
| tree | 90992e6775549b70fa3aa106a40c25d964dc78c2 /fs | |
| parent | 534e6623b7bc03ddcf6c98b9398ff512d5135fe5 (diff) | |
Btrfs: fix lockdep warning
The locking order for stuff is
__sb_start_write
ordered_mutex
but with sync() we don't do __sb_start_write for some strange reason, which
means that our iput in wait_ordered_extents could start a transaction which does
the __sb_start_write while we're holding the ordered_mutex. Fix this by using
delayed iput in sync. Thanks,
Reported-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/super.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 5dc54ae5ac81..a4807ced23cc 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c | |||
| @@ -866,7 +866,7 @@ int btrfs_sync_fs(struct super_block *sb, int wait) | |||
| 866 | return 0; | 866 | return 0; |
| 867 | } | 867 | } |
| 868 | 868 | ||
| 869 | btrfs_wait_ordered_extents(root, 0); | 869 | btrfs_wait_ordered_extents(root, 1); |
| 870 | 870 | ||
| 871 | trans = btrfs_attach_transaction_barrier(root); | 871 | trans = btrfs_attach_transaction_barrier(root); |
| 872 | if (IS_ERR(trans)) { | 872 | if (IS_ERR(trans)) { |