diff options
author | Tyler Hicks <tyhicks@linux.vnet.ibm.com> | 2008-10-16 01:02:51 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-10-16 14:21:39 -0400 |
commit | 624ae5284516870657505103ada531c64dba2a9a (patch) | |
tree | 1098d75abc1f4d335e2276dd9dde00a60ee568b5 /fs | |
parent | 807b7ebe41ab80d96e89a53bc290d49613e56f48 (diff) |
eCryptfs: remove netlink transport
The netlink transport code has not worked for a while and the miscdev
transport is a simpler solution. This patch removes the netlink code and
makes the miscdev transport the only eCryptfs kernel to userspace
transport.
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
Cc: Michael Halcrow <mhalcrow@us.ibm.com>
Cc: Dustin Kirkland <kirkland@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/ecryptfs/Makefile | 2 | ||||
-rw-r--r-- | fs/ecryptfs/ecryptfs_kernel.h | 28 | ||||
-rw-r--r-- | fs/ecryptfs/keystore.c | 32 | ||||
-rw-r--r-- | fs/ecryptfs/main.c | 19 | ||||
-rw-r--r-- | fs/ecryptfs/messaging.c | 118 | ||||
-rw-r--r-- | fs/ecryptfs/netlink.c | 249 |
6 files changed, 60 insertions, 388 deletions
diff --git a/fs/ecryptfs/Makefile b/fs/ecryptfs/Makefile index b4755a85996e..2cc9ee4ad2eb 100644 --- a/fs/ecryptfs/Makefile +++ b/fs/ecryptfs/Makefile | |||
@@ -4,4 +4,4 @@ | |||
4 | 4 | ||
5 | obj-$(CONFIG_ECRYPT_FS) += ecryptfs.o | 5 | obj-$(CONFIG_ECRYPT_FS) += ecryptfs.o |
6 | 6 | ||
7 | ecryptfs-objs := dentry.o file.o inode.o main.o super.o mmap.o read_write.o crypto.o keystore.o messaging.o netlink.o miscdev.o kthread.o debug.o | 7 | ecryptfs-objs := dentry.o file.o inode.o main.o super.o mmap.o read_write.o crypto.o keystore.o messaging.o miscdev.o kthread.o debug.o |
diff --git a/fs/ecryptfs/ecryptfs_kernel.h b/fs/ecryptfs/ecryptfs_kernel.h index b73fb752c5f8..3504cf9df358 100644 --- a/fs/ecryptfs/ecryptfs_kernel.h +++ b/fs/ecryptfs/ecryptfs_kernel.h | |||
@@ -79,11 +79,6 @@ | |||
79 | #define ECRYPTFS_MAX_PKI_NAME_BYTES 16 | 79 | #define ECRYPTFS_MAX_PKI_NAME_BYTES 16 |
80 | #define ECRYPTFS_DEFAULT_NUM_USERS 4 | 80 | #define ECRYPTFS_DEFAULT_NUM_USERS 4 |
81 | #define ECRYPTFS_MAX_NUM_USERS 32768 | 81 | #define ECRYPTFS_MAX_NUM_USERS 32768 |
82 | #define ECRYPTFS_TRANSPORT_NETLINK 0 | ||
83 | #define ECRYPTFS_TRANSPORT_CONNECTOR 1 | ||
84 | #define ECRYPTFS_TRANSPORT_RELAYFS 2 | ||
85 | #define ECRYPTFS_TRANSPORT_MISCDEV 3 | ||
86 | #define ECRYPTFS_DEFAULT_TRANSPORT ECRYPTFS_TRANSPORT_MISCDEV | ||
87 | #define ECRYPTFS_XATTR_NAME "user.ecryptfs" | 82 | #define ECRYPTFS_XATTR_NAME "user.ecryptfs" |
88 | 83 | ||
89 | #define RFC2440_CIPHER_DES3_EDE 0x02 | 84 | #define RFC2440_CIPHER_DES3_EDE 0x02 |
@@ -400,8 +395,6 @@ struct ecryptfs_msg_ctx { | |||
400 | struct mutex mux; | 395 | struct mutex mux; |
401 | }; | 396 | }; |
402 | 397 | ||
403 | extern unsigned int ecryptfs_transport; | ||
404 | |||
405 | struct ecryptfs_daemon; | 398 | struct ecryptfs_daemon; |
406 | 399 | ||
407 | struct ecryptfs_daemon { | 400 | struct ecryptfs_daemon { |
@@ -627,31 +620,20 @@ int | |||
627 | ecryptfs_setxattr(struct dentry *dentry, const char *name, const void *value, | 620 | ecryptfs_setxattr(struct dentry *dentry, const char *name, const void *value, |
628 | size_t size, int flags); | 621 | size_t size, int flags); |
629 | int ecryptfs_read_xattr_region(char *page_virt, struct inode *ecryptfs_inode); | 622 | int ecryptfs_read_xattr_region(char *page_virt, struct inode *ecryptfs_inode); |
630 | int ecryptfs_process_helo(unsigned int transport, uid_t euid, | 623 | int ecryptfs_process_helo(uid_t euid, struct user_namespace *user_ns, |
631 | struct user_namespace *user_ns, struct pid *pid); | 624 | struct pid *pid); |
632 | int ecryptfs_process_quit(uid_t euid, struct user_namespace *user_ns, | 625 | int ecryptfs_process_quit(uid_t euid, struct user_namespace *user_ns, |
633 | struct pid *pid); | 626 | struct pid *pid); |
634 | int ecryptfs_process_response(struct ecryptfs_message *msg, uid_t euid, | 627 | int ecryptfs_process_response(struct ecryptfs_message *msg, uid_t euid, |
635 | struct user_namespace *user_ns, struct pid *pid, | 628 | struct user_namespace *user_ns, struct pid *pid, |
636 | u32 seq); | 629 | u32 seq); |
637 | int ecryptfs_send_message(unsigned int transport, char *data, int data_len, | 630 | int ecryptfs_send_message(char *data, int data_len, |
638 | struct ecryptfs_msg_ctx **msg_ctx); | 631 | struct ecryptfs_msg_ctx **msg_ctx); |
639 | int ecryptfs_wait_for_response(struct ecryptfs_msg_ctx *msg_ctx, | 632 | int ecryptfs_wait_for_response(struct ecryptfs_msg_ctx *msg_ctx, |
640 | struct ecryptfs_message **emsg); | 633 | struct ecryptfs_message **emsg); |
641 | int ecryptfs_init_messaging(unsigned int transport); | 634 | int ecryptfs_init_messaging(void); |
642 | void ecryptfs_release_messaging(unsigned int transport); | 635 | void ecryptfs_release_messaging(void); |
643 | 636 | ||
644 | int ecryptfs_send_netlink(char *data, int data_len, | ||
645 | struct ecryptfs_msg_ctx *msg_ctx, u8 msg_type, | ||
646 | u16 msg_flags, struct pid *daemon_pid); | ||
647 | int ecryptfs_init_netlink(void); | ||
648 | void ecryptfs_release_netlink(void); | ||
649 | |||
650 | int ecryptfs_send_connector(char *data, int data_len, | ||
651 | struct ecryptfs_msg_ctx *msg_ctx, u8 msg_type, | ||
652 | u16 msg_flags, struct pid *daemon_pid); | ||
653 | int ecryptfs_init_connector(void); | ||
654 | void ecryptfs_release_connector(void); | ||
655 | void | 637 | void |
656 | ecryptfs_write_header_metadata(char *virt, | 638 | ecryptfs_write_header_metadata(char *virt, |
657 | struct ecryptfs_crypt_stat *crypt_stat, | 639 | struct ecryptfs_crypt_stat *crypt_stat, |
diff --git a/fs/ecryptfs/keystore.c b/fs/ecryptfs/keystore.c index f5b76a331b9c..e22bc3961345 100644 --- a/fs/ecryptfs/keystore.c +++ b/fs/ecryptfs/keystore.c | |||
@@ -234,8 +234,8 @@ parse_tag_65_packet(struct ecryptfs_session_key *session_key, u8 *cipher_code, | |||
234 | } | 234 | } |
235 | i += data_len; | 235 | i += data_len; |
236 | if (message_len < (i + m_size)) { | 236 | if (message_len < (i + m_size)) { |
237 | ecryptfs_printk(KERN_ERR, "The received netlink message is " | 237 | ecryptfs_printk(KERN_ERR, "The message received from ecryptfsd " |
238 | "shorter than expected\n"); | 238 | "is shorter than expected\n"); |
239 | rc = -EIO; | 239 | rc = -EIO; |
240 | goto out; | 240 | goto out; |
241 | } | 241 | } |
@@ -438,8 +438,8 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok, | |||
438 | struct ecryptfs_msg_ctx *msg_ctx; | 438 | struct ecryptfs_msg_ctx *msg_ctx; |
439 | struct ecryptfs_message *msg = NULL; | 439 | struct ecryptfs_message *msg = NULL; |
440 | char *auth_tok_sig; | 440 | char *auth_tok_sig; |
441 | char *netlink_message; | 441 | char *payload; |
442 | size_t netlink_message_length; | 442 | size_t payload_len; |
443 | int rc; | 443 | int rc; |
444 | 444 | ||
445 | rc = ecryptfs_get_auth_tok_sig(&auth_tok_sig, auth_tok); | 445 | rc = ecryptfs_get_auth_tok_sig(&auth_tok_sig, auth_tok); |
@@ -449,15 +449,15 @@ decrypt_pki_encrypted_session_key(struct ecryptfs_auth_tok *auth_tok, | |||
449 | goto out; | 449 | goto out; |
450 | } | 450 | } |
451 | rc = write_tag_64_packet(auth_tok_sig, &(auth_tok->session_key), | 451 | rc = write_tag_64_packet(auth_tok_sig, &(auth_tok->session_key), |
452 | &netlink_message, &netlink_message_length); | 452 | &payload, &payload_len); |
453 | if (rc) { | 453 | if (rc) { |
454 | ecryptfs_printk(KERN_ERR, "Failed to write tag 64 packet\n"); | 454 | ecryptfs_printk(KERN_ERR, "Failed to write tag 64 packet\n"); |
455 | goto out; | 455 | goto out; |
456 | } | 456 | } |
457 | rc = ecryptfs_send_message(ecryptfs_transport, netlink_message, | 457 | rc = ecryptfs_send_message(payload, payload_len, &msg_ctx); |
458 | netlink_message_length, &msg_ctx); | ||
459 | if (rc) { | 458 | if (rc) { |
460 | ecryptfs_printk(KERN_ERR, "Error sending netlink message\n"); | 459 | ecryptfs_printk(KERN_ERR, "Error sending message to " |
460 | "ecryptfsd\n"); | ||
461 | goto out; | 461 | goto out; |
462 | } | 462 | } |
463 | rc = ecryptfs_wait_for_response(msg_ctx, &msg); | 463 | rc = ecryptfs_wait_for_response(msg_ctx, &msg); |
@@ -1333,23 +1333,22 @@ pki_encrypt_session_key(struct ecryptfs_auth_tok *auth_tok, | |||
1333 | struct ecryptfs_key_record *key_rec) | 1333 | struct ecryptfs_key_record *key_rec) |
1334 | { | 1334 | { |
1335 | struct ecryptfs_msg_ctx *msg_ctx = NULL; | 1335 | struct ecryptfs_msg_ctx *msg_ctx = NULL; |
1336 | char *netlink_payload; | 1336 | char *payload = NULL; |
1337 | size_t netlink_payload_length; | 1337 | size_t payload_len; |
1338 | struct ecryptfs_message *msg; | 1338 | struct ecryptfs_message *msg; |
1339 | int rc; | 1339 | int rc; |
1340 | 1340 | ||
1341 | rc = write_tag_66_packet(auth_tok->token.private_key.signature, | 1341 | rc = write_tag_66_packet(auth_tok->token.private_key.signature, |
1342 | ecryptfs_code_for_cipher_string(crypt_stat), | 1342 | ecryptfs_code_for_cipher_string(crypt_stat), |
1343 | crypt_stat, &netlink_payload, | 1343 | crypt_stat, &payload, &payload_len); |
1344 | &netlink_payload_length); | ||
1345 | if (rc) { | 1344 | if (rc) { |
1346 | ecryptfs_printk(KERN_ERR, "Error generating tag 66 packet\n"); | 1345 | ecryptfs_printk(KERN_ERR, "Error generating tag 66 packet\n"); |
1347 | goto out; | 1346 | goto out; |
1348 | } | 1347 | } |
1349 | rc = ecryptfs_send_message(ecryptfs_transport, netlink_payload, | 1348 | rc = ecryptfs_send_message(payload, payload_len, &msg_ctx); |
1350 | netlink_payload_length, &msg_ctx); | ||
1351 | if (rc) { | 1349 | if (rc) { |
1352 | ecryptfs_printk(KERN_ERR, "Error sending netlink message\n"); | 1350 | ecryptfs_printk(KERN_ERR, "Error sending message to " |
1351 | "ecryptfsd\n"); | ||
1353 | goto out; | 1352 | goto out; |
1354 | } | 1353 | } |
1355 | rc = ecryptfs_wait_for_response(msg_ctx, &msg); | 1354 | rc = ecryptfs_wait_for_response(msg_ctx, &msg); |
@@ -1364,8 +1363,7 @@ pki_encrypt_session_key(struct ecryptfs_auth_tok *auth_tok, | |||
1364 | ecryptfs_printk(KERN_ERR, "Error parsing tag 67 packet\n"); | 1363 | ecryptfs_printk(KERN_ERR, "Error parsing tag 67 packet\n"); |
1365 | kfree(msg); | 1364 | kfree(msg); |
1366 | out: | 1365 | out: |
1367 | if (netlink_payload) | 1366 | kfree(payload); |
1368 | kfree(netlink_payload); | ||
1369 | return rc; | 1367 | return rc; |
1370 | } | 1368 | } |
1371 | /** | 1369 | /** |
diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c index 8ebe9a5d1d99..046e027a4cb1 100644 --- a/fs/ecryptfs/main.c +++ b/fs/ecryptfs/main.c | |||
@@ -30,7 +30,6 @@ | |||
30 | #include <linux/namei.h> | 30 | #include <linux/namei.h> |
31 | #include <linux/skbuff.h> | 31 | #include <linux/skbuff.h> |
32 | #include <linux/crypto.h> | 32 | #include <linux/crypto.h> |
33 | #include <linux/netlink.h> | ||
34 | #include <linux/mount.h> | 33 | #include <linux/mount.h> |
35 | #include <linux/pagemap.h> | 34 | #include <linux/pagemap.h> |
36 | #include <linux/key.h> | 35 | #include <linux/key.h> |
@@ -49,8 +48,7 @@ MODULE_PARM_DESC(ecryptfs_verbosity, | |||
49 | "0, which is Quiet)"); | 48 | "0, which is Quiet)"); |
50 | 49 | ||
51 | /** | 50 | /** |
52 | * Module parameter that defines the number of netlink message buffer | 51 | * Module parameter that defines the number of message buffer elements |
53 | * elements | ||
54 | */ | 52 | */ |
55 | unsigned int ecryptfs_message_buf_len = ECRYPTFS_DEFAULT_MSG_CTX_ELEMS; | 53 | unsigned int ecryptfs_message_buf_len = ECRYPTFS_DEFAULT_MSG_CTX_ELEMS; |
56 | 54 | ||
@@ -60,9 +58,9 @@ MODULE_PARM_DESC(ecryptfs_message_buf_len, | |||
60 | 58 | ||
61 | /** | 59 | /** |
62 | * Module parameter that defines the maximum guaranteed amount of time to wait | 60 | * Module parameter that defines the maximum guaranteed amount of time to wait |
63 | * for a response through netlink. The actual sleep time will be, more than | 61 | * for a response from ecryptfsd. The actual sleep time will be, more than |
64 | * likely, a small amount greater than this specified value, but only less if | 62 | * likely, a small amount greater than this specified value, but only less if |
65 | * the netlink message successfully arrives. | 63 | * the message successfully arrives. |
66 | */ | 64 | */ |
67 | signed long ecryptfs_message_wait_timeout = ECRYPTFS_MAX_MSG_CTX_TTL / HZ; | 65 | signed long ecryptfs_message_wait_timeout = ECRYPTFS_MAX_MSG_CTX_TTL / HZ; |
68 | 66 | ||
@@ -83,8 +81,6 @@ module_param(ecryptfs_number_of_users, uint, 0); | |||
83 | MODULE_PARM_DESC(ecryptfs_number_of_users, "An estimate of the number of " | 81 | MODULE_PARM_DESC(ecryptfs_number_of_users, "An estimate of the number of " |
84 | "concurrent users of eCryptfs"); | 82 | "concurrent users of eCryptfs"); |
85 | 83 | ||
86 | unsigned int ecryptfs_transport = ECRYPTFS_DEFAULT_TRANSPORT; | ||
87 | |||
88 | void __ecryptfs_printk(const char *fmt, ...) | 84 | void __ecryptfs_printk(const char *fmt, ...) |
89 | { | 85 | { |
90 | va_list args; | 86 | va_list args; |
@@ -779,10 +775,11 @@ static int __init ecryptfs_init(void) | |||
779 | "rc = [%d]\n", __func__, rc); | 775 | "rc = [%d]\n", __func__, rc); |
780 | goto out_do_sysfs_unregistration; | 776 | goto out_do_sysfs_unregistration; |
781 | } | 777 | } |
782 | rc = ecryptfs_init_messaging(ecryptfs_transport); | 778 | rc = ecryptfs_init_messaging(); |
783 | if (rc) { | 779 | if (rc) { |
784 | printk(KERN_ERR "Failure occured while attempting to " | 780 | printk(KERN_ERR "Failure occured while attempting to " |
785 | "initialize the eCryptfs netlink socket\n"); | 781 | "initialize the communications channel to " |
782 | "ecryptfsd\n"); | ||
786 | goto out_destroy_kthread; | 783 | goto out_destroy_kthread; |
787 | } | 784 | } |
788 | rc = ecryptfs_init_crypto(); | 785 | rc = ecryptfs_init_crypto(); |
@@ -797,7 +794,7 @@ static int __init ecryptfs_init(void) | |||
797 | 794 | ||
798 | goto out; | 795 | goto out; |
799 | out_release_messaging: | 796 | out_release_messaging: |
800 | ecryptfs_release_messaging(ecryptfs_transport); | 797 | ecryptfs_release_messaging(); |
801 | out_destroy_kthread: | 798 | out_destroy_kthread: |
802 | ecryptfs_destroy_kthread(); | 799 | ecryptfs_destroy_kthread(); |
803 | out_do_sysfs_unregistration: | 800 | out_do_sysfs_unregistration: |
@@ -818,7 +815,7 @@ static void __exit ecryptfs_exit(void) | |||
818 | if (rc) | 815 | if (rc) |
819 | printk(KERN_ERR "Failure whilst attempting to destroy crypto; " | 816 | printk(KERN_ERR "Failure whilst attempting to destroy crypto; " |
820 | "rc = [%d]\n", rc); | 817 | "rc = [%d]\n", rc); |
821 | ecryptfs_release_messaging(ecryptfs_transport); | 818 | ecryptfs_release_messaging(); |
822 | ecryptfs_destroy_kthread(); | 819 | ecryptfs_destroy_kthread(); |
823 | do_sysfs_unregistration(); | 820 | do_sysfs_unregistration(); |
824 | unregister_filesystem(&ecryptfs_fs_type); | 821 | unregister_filesystem(&ecryptfs_fs_type); |
diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c index 1b5c20058acb..c6983978a31e 100644 --- a/fs/ecryptfs/messaging.c +++ b/fs/ecryptfs/messaging.c | |||
@@ -134,12 +134,11 @@ out: | |||
134 | } | 134 | } |
135 | 135 | ||
136 | static int | 136 | static int |
137 | ecryptfs_send_message_locked(unsigned int transport, char *data, int data_len, | 137 | ecryptfs_send_message_locked(char *data, int data_len, u8 msg_type, |
138 | u8 msg_type, struct ecryptfs_msg_ctx **msg_ctx); | 138 | struct ecryptfs_msg_ctx **msg_ctx); |
139 | 139 | ||
140 | /** | 140 | /** |
141 | * ecryptfs_send_raw_message | 141 | * ecryptfs_send_raw_message |
142 | * @transport: Transport type | ||
143 | * @msg_type: Message type | 142 | * @msg_type: Message type |
144 | * @daemon: Daemon struct for recipient of message | 143 | * @daemon: Daemon struct for recipient of message |
145 | * | 144 | * |
@@ -150,38 +149,25 @@ ecryptfs_send_message_locked(unsigned int transport, char *data, int data_len, | |||
150 | * | 149 | * |
151 | * Returns zero on success; non-zero otherwise | 150 | * Returns zero on success; non-zero otherwise |
152 | */ | 151 | */ |
153 | static int ecryptfs_send_raw_message(unsigned int transport, u8 msg_type, | 152 | static int ecryptfs_send_raw_message(u8 msg_type, |
154 | struct ecryptfs_daemon *daemon) | 153 | struct ecryptfs_daemon *daemon) |
155 | { | 154 | { |
156 | struct ecryptfs_msg_ctx *msg_ctx; | 155 | struct ecryptfs_msg_ctx *msg_ctx; |
157 | int rc; | 156 | int rc; |
158 | 157 | ||
159 | switch(transport) { | 158 | rc = ecryptfs_send_message_locked(NULL, 0, msg_type, &msg_ctx); |
160 | case ECRYPTFS_TRANSPORT_NETLINK: | 159 | if (rc) { |
161 | rc = ecryptfs_send_netlink(NULL, 0, NULL, msg_type, 0, | 160 | printk(KERN_ERR "%s: Error whilst attempting to send " |
162 | daemon->pid); | 161 | "message to ecryptfsd; rc = [%d]\n", __func__, rc); |
163 | break; | 162 | goto out; |
164 | case ECRYPTFS_TRANSPORT_MISCDEV: | ||
165 | rc = ecryptfs_send_message_locked(transport, NULL, 0, msg_type, | ||
166 | &msg_ctx); | ||
167 | if (rc) { | ||
168 | printk(KERN_ERR "%s: Error whilst attempting to send " | ||
169 | "message via procfs; rc = [%d]\n", __func__, rc); | ||
170 | goto out; | ||
171 | } | ||
172 | /* Raw messages are logically context-free (e.g., no | ||
173 | * reply is expected), so we set the state of the | ||
174 | * ecryptfs_msg_ctx object to indicate that it should | ||
175 | * be freed as soon as the transport sends out the message. */ | ||
176 | mutex_lock(&msg_ctx->mux); | ||
177 | msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_NO_REPLY; | ||
178 | mutex_unlock(&msg_ctx->mux); | ||
179 | break; | ||
180 | case ECRYPTFS_TRANSPORT_CONNECTOR: | ||
181 | case ECRYPTFS_TRANSPORT_RELAYFS: | ||
182 | default: | ||
183 | rc = -ENOSYS; | ||
184 | } | 163 | } |
164 | /* Raw messages are logically context-free (e.g., no | ||
165 | * reply is expected), so we set the state of the | ||
166 | * ecryptfs_msg_ctx object to indicate that it should | ||
167 | * be freed as soon as the message is sent. */ | ||
168 | mutex_lock(&msg_ctx->mux); | ||
169 | msg_ctx->state = ECRYPTFS_MSG_CTX_STATE_NO_REPLY; | ||
170 | mutex_unlock(&msg_ctx->mux); | ||
185 | out: | 171 | out: |
186 | return rc; | 172 | return rc; |
187 | } | 173 | } |
@@ -227,7 +213,6 @@ out: | |||
227 | 213 | ||
228 | /** | 214 | /** |
229 | * ecryptfs_process_helo | 215 | * ecryptfs_process_helo |
230 | * @transport: The underlying transport (netlink, etc.) | ||
231 | * @euid: The user ID owner of the message | 216 | * @euid: The user ID owner of the message |
232 | * @user_ns: The namespace in which @euid applies | 217 | * @user_ns: The namespace in which @euid applies |
233 | * @pid: The process ID for the userspace program that sent the | 218 | * @pid: The process ID for the userspace program that sent the |
@@ -239,8 +224,8 @@ out: | |||
239 | * Returns zero after adding a new daemon to the hash list; | 224 | * Returns zero after adding a new daemon to the hash list; |
240 | * non-zero otherwise. | 225 | * non-zero otherwise. |
241 | */ | 226 | */ |
242 | int ecryptfs_process_helo(unsigned int transport, uid_t euid, | 227 | int ecryptfs_process_helo(uid_t euid, struct user_namespace *user_ns, |
243 | struct user_namespace *user_ns, struct pid *pid) | 228 | struct pid *pid) |
244 | { | 229 | { |
245 | struct ecryptfs_daemon *new_daemon; | 230 | struct ecryptfs_daemon *new_daemon; |
246 | struct ecryptfs_daemon *old_daemon; | 231 | struct ecryptfs_daemon *old_daemon; |
@@ -252,8 +237,7 @@ int ecryptfs_process_helo(unsigned int transport, uid_t euid, | |||
252 | printk(KERN_WARNING "Received request from user [%d] " | 237 | printk(KERN_WARNING "Received request from user [%d] " |
253 | "to register daemon [0x%p]; unregistering daemon " | 238 | "to register daemon [0x%p]; unregistering daemon " |
254 | "[0x%p]\n", euid, pid, old_daemon->pid); | 239 | "[0x%p]\n", euid, pid, old_daemon->pid); |
255 | rc = ecryptfs_send_raw_message(transport, ECRYPTFS_MSG_QUIT, | 240 | rc = ecryptfs_send_raw_message(ECRYPTFS_MSG_QUIT, old_daemon); |
256 | old_daemon); | ||
257 | if (rc) | 241 | if (rc) |
258 | printk(KERN_WARNING "Failed to send QUIT " | 242 | printk(KERN_WARNING "Failed to send QUIT " |
259 | "message to daemon [0x%p]; rc = [%d]\n", | 243 | "message to daemon [0x%p]; rc = [%d]\n", |
@@ -467,8 +451,6 @@ out: | |||
467 | 451 | ||
468 | /** | 452 | /** |
469 | * ecryptfs_send_message_locked | 453 | * ecryptfs_send_message_locked |
470 | * @transport: The transport over which to send the message (i.e., | ||
471 | * netlink) | ||
472 | * @data: The data to send | 454 | * @data: The data to send |
473 | * @data_len: The length of data | 455 | * @data_len: The length of data |
474 | * @msg_ctx: The message context allocated for the send | 456 | * @msg_ctx: The message context allocated for the send |
@@ -478,8 +460,8 @@ out: | |||
478 | * Returns zero on success; non-zero otherwise | 460 | * Returns zero on success; non-zero otherwise |
479 | */ | 461 | */ |
480 | static int | 462 | static int |
481 | ecryptfs_send_message_locked(unsigned int transport, char *data, int data_len, | 463 | ecryptfs_send_message_locked(char *data, int data_len, u8 msg_type, |
482 | u8 msg_type, struct ecryptfs_msg_ctx **msg_ctx) | 464 | struct ecryptfs_msg_ctx **msg_ctx) |
483 | { | 465 | { |
484 | struct ecryptfs_daemon *daemon; | 466 | struct ecryptfs_daemon *daemon; |
485 | int rc; | 467 | int rc; |
@@ -503,20 +485,8 @@ ecryptfs_send_message_locked(unsigned int transport, char *data, int data_len, | |||
503 | ecryptfs_msg_ctx_free_to_alloc(*msg_ctx); | 485 | ecryptfs_msg_ctx_free_to_alloc(*msg_ctx); |
504 | mutex_unlock(&(*msg_ctx)->mux); | 486 | mutex_unlock(&(*msg_ctx)->mux); |
505 | mutex_unlock(&ecryptfs_msg_ctx_lists_mux); | 487 | mutex_unlock(&ecryptfs_msg_ctx_lists_mux); |
506 | switch (transport) { | 488 | rc = ecryptfs_send_miscdev(data, data_len, *msg_ctx, msg_type, 0, |
507 | case ECRYPTFS_TRANSPORT_NETLINK: | 489 | daemon); |
508 | rc = ecryptfs_send_netlink(data, data_len, *msg_ctx, msg_type, | ||
509 | 0, daemon->pid); | ||
510 | break; | ||
511 | case ECRYPTFS_TRANSPORT_MISCDEV: | ||
512 | rc = ecryptfs_send_miscdev(data, data_len, *msg_ctx, msg_type, | ||
513 | 0, daemon); | ||
514 | break; | ||
515 | case ECRYPTFS_TRANSPORT_CONNECTOR: | ||
516 | case ECRYPTFS_TRANSPORT_RELAYFS: | ||
517 | default: | ||
518 | rc = -ENOSYS; | ||
519 | } | ||
520 | if (rc) | 490 | if (rc) |
521 | printk(KERN_ERR "%s: Error attempting to send message to " | 491 | printk(KERN_ERR "%s: Error attempting to send message to " |
522 | "userspace daemon; rc = [%d]\n", __func__, rc); | 492 | "userspace daemon; rc = [%d]\n", __func__, rc); |
@@ -526,8 +496,6 @@ out: | |||
526 | 496 | ||
527 | /** | 497 | /** |
528 | * ecryptfs_send_message | 498 | * ecryptfs_send_message |
529 | * @transport: The transport over which to send the message (i.e., | ||
530 | * netlink) | ||
531 | * @data: The data to send | 499 | * @data: The data to send |
532 | * @data_len: The length of data | 500 | * @data_len: The length of data |
533 | * @msg_ctx: The message context allocated for the send | 501 | * @msg_ctx: The message context allocated for the send |
@@ -536,14 +504,14 @@ out: | |||
536 | * | 504 | * |
537 | * Returns zero on success; non-zero otherwise | 505 | * Returns zero on success; non-zero otherwise |
538 | */ | 506 | */ |
539 | int ecryptfs_send_message(unsigned int transport, char *data, int data_len, | 507 | int ecryptfs_send_message(char *data, int data_len, |
540 | struct ecryptfs_msg_ctx **msg_ctx) | 508 | struct ecryptfs_msg_ctx **msg_ctx) |
541 | { | 509 | { |
542 | int rc; | 510 | int rc; |
543 | 511 | ||
544 | mutex_lock(&ecryptfs_daemon_hash_mux); | 512 | mutex_lock(&ecryptfs_daemon_hash_mux); |
545 | rc = ecryptfs_send_message_locked(transport, data, data_len, | 513 | rc = ecryptfs_send_message_locked(data, data_len, ECRYPTFS_MSG_REQUEST, |
546 | ECRYPTFS_MSG_REQUEST, msg_ctx); | 514 | msg_ctx); |
547 | mutex_unlock(&ecryptfs_daemon_hash_mux); | 515 | mutex_unlock(&ecryptfs_daemon_hash_mux); |
548 | return rc; | 516 | return rc; |
549 | } | 517 | } |
@@ -586,7 +554,7 @@ sleep: | |||
586 | return rc; | 554 | return rc; |
587 | } | 555 | } |
588 | 556 | ||
589 | int ecryptfs_init_messaging(unsigned int transport) | 557 | int ecryptfs_init_messaging(void) |
590 | { | 558 | { |
591 | int i; | 559 | int i; |
592 | int rc = 0; | 560 | int rc = 0; |
@@ -639,27 +607,14 @@ int ecryptfs_init_messaging(unsigned int transport) | |||
639 | mutex_unlock(&ecryptfs_msg_ctx_arr[i].mux); | 607 | mutex_unlock(&ecryptfs_msg_ctx_arr[i].mux); |
640 | } | 608 | } |
641 | mutex_unlock(&ecryptfs_msg_ctx_lists_mux); | 609 | mutex_unlock(&ecryptfs_msg_ctx_lists_mux); |
642 | switch(transport) { | 610 | rc = ecryptfs_init_ecryptfs_miscdev(); |
643 | case ECRYPTFS_TRANSPORT_NETLINK: | 611 | if (rc) |
644 | rc = ecryptfs_init_netlink(); | 612 | ecryptfs_release_messaging(); |
645 | if (rc) | ||
646 | ecryptfs_release_messaging(transport); | ||
647 | break; | ||
648 | case ECRYPTFS_TRANSPORT_MISCDEV: | ||
649 | rc = ecryptfs_init_ecryptfs_miscdev(); | ||
650 | if (rc) | ||
651 | ecryptfs_release_messaging(transport); | ||
652 | break; | ||
653 | case ECRYPTFS_TRANSPORT_CONNECTOR: | ||
654 | case ECRYPTFS_TRANSPORT_RELAYFS: | ||
655 | default: | ||
656 | rc = -ENOSYS; | ||
657 | } | ||
658 | out: | 613 | out: |
659 | return rc; | 614 | return rc; |
660 | } | 615 | } |
661 | 616 | ||
662 | void ecryptfs_release_messaging(unsigned int transport) | 617 | void ecryptfs_release_messaging(void) |
663 | { | 618 | { |
664 | if (ecryptfs_msg_ctx_arr) { | 619 | if (ecryptfs_msg_ctx_arr) { |
665 | int i; | 620 | int i; |
@@ -698,17 +653,6 @@ void ecryptfs_release_messaging(unsigned int transport) | |||
698 | kfree(ecryptfs_daemon_hash); | 653 | kfree(ecryptfs_daemon_hash); |
699 | mutex_unlock(&ecryptfs_daemon_hash_mux); | 654 | mutex_unlock(&ecryptfs_daemon_hash_mux); |
700 | } | 655 | } |
701 | switch(transport) { | 656 | ecryptfs_destroy_ecryptfs_miscdev(); |
702 | case ECRYPTFS_TRANSPORT_NETLINK: | ||
703 | ecryptfs_release_netlink(); | ||
704 | break; | ||
705 | case ECRYPTFS_TRANSPORT_MISCDEV: | ||
706 | ecryptfs_destroy_ecryptfs_miscdev(); | ||
707 | break; | ||
708 | case ECRYPTFS_TRANSPORT_CONNECTOR: | ||
709 | case ECRYPTFS_TRANSPORT_RELAYFS: | ||
710 | default: | ||
711 | break; | ||
712 | } | ||
713 | return; | 657 | return; |
714 | } | 658 | } |
diff --git a/fs/ecryptfs/netlink.c b/fs/ecryptfs/netlink.c deleted file mode 100644 index e0abad62b395..000000000000 --- a/fs/ecryptfs/netlink.c +++ /dev/null | |||
@@ -1,249 +0,0 @@ | |||
1 | /** | ||
2 | * eCryptfs: Linux filesystem encryption layer | ||
3 | * | ||
4 | * Copyright (C) 2004-2006 International Business Machines Corp. | ||
5 | * Author(s): Michael A. Halcrow <mhalcrow@us.ibm.com> | ||
6 | * Tyler Hicks <tyhicks@ou.edu> | ||
7 | * | ||
8 | * This program is free software; you can redistribute it and/or | ||
9 | * modify it under the terms of the GNU General Public License version | ||
10 | * 2 as published by the Free Software Foundation. | ||
11 | * | ||
12 | * This program is distributed in the hope that it will be useful, but | ||
13 | * WITHOUT ANY WARRANTY; without even the implied warranty of | ||
14 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
15 | * General Public License for more details. | ||
16 | * | ||
17 | * You should have received a copy of the GNU General Public License | ||
18 | * along with this program; if not, write to the Free Software | ||
19 | * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA | ||
20 | * 02111-1307, USA. | ||
21 | */ | ||
22 | |||
23 | #include <net/sock.h> | ||
24 | #include <linux/hash.h> | ||
25 | #include <linux/random.h> | ||
26 | #include "ecryptfs_kernel.h" | ||
27 | |||
28 | static struct sock *ecryptfs_nl_sock; | ||
29 | |||
30 | /** | ||
31 | * ecryptfs_send_netlink | ||
32 | * @data: The data to include as the payload | ||
33 | * @data_len: The byte count of the data | ||
34 | * @msg_ctx: The netlink context that will be used to handle the | ||
35 | * response message | ||
36 | * @msg_type: The type of netlink message to send | ||
37 | * @msg_flags: The flags to include in the netlink header | ||
38 | * @daemon_pid: The process id of the daemon to send the message to | ||
39 | * | ||
40 | * Sends the data to the specified daemon pid and uses the netlink | ||
41 | * context element to store the data needed for validation upon | ||
42 | * receiving the response. The data and the netlink context can be | ||
43 | * null if just sending a netlink header is sufficient. Returns zero | ||
44 | * upon sending the message; non-zero upon error. | ||
45 | */ | ||
46 | int ecryptfs_send_netlink(char *data, int data_len, | ||
47 | struct ecryptfs_msg_ctx *msg_ctx, u8 msg_type, | ||
48 | u16 msg_flags, struct pid *daemon_pid) | ||
49 | { | ||
50 | struct sk_buff *skb; | ||
51 | struct nlmsghdr *nlh; | ||
52 | struct ecryptfs_message *msg; | ||
53 | size_t payload_len; | ||
54 | int rc; | ||
55 | |||
56 | payload_len = ((data && data_len) ? (sizeof(*msg) + data_len) : 0); | ||
57 | skb = alloc_skb(NLMSG_SPACE(payload_len), GFP_KERNEL); | ||
58 | if (!skb) { | ||
59 | rc = -ENOMEM; | ||
60 | ecryptfs_printk(KERN_ERR, "Failed to allocate socket buffer\n"); | ||
61 | goto out; | ||
62 | } | ||
63 | nlh = NLMSG_PUT(skb, pid_nr(daemon_pid), msg_ctx ? msg_ctx->counter : 0, | ||
64 | msg_type, payload_len); | ||
65 | nlh->nlmsg_flags = msg_flags; | ||
66 | if (msg_ctx && payload_len) { | ||
67 | msg = (struct ecryptfs_message *)NLMSG_DATA(nlh); | ||
68 | msg->index = msg_ctx->index; | ||
69 | msg->data_len = data_len; | ||
70 | memcpy(msg->data, data, data_len); | ||
71 | } | ||
72 | rc = netlink_unicast(ecryptfs_nl_sock, skb, pid_nr(daemon_pid), 0); | ||
73 | if (rc < 0) { | ||
74 | ecryptfs_printk(KERN_ERR, "Failed to send eCryptfs netlink " | ||
75 | "message; rc = [%d]\n", rc); | ||
76 | goto out; | ||
77 | } | ||
78 | rc = 0; | ||
79 | goto out; | ||
80 | nlmsg_failure: | ||
81 | rc = -EMSGSIZE; | ||
82 | kfree_skb(skb); | ||
83 | out: | ||
84 | return rc; | ||
85 | } | ||
86 | |||
87 | /** | ||
88 | * ecryptfs_process_nl_reponse | ||
89 | * @skb: The socket buffer containing the netlink message of state | ||
90 | * RESPONSE | ||
91 | * | ||
92 | * Processes a response message after sending a operation request to | ||
93 | * userspace. Attempts to assign the msg to a netlink context element | ||
94 | * at the index specified in the msg. The sk_buff and nlmsghdr must | ||
95 | * be validated before this function. Returns zero upon delivery to | ||
96 | * desired context element; non-zero upon delivery failure or error. | ||
97 | */ | ||
98 | static int ecryptfs_process_nl_response(struct sk_buff *skb) | ||
99 | { | ||
100 | struct nlmsghdr *nlh = nlmsg_hdr(skb); | ||
101 | struct ecryptfs_message *msg = NLMSG_DATA(nlh); | ||
102 | struct pid *pid; | ||
103 | int rc; | ||
104 | |||
105 | if (skb->len - NLMSG_HDRLEN - sizeof(*msg) != msg->data_len) { | ||
106 | rc = -EINVAL; | ||
107 | ecryptfs_printk(KERN_ERR, "Received netlink message with " | ||
108 | "incorrectly specified data length\n"); | ||
109 | goto out; | ||
110 | } | ||
111 | pid = find_get_pid(NETLINK_CREDS(skb)->pid); | ||
112 | rc = ecryptfs_process_response(msg, NETLINK_CREDS(skb)->uid, NULL, | ||
113 | pid, nlh->nlmsg_seq); | ||
114 | put_pid(pid); | ||
115 | if (rc) | ||
116 | printk(KERN_ERR | ||
117 | "Error processing response message; rc = [%d]\n", rc); | ||
118 | out: | ||
119 | return rc; | ||
120 | } | ||
121 | |||
122 | /** | ||
123 | * ecryptfs_process_nl_helo | ||
124 | * @skb: The socket buffer containing the nlmsghdr in HELO state | ||
125 | * | ||
126 | * Gets uid and pid of the skb and adds the values to the daemon id | ||
127 | * hash. Returns zero after adding a new daemon id to the hash list; | ||
128 | * non-zero otherwise. | ||
129 | */ | ||
130 | static int ecryptfs_process_nl_helo(struct sk_buff *skb) | ||
131 | { | ||
132 | struct pid *pid; | ||
133 | int rc; | ||
134 | |||
135 | pid = find_get_pid(NETLINK_CREDS(skb)->pid); | ||
136 | rc = ecryptfs_process_helo(ECRYPTFS_TRANSPORT_NETLINK, | ||
137 | NETLINK_CREDS(skb)->uid, NULL, pid); | ||
138 | put_pid(pid); | ||
139 | if (rc) | ||
140 | printk(KERN_WARNING "Error processing HELO; rc = [%d]\n", rc); | ||
141 | return rc; | ||
142 | } | ||
143 | |||
144 | /** | ||
145 | * ecryptfs_process_nl_quit | ||
146 | * @skb: The socket buffer containing the nlmsghdr in QUIT state | ||
147 | * | ||
148 | * Gets uid and pid of the skb and deletes the corresponding daemon | ||
149 | * id, if it is the registered that is requesting the | ||
150 | * deletion. Returns zero after deleting the desired daemon id; | ||
151 | * non-zero otherwise. | ||
152 | */ | ||
153 | static int ecryptfs_process_nl_quit(struct sk_buff *skb) | ||
154 | { | ||
155 | struct pid *pid; | ||
156 | int rc; | ||
157 | |||
158 | pid = find_get_pid(NETLINK_CREDS(skb)->pid); | ||
159 | rc = ecryptfs_process_quit(NETLINK_CREDS(skb)->uid, NULL, pid); | ||
160 | put_pid(pid); | ||
161 | if (rc) | ||
162 | printk(KERN_WARNING | ||
163 | "Error processing QUIT message; rc = [%d]\n", rc); | ||
164 | return rc; | ||
165 | } | ||
166 | |||
167 | /** | ||
168 | * ecryptfs_receive_nl_message | ||
169 | * | ||
170 | * Callback function called by netlink system when a message arrives. | ||
171 | * If the message looks to be valid, then an attempt is made to assign | ||
172 | * it to its desired netlink context element and wake up the process | ||
173 | * that is waiting for a response. | ||
174 | */ | ||
175 | static void ecryptfs_receive_nl_message(struct sk_buff *skb) | ||
176 | { | ||
177 | struct nlmsghdr *nlh; | ||
178 | |||
179 | nlh = nlmsg_hdr(skb); | ||
180 | if (!NLMSG_OK(nlh, skb->len)) { | ||
181 | ecryptfs_printk(KERN_ERR, "Received corrupt netlink " | ||
182 | "message\n"); | ||
183 | goto free; | ||
184 | } | ||
185 | switch (nlh->nlmsg_type) { | ||
186 | case ECRYPTFS_MSG_RESPONSE: | ||
187 | if (ecryptfs_process_nl_response(skb)) { | ||
188 | ecryptfs_printk(KERN_WARNING, "Failed to " | ||
189 | "deliver netlink response to " | ||
190 | "requesting operation\n"); | ||
191 | } | ||
192 | break; | ||
193 | case ECRYPTFS_MSG_HELO: | ||
194 | if (ecryptfs_process_nl_helo(skb)) { | ||
195 | ecryptfs_printk(KERN_WARNING, "Failed to " | ||
196 | "fulfill HELO request\n"); | ||
197 | } | ||
198 | break; | ||
199 | case ECRYPTFS_MSG_QUIT: | ||
200 | if (ecryptfs_process_nl_quit(skb)) { | ||
201 | ecryptfs_printk(KERN_WARNING, "Failed to " | ||
202 | "fulfill QUIT request\n"); | ||
203 | } | ||
204 | break; | ||
205 | default: | ||
206 | ecryptfs_printk(KERN_WARNING, "Dropping netlink " | ||
207 | "message of unrecognized type [%d]\n", | ||
208 | nlh->nlmsg_type); | ||
209 | break; | ||
210 | } | ||
211 | free: | ||
212 | kfree_skb(skb); | ||
213 | } | ||
214 | |||
215 | /** | ||
216 | * ecryptfs_init_netlink | ||
217 | * | ||
218 | * Initializes the daemon id hash list, netlink context array, and | ||
219 | * necessary locks. Returns zero upon success; non-zero upon error. | ||
220 | */ | ||
221 | int ecryptfs_init_netlink(void) | ||
222 | { | ||
223 | int rc; | ||
224 | |||
225 | ecryptfs_nl_sock = netlink_kernel_create(&init_net, NETLINK_ECRYPTFS, 0, | ||
226 | ecryptfs_receive_nl_message, | ||
227 | NULL, THIS_MODULE); | ||
228 | if (!ecryptfs_nl_sock) { | ||
229 | rc = -EIO; | ||
230 | ecryptfs_printk(KERN_ERR, "Failed to create netlink socket\n"); | ||
231 | goto out; | ||
232 | } | ||
233 | ecryptfs_nl_sock->sk_sndtimeo = ECRYPTFS_DEFAULT_SEND_TIMEOUT; | ||
234 | rc = 0; | ||
235 | out: | ||
236 | return rc; | ||
237 | } | ||
238 | |||
239 | /** | ||
240 | * ecryptfs_release_netlink | ||
241 | * | ||
242 | * Frees all memory used by the netlink context array and releases the | ||
243 | * netlink socket. | ||
244 | */ | ||
245 | void ecryptfs_release_netlink(void) | ||
246 | { | ||
247 | netlink_kernel_release(ecryptfs_nl_sock); | ||
248 | ecryptfs_nl_sock = NULL; | ||
249 | } | ||