diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2007-10-26 13:33:01 -0400 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-01-30 02:05:46 -0500 |
| commit | 5cce428d953cc3843b100e078dbc3c01c6411b85 (patch) | |
| tree | 29a61ee7ae3dff46c240cd7c45ed22aa69c44064 /fs | |
| parent | d45273ed6f4613e81701c3e896d9db200c288fff (diff) | |
NFS: Remove an unneeded check in decode_compound_header_arg()
Clean up: The header tag length is unsigned, so checking that it is less
than zero is unnecessary.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfs/callback_xdr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/callback_xdr.c b/fs/nfs/callback_xdr.c index 058ade7efe79..97abd829e432 100644 --- a/fs/nfs/callback_xdr.c +++ b/fs/nfs/callback_xdr.c | |||
| @@ -139,7 +139,7 @@ static __be32 decode_compound_hdr_arg(struct xdr_stream *xdr, struct cb_compound | |||
| 139 | if (unlikely(status != 0)) | 139 | if (unlikely(status != 0)) |
| 140 | return status; | 140 | return status; |
| 141 | /* We do not like overly long tags! */ | 141 | /* We do not like overly long tags! */ |
| 142 | if (hdr->taglen > CB_OP_TAGLEN_MAXSZ-12 || hdr->taglen < 0) { | 142 | if (hdr->taglen > CB_OP_TAGLEN_MAXSZ - 12) { |
| 143 | printk("NFSv4 CALLBACK %s: client sent tag of length %u\n", | 143 | printk("NFSv4 CALLBACK %s: client sent tag of length %u\n", |
| 144 | __FUNCTION__, hdr->taglen); | 144 | __FUNCTION__, hdr->taglen); |
| 145 | return htonl(NFS4ERR_RESOURCE); | 145 | return htonl(NFS4ERR_RESOURCE); |