aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs
diff options
context:
space:
mode:
authorDave Chinner <david@fromorbit.com>2010-03-03 20:46:23 -0500
committerGreg Kroah-Hartman <gregkh@suse.de>2010-04-26 10:48:02 -0400
commitd4187adfe63696f0abc60d32320271f1ec7e8110 (patch)
tree387480abcbe8a6217ee4b281e94ddf28646219b7 /fs/xfs
parent87bcb4b15d9443cf9a12943fb9162e53ac045b55 (diff)
xfs: check for more work before sleeping in xfssyncd
commit 20f6b2c785cf187445f126321638ab8ba7aa7494 upstream. xfssyncd processes a queue of work by detaching the queue and then iterating over all the work items. It then sleeps for a time period or until new work comes in. If new work is queued while xfssyncd is actively processing the detached work queue, it will not process that new work until after a sleep timeout or the next work event queued wakes it. Fix this by checking the work queue again before going to sleep. Signed-off-by: Dave Chinner <david@fromorbit.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Alex Elder <aelder@sgi.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'fs/xfs')
-rw-r--r--fs/xfs/linux-2.6/xfs_sync.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/xfs/linux-2.6/xfs_sync.c b/fs/xfs/linux-2.6/xfs_sync.c
index 687e9fc582ca..6b6b39416ad3 100644
--- a/fs/xfs/linux-2.6/xfs_sync.c
+++ b/fs/xfs/linux-2.6/xfs_sync.c
@@ -613,7 +613,8 @@ xfssyncd(
613 set_freezable(); 613 set_freezable();
614 timeleft = xfs_syncd_centisecs * msecs_to_jiffies(10); 614 timeleft = xfs_syncd_centisecs * msecs_to_jiffies(10);
615 for (;;) { 615 for (;;) {
616 timeleft = schedule_timeout_interruptible(timeleft); 616 if (list_empty(&mp->m_sync_list))
617 timeleft = schedule_timeout_interruptible(timeleft);
617 /* swsusp */ 618 /* swsusp */
618 try_to_freeze(); 619 try_to_freeze();
619 if (kthread_should_stop() && list_empty(&mp->m_sync_list)) 620 if (kthread_should_stop() && list_empty(&mp->m_sync_list))
@@ -633,8 +634,7 @@ xfssyncd(
633 list_add_tail(&mp->m_sync_work.w_list, 634 list_add_tail(&mp->m_sync_work.w_list,
634 &mp->m_sync_list); 635 &mp->m_sync_list);
635 } 636 }
636 list_for_each_entry_safe(work, n, &mp->m_sync_list, w_list) 637 list_splice_init(&mp->m_sync_list, &tmp);
637 list_move(&work->w_list, &tmp);
638 spin_unlock(&mp->m_sync_lock); 638 spin_unlock(&mp->m_sync_lock);
639 639
640 list_for_each_entry_safe(work, n, &tmp, w_list) { 640 list_for_each_entry_safe(work, n, &tmp, w_list) {