diff options
author | Dave Chinner <dchinner@redhat.com> | 2013-08-12 06:49:43 -0400 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-08-12 17:46:08 -0400 |
commit | c5c249b42464cbcda3ac5cbdc114f6a6d5b0b7ac (patch) | |
tree | 26870433ba4e8a002497260f94394391b00d782e /fs/xfs | |
parent | 6898811459ff523ed256c07d1d5c54ba915d51ac (diff) |
xfs: minor cleanups
These come from syncing the shared userspace and kernel code. Small
whitespace and trivial cleanups.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs')
-rw-r--r-- | fs/xfs/xfs_attr_leaf.c | 2 | ||||
-rw-r--r-- | fs/xfs/xfs_attr_remote.c | 8 | ||||
-rw-r--r-- | fs/xfs/xfs_bmap_btree.c | 4 | ||||
-rw-r--r-- | fs/xfs/xfs_inode_fork.c | 4 |
4 files changed, 4 insertions, 14 deletions
diff --git a/fs/xfs/xfs_attr_leaf.c b/fs/xfs/xfs_attr_leaf.c index fe0ade9a74ba..4dba2f9455f4 100644 --- a/fs/xfs/xfs_attr_leaf.c +++ b/fs/xfs/xfs_attr_leaf.c | |||
@@ -936,7 +936,6 @@ out: | |||
936 | return error; | 936 | return error; |
937 | } | 937 | } |
938 | 938 | ||
939 | |||
940 | /*======================================================================== | 939 | /*======================================================================== |
941 | * Routines used for growing the Btree. | 940 | * Routines used for growing the Btree. |
942 | *========================================================================*/ | 941 | *========================================================================*/ |
@@ -1297,7 +1296,6 @@ xfs_attr3_leaf_compact( | |||
1297 | ichdr_dst->freemap[0].size = ichdr_dst->firstused - | 1296 | ichdr_dst->freemap[0].size = ichdr_dst->firstused - |
1298 | ichdr_dst->freemap[0].base; | 1297 | ichdr_dst->freemap[0].base; |
1299 | 1298 | ||
1300 | |||
1301 | /* write the header back to initialise the underlying buffer */ | 1299 | /* write the header back to initialise the underlying buffer */ |
1302 | xfs_attr3_leaf_hdr_to_disk(leaf_dst, ichdr_dst); | 1300 | xfs_attr3_leaf_hdr_to_disk(leaf_dst, ichdr_dst); |
1303 | 1301 | ||
diff --git a/fs/xfs/xfs_attr_remote.c b/fs/xfs/xfs_attr_remote.c index 13a0ed9cb40a..b42926a5400d 100644 --- a/fs/xfs/xfs_attr_remote.c +++ b/fs/xfs/xfs_attr_remote.c | |||
@@ -251,7 +251,7 @@ xfs_attr_rmtval_copyout( | |||
251 | int hdr_size = 0; | 251 | int hdr_size = 0; |
252 | int byte_cnt = XFS_ATTR3_RMT_BUF_SPACE(mp, XFS_LBSIZE(mp)); | 252 | int byte_cnt = XFS_ATTR3_RMT_BUF_SPACE(mp, XFS_LBSIZE(mp)); |
253 | 253 | ||
254 | byte_cnt = min_t(int, *valuelen, byte_cnt); | 254 | byte_cnt = min(*valuelen, byte_cnt); |
255 | 255 | ||
256 | if (xfs_sb_version_hascrc(&mp->m_sb)) { | 256 | if (xfs_sb_version_hascrc(&mp->m_sb)) { |
257 | if (!xfs_attr3_rmt_hdr_ok(mp, src, ino, *offset, | 257 | if (!xfs_attr3_rmt_hdr_ok(mp, src, ino, *offset, |
@@ -545,11 +545,6 @@ xfs_attr_rmtval_remove( | |||
545 | 545 | ||
546 | /* | 546 | /* |
547 | * Roll through the "value", invalidating the attribute value's blocks. | 547 | * Roll through the "value", invalidating the attribute value's blocks. |
548 | * Note that args->rmtblkcnt is the minimum number of data blocks we'll | ||
549 | * see for a CRC enabled remote attribute. Each extent will have a | ||
550 | * header, and so we may have more blocks than we realise here. If we | ||
551 | * fail to map the blocks correctly, we'll have problems with the buffer | ||
552 | * lookups. | ||
553 | */ | 548 | */ |
554 | lblkno = args->rmtblkno; | 549 | lblkno = args->rmtblkno; |
555 | blkcnt = args->rmtblkcnt; | 550 | blkcnt = args->rmtblkcnt; |
@@ -630,4 +625,3 @@ xfs_attr_rmtval_remove( | |||
630 | } | 625 | } |
631 | return(0); | 626 | return(0); |
632 | } | 627 | } |
633 | |||
diff --git a/fs/xfs/xfs_bmap_btree.c b/fs/xfs/xfs_bmap_btree.c index bcee383b23b6..cf3bc76710c3 100644 --- a/fs/xfs/xfs_bmap_btree.c +++ b/fs/xfs/xfs_bmap_btree.c | |||
@@ -722,7 +722,7 @@ xfs_bmbt_key_diff( | |||
722 | cur->bc_rec.b.br_startoff; | 722 | cur->bc_rec.b.br_startoff; |
723 | } | 723 | } |
724 | 724 | ||
725 | static int | 725 | static bool |
726 | xfs_bmbt_verify( | 726 | xfs_bmbt_verify( |
727 | struct xfs_buf *bp) | 727 | struct xfs_buf *bp) |
728 | { | 728 | { |
@@ -775,7 +775,6 @@ xfs_bmbt_verify( | |||
775 | return false; | 775 | return false; |
776 | 776 | ||
777 | return true; | 777 | return true; |
778 | |||
779 | } | 778 | } |
780 | 779 | ||
781 | static void | 780 | static void |
@@ -789,7 +788,6 @@ xfs_bmbt_read_verify( | |||
789 | bp->b_target->bt_mount, bp->b_addr); | 788 | bp->b_target->bt_mount, bp->b_addr); |
790 | xfs_buf_ioerror(bp, EFSCORRUPTED); | 789 | xfs_buf_ioerror(bp, EFSCORRUPTED); |
791 | } | 790 | } |
792 | |||
793 | } | 791 | } |
794 | 792 | ||
795 | static void | 793 | static void |
diff --git a/fs/xfs/xfs_inode_fork.c b/fs/xfs/xfs_inode_fork.c index 8b8ba0234371..f06570bb36bd 100644 --- a/fs/xfs/xfs_inode_fork.c +++ b/fs/xfs/xfs_inode_fork.c | |||
@@ -780,8 +780,8 @@ xfs_iextents_copy( | |||
780 | } | 780 | } |
781 | 781 | ||
782 | /* Translate to on disk format */ | 782 | /* Translate to on disk format */ |
783 | put_unaligned(cpu_to_be64(ep->l0), &dp->l0); | 783 | put_unaligned_be64(ep->l0, &dp->l0); |
784 | put_unaligned(cpu_to_be64(ep->l1), &dp->l1); | 784 | put_unaligned_be64(ep->l1, &dp->l1); |
785 | dp++; | 785 | dp++; |
786 | copied++; | 786 | copied++; |
787 | } | 787 | } |