aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2014-05-19 18:23:06 -0400
committerDave Chinner <david@fromorbit.com>2014-05-19 18:23:06 -0400
commit7c166350b15cbec4ed9357563461b6e1d2a44ea9 (patch)
tree7a2e54615465f7831561dbcb65f8f9486688eaca /fs/xfs
parent110dc24ad2ae4e9b94b08632fe1eb2fcdff83045 (diff)
xfs: remove redundant checks from xfs_da_read_buf
All of the verification checks of magic numbers are now done by verifiers, so ther eis no need to check them again once the buffer has been successfully read. If the magic number is bad, it won't even get to that code to verify it so it really serves no purpose at all anymore. Remove it. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs')
-rw-r--r--fs/xfs/xfs_da_btree.c41
1 files changed, 0 insertions, 41 deletions
diff --git a/fs/xfs/xfs_da_btree.c b/fs/xfs/xfs_da_btree.c
index 6cc5f6785a77..99b980db3419 100644
--- a/fs/xfs/xfs_da_btree.c
+++ b/fs/xfs/xfs_da_btree.c
@@ -2625,47 +2625,6 @@ xfs_da_read_buf(
2625 xfs_buf_set_ref(bp, XFS_ATTR_BTREE_REF); 2625 xfs_buf_set_ref(bp, XFS_ATTR_BTREE_REF);
2626 else 2626 else
2627 xfs_buf_set_ref(bp, XFS_DIR_BTREE_REF); 2627 xfs_buf_set_ref(bp, XFS_DIR_BTREE_REF);
2628
2629 /*
2630 * This verification code will be moved to a CRC verification callback
2631 * function so just leave it here unchanged until then.
2632 */
2633 {
2634 xfs_dir2_data_hdr_t *hdr = bp->b_addr;
2635 xfs_dir2_free_t *free = bp->b_addr;
2636 xfs_da_blkinfo_t *info = bp->b_addr;
2637 uint magic, magic1;
2638 struct xfs_mount *mp = dp->i_mount;
2639
2640 magic = be16_to_cpu(info->magic);
2641 magic1 = be32_to_cpu(hdr->magic);
2642 if (unlikely(
2643 XFS_TEST_ERROR((magic != XFS_DA_NODE_MAGIC) &&
2644 (magic != XFS_DA3_NODE_MAGIC) &&
2645 (magic != XFS_ATTR_LEAF_MAGIC) &&
2646 (magic != XFS_ATTR3_LEAF_MAGIC) &&
2647 (magic != XFS_DIR2_LEAF1_MAGIC) &&
2648 (magic != XFS_DIR3_LEAF1_MAGIC) &&
2649 (magic != XFS_DIR2_LEAFN_MAGIC) &&
2650 (magic != XFS_DIR3_LEAFN_MAGIC) &&
2651 (magic1 != XFS_DIR2_BLOCK_MAGIC) &&
2652 (magic1 != XFS_DIR3_BLOCK_MAGIC) &&
2653 (magic1 != XFS_DIR2_DATA_MAGIC) &&
2654 (magic1 != XFS_DIR3_DATA_MAGIC) &&
2655 (free->hdr.magic !=
2656 cpu_to_be32(XFS_DIR2_FREE_MAGIC)) &&
2657 (free->hdr.magic !=
2658 cpu_to_be32(XFS_DIR3_FREE_MAGIC)),
2659 mp, XFS_ERRTAG_DA_READ_BUF,
2660 XFS_RANDOM_DA_READ_BUF))) {
2661 trace_xfs_da_btree_corrupt(bp, _RET_IP_);
2662 XFS_CORRUPTION_ERROR("xfs_da_do_buf(2)",
2663 XFS_ERRLEVEL_LOW, mp, info);
2664 error = XFS_ERROR(EFSCORRUPTED);
2665 xfs_trans_brelse(trans, bp);
2666 goto out_free;
2667 }
2668 }
2669 *bpp = bp; 2628 *bpp = bp;
2670out_free: 2629out_free:
2671 if (mapp != &map) 2630 if (mapp != &map)