aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@infradead.org>2014-06-06 02:05:15 -0400
committerDave Chinner <david@fromorbit.com>2014-06-06 02:05:15 -0400
commit448011e2ab1c44f7990a62649580bde0da5242b5 (patch)
tree78fd087d470f28bb67de5165a5471f69a26f352f /fs/xfs
parent72208ee060635dfab2b3bd447a95e0f9c419e954 (diff)
xfs: tone down writepage/releasepage WARN_ONs
I recently ran into the issue fixed by "xfs: kill buffers over failed write ranges properly" which spams the log with lots of backtraces. Make debugging any issues like that easier by using WARN_ON_ONCE in the writeback code. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
Diffstat (limited to 'fs/xfs')
-rw-r--r--fs/xfs/xfs_aops.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 0479c32c5eb1..ce0c5ca0a8a3 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -975,7 +975,7 @@ xfs_vm_writepage(
975 * Given that we do not allow direct reclaim to call us, we should 975 * Given that we do not allow direct reclaim to call us, we should
976 * never be called while in a filesystem transaction. 976 * never be called while in a filesystem transaction.
977 */ 977 */
978 if (WARN_ON(current->flags & PF_FSTRANS)) 978 if (WARN_ON_ONCE(current->flags & PF_FSTRANS))
979 goto redirty; 979 goto redirty;
980 980
981 /* Is this page beyond the end of the file? */ 981 /* Is this page beyond the end of the file? */
@@ -1188,9 +1188,9 @@ xfs_vm_releasepage(
1188 1188
1189 xfs_count_page_state(page, &delalloc, &unwritten); 1189 xfs_count_page_state(page, &delalloc, &unwritten);
1190 1190
1191 if (WARN_ON(delalloc)) 1191 if (WARN_ON_ONCE(delalloc))
1192 return 0; 1192 return 0;
1193 if (WARN_ON(unwritten)) 1193 if (WARN_ON_ONCE(unwritten))
1194 return 0; 1194 return 0;
1195 1195
1196 return try_to_free_buffers(page); 1196 return try_to_free_buffers(page);