aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_trans_buf.c
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@infradead.org>2011-10-10 12:52:47 -0400
committerAlex Elder <aelder@sgi.com>2011-10-11 22:15:10 -0400
commitaf5c4bee499eb68bc36ca046030394d82d0e3669 (patch)
tree4d015bdd36d9c424e04c8aaf8050dccb79cd7c31 /fs/xfs/xfs_trans_buf.c
parentc867cb61641751fd3d86350232d64ae2a10137d4 (diff)
xfs: remove buffers from the delwri list in xfs_buf_stale
For each call to xfs_buf_stale we call xfs_buf_delwri_dequeue either directly before or after it, or are guaranteed by the surrounding conditionals that we are never called on delwri buffers. Simply this situation by moving the call to xfs_buf_delwri_dequeue into xfs_buf_stale. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_trans_buf.c')
-rw-r--r--fs/xfs/xfs_trans_buf.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/xfs/xfs_trans_buf.c b/fs/xfs/xfs_trans_buf.c
index d03a8ee19172..5bab5980a6f9 100644
--- a/fs/xfs/xfs_trans_buf.c
+++ b/fs/xfs/xfs_trans_buf.c
@@ -162,7 +162,6 @@ xfs_trans_get_buf(xfs_trans_t *tp,
162 ASSERT(xfs_buf_islocked(bp)); 162 ASSERT(xfs_buf_islocked(bp));
163 if (XFS_FORCED_SHUTDOWN(tp->t_mountp)) { 163 if (XFS_FORCED_SHUTDOWN(tp->t_mountp)) {
164 xfs_buf_stale(bp); 164 xfs_buf_stale(bp);
165 xfs_buf_delwri_dequeue(bp);
166 XFS_BUF_DONE(bp); 165 XFS_BUF_DONE(bp);
167 } 166 }
168 167
@@ -391,7 +390,6 @@ xfs_trans_read_buf(
391 if (bp->b_error) { 390 if (bp->b_error) {
392 error = bp->b_error; 391 error = bp->b_error;
393 xfs_buf_stale(bp); 392 xfs_buf_stale(bp);
394 xfs_buf_delwri_dequeue(bp);
395 XFS_BUF_DONE(bp); 393 XFS_BUF_DONE(bp);
396 xfs_ioerror_alert("xfs_trans_read_buf", mp, 394 xfs_ioerror_alert("xfs_trans_read_buf", mp,
397 bp, blkno); 395 bp, blkno);
@@ -744,7 +742,6 @@ xfs_trans_binval(
744 * We set the stale bit in the buffer as well since we're getting 742 * We set the stale bit in the buffer as well since we're getting
745 * rid of it. 743 * rid of it.
746 */ 744 */
747 xfs_buf_delwri_dequeue(bp);
748 xfs_buf_stale(bp); 745 xfs_buf_stale(bp);
749 bip->bli_flags |= XFS_BLI_STALE; 746 bip->bli_flags |= XFS_BLI_STALE;
750 bip->bli_flags &= ~(XFS_BLI_INODE_BUF | XFS_BLI_LOGGED | XFS_BLI_DIRTY); 747 bip->bli_flags &= ~(XFS_BLI_INODE_BUF | XFS_BLI_LOGGED | XFS_BLI_DIRTY);