diff options
author | Jie Liu <jeff.liu@oracle.com> | 2013-05-02 07:27:47 -0400 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-06-19 15:54:17 -0400 |
commit | 39a45d8463d98ea57347b871641136be64b216a9 (patch) | |
tree | 7184b8d6abaec378fc41d007fe45dc1abfce99e5 /fs/xfs/xfs_mount.h | |
parent | 2fb8b5027dbde32a45edf5f3d7ee082be9261d93 (diff) |
xfs: Remove XFS_MOUNT_RETERR
XFS_MOUNT_RETERR is going to be set at xfs_parseargs() if
mp->m_dalign is enabled, so any time we enter "if (mp->m_dalign)"
branch in xfs_update_alignment(), XFS_MOUNT_RETERR is set and so
we always be emitting a warning and returning an error.
Hence, we can remove it and get rid of a couple of redundant
check up against it at xfs_upate_alignment().
Thanks Dave Chinner for the suggestions of simplify the code
in xfs_parseargs().
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Cc: Dave Chinner <dchinner@redhat.com>
Cc: Mark Tinguely <tinguely@sgi.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_mount.h')
-rw-r--r-- | fs/xfs/xfs_mount.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h index de7abf677abe..4e374d4a9189 100644 --- a/fs/xfs/xfs_mount.h +++ b/fs/xfs/xfs_mount.h | |||
@@ -227,8 +227,6 @@ typedef struct xfs_mount { | |||
227 | operations, typically for | 227 | operations, typically for |
228 | disk errors in metadata */ | 228 | disk errors in metadata */ |
229 | #define XFS_MOUNT_DISCARD (1ULL << 5) /* discard unused blocks */ | 229 | #define XFS_MOUNT_DISCARD (1ULL << 5) /* discard unused blocks */ |
230 | #define XFS_MOUNT_RETERR (1ULL << 6) /* return alignment errors to | ||
231 | user */ | ||
232 | #define XFS_MOUNT_NOALIGN (1ULL << 7) /* turn off stripe alignment | 230 | #define XFS_MOUNT_NOALIGN (1ULL << 7) /* turn off stripe alignment |
233 | allocations */ | 231 | allocations */ |
234 | #define XFS_MOUNT_ATTR2 (1ULL << 8) /* allow use of attr2 format */ | 232 | #define XFS_MOUNT_ATTR2 (1ULL << 8) /* allow use of attr2 format */ |