aboutsummaryrefslogtreecommitdiffstats
path: root/fs/xfs/xfs_fsops.c
diff options
context:
space:
mode:
authorDave Chinner <dchinner@redhat.com>2012-11-12 06:54:01 -0500
committerBen Myers <bpm@sgi.com>2012-11-15 22:34:02 -0500
commitc3f8fc73ac97b76a12692088ef9cace9af8422c0 (patch)
treea90e132507842b7ed8c5d93e0c002e0dc0f99a5c /fs/xfs/xfs_fsops.c
parentfb59581404ab7ec5075299065c22cb211a9262a9 (diff)
xfs: make buffer read verication an IO completion function
Add a verifier function callback capability to the buffer read interfaces. This will be used by the callers to supply a function that verifies the contents of the buffer when it is read from disk. This patch does not provide callback functions, but simply modifies the interfaces to allow them to be called. The reason for adding this to the read interfaces is that it is very difficult to tell fom the outside is a buffer was just read from disk or whether we just pulled it out of cache. Supplying a callbck allows the buffer cache to use it's internal knowledge of the buffer to execute it only when the buffer is read from disk. It is intended that the verifier functions will mark the buffer with an EFSCORRUPTED error when verification fails. This allows the reading context to distinguish a verification error from an IO error, and potentially take further actions on the buffer (e.g. attempt repair) based on the error reported. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Phil White <pwhite@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_fsops.c')
-rw-r--r--fs/xfs/xfs_fsops.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
index bd9cb7f0b073..5440768ec41c 100644
--- a/fs/xfs/xfs_fsops.c
+++ b/fs/xfs/xfs_fsops.c
@@ -168,7 +168,7 @@ xfs_growfs_data_private(
168 dpct = pct - mp->m_sb.sb_imax_pct; 168 dpct = pct - mp->m_sb.sb_imax_pct;
169 bp = xfs_buf_read_uncached(mp->m_ddev_targp, 169 bp = xfs_buf_read_uncached(mp->m_ddev_targp,
170 XFS_FSB_TO_BB(mp, nb) - XFS_FSS_TO_BB(mp, 1), 170 XFS_FSB_TO_BB(mp, nb) - XFS_FSS_TO_BB(mp, 1),
171 XFS_FSS_TO_BB(mp, 1), 0); 171 XFS_FSS_TO_BB(mp, 1), 0, NULL);
172 if (!bp) 172 if (!bp)
173 return EIO; 173 return EIO;
174 xfs_buf_relse(bp); 174 xfs_buf_relse(bp);
@@ -439,7 +439,7 @@ xfs_growfs_data_private(
439 if (agno < oagcount) { 439 if (agno < oagcount) {
440 error = xfs_trans_read_buf(mp, NULL, mp->m_ddev_targp, 440 error = xfs_trans_read_buf(mp, NULL, mp->m_ddev_targp,
441 XFS_AGB_TO_DADDR(mp, agno, XFS_SB_BLOCK(mp)), 441 XFS_AGB_TO_DADDR(mp, agno, XFS_SB_BLOCK(mp)),
442 XFS_FSS_TO_BB(mp, 1), 0, &bp); 442 XFS_FSS_TO_BB(mp, 1), 0, &bp, NULL);
443 } else { 443 } else {
444 bp = xfs_trans_get_buf(NULL, mp->m_ddev_targp, 444 bp = xfs_trans_get_buf(NULL, mp->m_ddev_targp,
445 XFS_AGB_TO_DADDR(mp, agno, XFS_SB_BLOCK(mp)), 445 XFS_AGB_TO_DADDR(mp, agno, XFS_SB_BLOCK(mp)),