diff options
author | Christoph Hellwig <hch@infradead.org> | 2009-10-19 00:00:03 -0400 |
---|---|---|
committer | Alex Elder <aelder@sgi.com> | 2009-12-11 16:11:20 -0500 |
commit | 80641dc66a2d6dfb22af4413227a92b8ab84c7bb (patch) | |
tree | f7353e4ca2bd4629b41c9ec79306d042d64f90f7 /fs/xfs/xfs_fsops.c | |
parent | c56c9631cbe88f08854a56ff9776c1f310916830 (diff) |
xfs: I/O completion handlers must use NOFS allocations
When completing I/O requests we must not allow the memory allocator to
recurse into the filesystem, as we might deadlock on waiting for the
I/O completion otherwise. The only thing currently allocating normal
GFP_KERNEL memory is the allocation of the transaction structure for
the unwritten extent conversion. Add a memflags argument to
_xfs_trans_alloc to allow controlling the allocator behaviour.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Thomas Neumann <tneumann@users.sourceforge.net>
Tested-by: Thomas Neumann <tneumann@users.sourceforge.net>
Reviewed-by: Alex Elder <aelder@sgi.com>
Signed-off-by: Alex Elder <aelder@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_fsops.c')
-rw-r--r-- | fs/xfs/xfs_fsops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c index 2d0b3e1da9e6..6f83f58c099f 100644 --- a/fs/xfs/xfs_fsops.c +++ b/fs/xfs/xfs_fsops.c | |||
@@ -611,7 +611,7 @@ xfs_fs_log_dummy( | |||
611 | xfs_inode_t *ip; | 611 | xfs_inode_t *ip; |
612 | int error; | 612 | int error; |
613 | 613 | ||
614 | tp = _xfs_trans_alloc(mp, XFS_TRANS_DUMMY1); | 614 | tp = _xfs_trans_alloc(mp, XFS_TRANS_DUMMY1, KM_SLEEP); |
615 | error = xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0); | 615 | error = xfs_trans_reserve(tp, 0, XFS_ICHANGE_LOG_RES(mp), 0, 0, 0); |
616 | if (error) { | 616 | if (error) { |
617 | xfs_trans_cancel(tp, 0); | 617 | xfs_trans_cancel(tp, 0); |