diff options
author | Christoph Hellwig <hch@infradead.org> | 2013-10-14 10:09:35 -0400 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2013-10-21 17:51:33 -0400 |
commit | 76ca4c238cf5858f8ba5bcd24c94c23717f1e14e (patch) | |
tree | 8059d74fc74e68a6f8765ce5f65247ba319117bd /fs/xfs/xfs_file.c | |
parent | 59e5a0e821d838854b3afd030d31f82cee3ecd58 (diff) |
xfs: always take the iolock around xfs_setattr_size
There is no reason to conditionally take the iolock inside xfs_setattr_size
when we can let the caller handle it unconditionally, which just incrases
the lock hold time for the case where it was previously taken internally
by a few instructions.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'fs/xfs/xfs_file.c')
-rw-r--r-- | fs/xfs/xfs_file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index 4c749ab543d0..c9179820c01b 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c | |||
@@ -852,7 +852,7 @@ xfs_file_fallocate( | |||
852 | 852 | ||
853 | iattr.ia_valid = ATTR_SIZE; | 853 | iattr.ia_valid = ATTR_SIZE; |
854 | iattr.ia_size = new_size; | 854 | iattr.ia_size = new_size; |
855 | error = -xfs_setattr_size(ip, &iattr, XFS_ATTR_NOLOCK); | 855 | error = -xfs_setattr_size(ip, &iattr); |
856 | } | 856 | } |
857 | 857 | ||
858 | out_unlock: | 858 | out_unlock: |