xfs: global error sign conversion

Convert all the errors the core XFs code to negative error signs
like the rest of the kernel and remove all the sign conversion we
do in the interface layers.

Errors for conversion (and comparison) found via searches like:

$ git grep " E" fs/xfs
$ git grep "return E" fs/xfs
$ git grep " E[A-Z].*;$" fs/xfs

Negation points found via searches like:

$ git grep "= -[a-z,A-Z]" fs/xfs
$ git grep "return -[a-z,A-D,F-Z]" fs/xfs
$ git grep " -[a-z].*;" fs/xfs

[ with some bits I missed from Brian Foster ]

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

1 files changed, 14 insertions, 14 deletions

diff --git a/fs/xfs/libxfs/xfs_dir2_sf.c b/fs/xfs/libxfs/xfs_dir2_sf.c
index ab3563b87995..8f4f26af35e1 100644
--- a/fs/xfs/libxfs/xfs_dir2_sf.c
+++ b/fs/xfs/libxfs/xfs_dir2_sf.c
@@ -251,7 +251,7 @@ xfs_dir2_block_to_sf(
         logflags = XFS_ILOG_CORE;
         error = xfs_dir2_shrink_inode(args, args->geo->datablk, bp);
         if (error) {
-                ASSERT(error != ENOSPC);
+                ASSERT(error != -ENOSPC);
                 goto out;
         }
 
@@ -299,7 +299,7 @@ xfs_dir2_sf_addname(
 
         trace_xfs_dir2_sf_addname(args);
 
-        ASSERT(xfs_dir2_sf_lookup(args) == ENOENT);
+        ASSERT(xfs_dir2_sf_lookup(args) == -ENOENT);
         dp = args->dp;
         ASSERT(dp->i_df.if_flags & XFS_IFINLINE);
         /*
@@ -307,7 +307,7 @@ xfs_dir2_sf_addname(
          */
         if (dp->i_d.di_size < offsetof(xfs_dir2_sf_hdr_t, parent)) {
                 ASSERT(XFS_FORCED_SHUTDOWN(dp->i_mount));
-                return EIO;
+                return -EIO;
         }
         ASSERT(dp->i_df.if_bytes == dp->i_d.di_size);
         ASSERT(dp->i_df.if_u1.if_data != NULL);
@@ -345,7 +345,7 @@ xfs_dir2_sf_addname(
                  * Just checking or no space reservation, it doesn't fit.
                  */
                 if ((args->op_flags & XFS_DA_OP_JUSTCHECK) || args->total == 0)
-                        return ENOSPC;
+                        return -ENOSPC;
                 /*
                  * Convert to block form then add the name.
                  */
@@ -738,7 +738,7 @@ xfs_dir2_sf_lookup(
          */
         if (dp->i_d.di_size < offsetof(xfs_dir2_sf_hdr_t, parent)) {
                 ASSERT(XFS_FORCED_SHUTDOWN(dp->i_mount));
-                return EIO;
+                return -EIO;
         }
         ASSERT(dp->i_df.if_bytes == dp->i_d.di_size);
         ASSERT(dp->i_df.if_u1.if_data != NULL);
@@ -751,7 +751,7 @@ xfs_dir2_sf_lookup(
                 args->inumber = dp->i_ino;
                 args->cmpresult = XFS_CMP_EXACT;
                 args->filetype = XFS_DIR3_FT_DIR;
-                return EEXIST;
+                return -EEXIST;
         }
         /*
          * Special case for ..
@@ -761,7 +761,7 @@ xfs_dir2_sf_lookup(
                 args->inumber = dp->d_ops->sf_get_parent_ino(sfp);
                 args->cmpresult = XFS_CMP_EXACT;
                 args->filetype = XFS_DIR3_FT_DIR;
-                return EEXIST;
+                return -EEXIST;
         }
         /*
          * Loop over all the entries trying to match ours.
@@ -781,17 +781,17 @@ xfs_dir2_sf_lookup(
                         args->inumber = dp->d_ops->sf_get_ino(sfp, sfep);
                         args->filetype = dp->d_ops->sf_get_ftype(sfep);
                         if (cmp == XFS_CMP_EXACT)
-                                return EEXIST;
+                                return -EEXIST;
                         ci_sfep = sfep;
                 }
         }
         ASSERT(args->op_flags & XFS_DA_OP_OKNOENT);
         /*
          * Here, we can only be doing a lookup (not a rename or replace).
-         * If a case-insensitive match was not found, return ENOENT.
+         * If a case-insensitive match was not found, return -ENOENT.
          */
         if (!ci_sfep)
-                return ENOENT;
+                return -ENOENT;
         /* otherwise process the CI match as required by the caller */
         error = xfs_dir_cilookup_result(args, ci_sfep->name, ci_sfep->namelen);
         return error;
@@ -824,7 +824,7 @@ xfs_dir2_sf_removename(
          */
         if (oldsize < offsetof(xfs_dir2_sf_hdr_t, parent)) {
                 ASSERT(XFS_FORCED_SHUTDOWN(dp->i_mount));
-                return EIO;
+                return -EIO;
         }
         ASSERT(dp->i_df.if_bytes == oldsize);
         ASSERT(dp->i_df.if_u1.if_data != NULL);
@@ -847,7 +847,7 @@ xfs_dir2_sf_removename(
          * Didn't find it.
          */
         if (i == sfp->count)
-                return ENOENT;
+                return -ENOENT;
         /*
          * Calculate sizes.
          */
@@ -914,7 +914,7 @@ xfs_dir2_sf_replace(
          */
         if (dp->i_d.di_size < offsetof(xfs_dir2_sf_hdr_t, parent)) {
                 ASSERT(XFS_FORCED_SHUTDOWN(dp->i_mount));
-                return EIO;
+                return -EIO;
         }
         ASSERT(dp->i_df.if_bytes == dp->i_d.di_size);
         ASSERT(dp->i_df.if_u1.if_data != NULL);
@@ -990,7 +990,7 @@ xfs_dir2_sf_replace(
                         if (i8elevated)
                                 xfs_dir2_sf_toino4(args);
 #endif
-                        return ENOENT;
+                        return -ENOENT;
                 }
         }
 #if XFS_BIG_INUMS