xfs: global error sign conversion

Convert all the errors the core XFs code to negative error signs
like the rest of the kernel and remove all the sign conversion we
do in the interface layers.

Errors for conversion (and comparison) found via searches like:

$ git grep " E" fs/xfs
$ git grep "return E" fs/xfs
$ git grep " E[A-Z].*;$" fs/xfs

Negation points found via searches like:

$ git grep "= -[a-z,A-Z]" fs/xfs
$ git grep "return -[a-z,A-D,F-Z]" fs/xfs
$ git grep " -[a-z].*;" fs/xfs

[ with some bits I missed from Brian Foster ]

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>

1 files changed, 12 insertions, 12 deletions

diff --git a/fs/xfs/libxfs/xfs_dir2.c b/fs/xfs/libxfs/xfs_dir2.c
index a0aca734199b..6cef22152fd6 100644
--- a/fs/xfs/libxfs/xfs_dir2.c
+++ b/fs/xfs/libxfs/xfs_dir2.c
@@ -108,7 +108,7 @@ xfs_da_mount(
         if (!mp->m_dir_geo || !mp->m_attr_geo) {
                 kmem_free(mp->m_dir_geo);
                 kmem_free(mp->m_attr_geo);
-                return ENOMEM;
+                return -ENOMEM;
         }
 
         /* set up directory geometry */
@@ -202,7 +202,7 @@ xfs_dir_ino_validate(
                 xfs_warn(mp, "Invalid inode number 0x%Lx",
                                 (unsigned long long) ino);
                 XFS_ERROR_REPORT("xfs_dir_ino_validate", XFS_ERRLEVEL_LOW, mp);
-                return EFSCORRUPTED;
+                return -EFSCORRUPTED;
         }
         return 0;
 }
@@ -226,7 +226,7 @@ xfs_dir_init(
 
         args = kmem_zalloc(sizeof(*args), KM_SLEEP | KM_NOFS);
         if (!args)
-                return ENOMEM;
+                return -ENOMEM;
 
         args->geo = dp->i_mount->m_dir_geo;
         args->dp = dp;
@@ -261,7 +261,7 @@ xfs_dir_createname(
 
         args = kmem_zalloc(sizeof(*args), KM_SLEEP | KM_NOFS);
         if (!args)
-                return ENOMEM;
+                return -ENOMEM;
 
         args->geo = dp->i_mount->m_dir_geo;
         args->name = name->name;
@@ -314,18 +314,18 @@ xfs_dir_cilookup_result(
         int             len)
 {
         if (args->cmpresult == XFS_CMP_DIFFERENT)
-                return ENOENT;
+                return -ENOENT;
         if (args->cmpresult != XFS_CMP_CASE ||
                                         !(args->op_flags & XFS_DA_OP_CILOOKUP))
-                return EEXIST;
+                return -EEXIST;
 
         args->value = kmem_alloc(len, KM_NOFS | KM_MAYFAIL);
         if (!args->value)
-                return ENOMEM;
+                return -ENOMEM;
 
         memcpy(args->value, name, len);
         args->valuelen = len;
-        return EEXIST;
+        return -EEXIST;
 }
 
 /*
@@ -392,7 +392,7 @@ xfs_dir_lookup(
                 rval = xfs_dir2_node_lookup(args);
 
 out_check_rval:
-        if (rval == EEXIST)
+        if (rval == -EEXIST)
                 rval = 0;
         if (!rval) {
                 *inum = args->inumber;
@@ -428,7 +428,7 @@ xfs_dir_removename(
 
         args = kmem_zalloc(sizeof(*args), KM_SLEEP | KM_NOFS);
         if (!args)
-                return ENOMEM;
+                return -ENOMEM;
 
         args->geo = dp->i_mount->m_dir_geo;
         args->name = name->name;
@@ -493,7 +493,7 @@ xfs_dir_replace(
 
         args = kmem_zalloc(sizeof(*args), KM_SLEEP | KM_NOFS);
         if (!args)
-                return ENOMEM;
+                return -ENOMEM;
 
         args->geo = dp->i_mount->m_dir_geo;
         args->name = name->name;
@@ -555,7 +555,7 @@ xfs_dir_canenter(
 
         args = kmem_zalloc(sizeof(*args), KM_SLEEP | KM_NOFS);
         if (!args)
-                return ENOMEM;
+                return -ENOMEM;
 
         args->geo = dp->i_mount->m_dir_geo;
         args->name = name->name;