diff options
author | Glenn Elliott <gelliott@cs.unc.edu> | 2012-03-04 19:47:13 -0500 |
---|---|---|
committer | Glenn Elliott <gelliott@cs.unc.edu> | 2012-03-04 19:47:13 -0500 |
commit | c71c03bda1e86c9d5198c5d83f712e695c4f2a1e (patch) | |
tree | ecb166cb3e2b7e2adb3b5e292245fefd23381ac8 /fs/sysfs | |
parent | ea53c912f8a86a8567697115b6a0d8152beee5c8 (diff) | |
parent | 6a00f206debf8a5c8899055726ad127dbeeed098 (diff) |
Merge branch 'mpi-master' into wip-k-fmlpwip-k-fmlp
Conflicts:
litmus/sched_cedf.c
Diffstat (limited to 'fs/sysfs')
-rw-r--r-- | fs/sysfs/Kconfig | 2 | ||||
-rw-r--r-- | fs/sysfs/bin.c | 68 | ||||
-rw-r--r-- | fs/sysfs/dir.c | 10 | ||||
-rw-r--r-- | fs/sysfs/file.c | 12 | ||||
-rw-r--r-- | fs/sysfs/group.c | 59 | ||||
-rw-r--r-- | fs/sysfs/inode.c | 12 | ||||
-rw-r--r-- | fs/sysfs/mount.c | 69 | ||||
-rw-r--r-- | fs/sysfs/sysfs.h | 5 |
8 files changed, 134 insertions, 103 deletions
diff --git a/fs/sysfs/Kconfig b/fs/sysfs/Kconfig index f4b67588b9d6..8c41feacbac5 100644 --- a/fs/sysfs/Kconfig +++ b/fs/sysfs/Kconfig | |||
@@ -1,5 +1,5 @@ | |||
1 | config SYSFS | 1 | config SYSFS |
2 | bool "sysfs file system support" if EMBEDDED | 2 | bool "sysfs file system support" if EXPERT |
3 | default y | 3 | default y |
4 | help | 4 | help |
5 | The sysfs filesystem is a virtual filesystem that the kernel uses to | 5 | The sysfs filesystem is a virtual filesystem that the kernel uses to |
diff --git a/fs/sysfs/bin.c b/fs/sysfs/bin.c index 4e321f7353fa..a4759833d62d 100644 --- a/fs/sysfs/bin.c +++ b/fs/sysfs/bin.c | |||
@@ -179,30 +179,14 @@ static void bin_vma_open(struct vm_area_struct *vma) | |||
179 | struct bin_buffer *bb = file->private_data; | 179 | struct bin_buffer *bb = file->private_data; |
180 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | 180 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; |
181 | 181 | ||
182 | if (!bb->vm_ops || !bb->vm_ops->open) | 182 | if (!bb->vm_ops) |
183 | return; | ||
184 | |||
185 | if (!sysfs_get_active(attr_sd)) | ||
186 | return; | ||
187 | |||
188 | bb->vm_ops->open(vma); | ||
189 | |||
190 | sysfs_put_active(attr_sd); | ||
191 | } | ||
192 | |||
193 | static void bin_vma_close(struct vm_area_struct *vma) | ||
194 | { | ||
195 | struct file *file = vma->vm_file; | ||
196 | struct bin_buffer *bb = file->private_data; | ||
197 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | ||
198 | |||
199 | if (!bb->vm_ops || !bb->vm_ops->close) | ||
200 | return; | 183 | return; |
201 | 184 | ||
202 | if (!sysfs_get_active(attr_sd)) | 185 | if (!sysfs_get_active(attr_sd)) |
203 | return; | 186 | return; |
204 | 187 | ||
205 | bb->vm_ops->close(vma); | 188 | if (bb->vm_ops->open) |
189 | bb->vm_ops->open(vma); | ||
206 | 190 | ||
207 | sysfs_put_active(attr_sd); | 191 | sysfs_put_active(attr_sd); |
208 | } | 192 | } |
@@ -214,13 +198,15 @@ static int bin_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
214 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | 198 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; |
215 | int ret; | 199 | int ret; |
216 | 200 | ||
217 | if (!bb->vm_ops || !bb->vm_ops->fault) | 201 | if (!bb->vm_ops) |
218 | return VM_FAULT_SIGBUS; | 202 | return VM_FAULT_SIGBUS; |
219 | 203 | ||
220 | if (!sysfs_get_active(attr_sd)) | 204 | if (!sysfs_get_active(attr_sd)) |
221 | return VM_FAULT_SIGBUS; | 205 | return VM_FAULT_SIGBUS; |
222 | 206 | ||
223 | ret = bb->vm_ops->fault(vma, vmf); | 207 | ret = VM_FAULT_SIGBUS; |
208 | if (bb->vm_ops->fault) | ||
209 | ret = bb->vm_ops->fault(vma, vmf); | ||
224 | 210 | ||
225 | sysfs_put_active(attr_sd); | 211 | sysfs_put_active(attr_sd); |
226 | return ret; | 212 | return ret; |
@@ -236,13 +222,12 @@ static int bin_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
236 | if (!bb->vm_ops) | 222 | if (!bb->vm_ops) |
237 | return VM_FAULT_SIGBUS; | 223 | return VM_FAULT_SIGBUS; |
238 | 224 | ||
239 | if (!bb->vm_ops->page_mkwrite) | ||
240 | return 0; | ||
241 | |||
242 | if (!sysfs_get_active(attr_sd)) | 225 | if (!sysfs_get_active(attr_sd)) |
243 | return VM_FAULT_SIGBUS; | 226 | return VM_FAULT_SIGBUS; |
244 | 227 | ||
245 | ret = bb->vm_ops->page_mkwrite(vma, vmf); | 228 | ret = 0; |
229 | if (bb->vm_ops->page_mkwrite) | ||
230 | ret = bb->vm_ops->page_mkwrite(vma, vmf); | ||
246 | 231 | ||
247 | sysfs_put_active(attr_sd); | 232 | sysfs_put_active(attr_sd); |
248 | return ret; | 233 | return ret; |
@@ -256,13 +241,15 @@ static int bin_access(struct vm_area_struct *vma, unsigned long addr, | |||
256 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | 241 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; |
257 | int ret; | 242 | int ret; |
258 | 243 | ||
259 | if (!bb->vm_ops || !bb->vm_ops->access) | 244 | if (!bb->vm_ops) |
260 | return -EINVAL; | 245 | return -EINVAL; |
261 | 246 | ||
262 | if (!sysfs_get_active(attr_sd)) | 247 | if (!sysfs_get_active(attr_sd)) |
263 | return -EINVAL; | 248 | return -EINVAL; |
264 | 249 | ||
265 | ret = bb->vm_ops->access(vma, addr, buf, len, write); | 250 | ret = -EINVAL; |
251 | if (bb->vm_ops->access) | ||
252 | ret = bb->vm_ops->access(vma, addr, buf, len, write); | ||
266 | 253 | ||
267 | sysfs_put_active(attr_sd); | 254 | sysfs_put_active(attr_sd); |
268 | return ret; | 255 | return ret; |
@@ -276,13 +263,15 @@ static int bin_set_policy(struct vm_area_struct *vma, struct mempolicy *new) | |||
276 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | 263 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; |
277 | int ret; | 264 | int ret; |
278 | 265 | ||
279 | if (!bb->vm_ops || !bb->vm_ops->set_policy) | 266 | if (!bb->vm_ops) |
280 | return 0; | 267 | return 0; |
281 | 268 | ||
282 | if (!sysfs_get_active(attr_sd)) | 269 | if (!sysfs_get_active(attr_sd)) |
283 | return -EINVAL; | 270 | return -EINVAL; |
284 | 271 | ||
285 | ret = bb->vm_ops->set_policy(vma, new); | 272 | ret = 0; |
273 | if (bb->vm_ops->set_policy) | ||
274 | ret = bb->vm_ops->set_policy(vma, new); | ||
286 | 275 | ||
287 | sysfs_put_active(attr_sd); | 276 | sysfs_put_active(attr_sd); |
288 | return ret; | 277 | return ret; |
@@ -296,13 +285,15 @@ static struct mempolicy *bin_get_policy(struct vm_area_struct *vma, | |||
296 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | 285 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; |
297 | struct mempolicy *pol; | 286 | struct mempolicy *pol; |
298 | 287 | ||
299 | if (!bb->vm_ops || !bb->vm_ops->get_policy) | 288 | if (!bb->vm_ops) |
300 | return vma->vm_policy; | 289 | return vma->vm_policy; |
301 | 290 | ||
302 | if (!sysfs_get_active(attr_sd)) | 291 | if (!sysfs_get_active(attr_sd)) |
303 | return vma->vm_policy; | 292 | return vma->vm_policy; |
304 | 293 | ||
305 | pol = bb->vm_ops->get_policy(vma, addr); | 294 | pol = vma->vm_policy; |
295 | if (bb->vm_ops->get_policy) | ||
296 | pol = bb->vm_ops->get_policy(vma, addr); | ||
306 | 297 | ||
307 | sysfs_put_active(attr_sd); | 298 | sysfs_put_active(attr_sd); |
308 | return pol; | 299 | return pol; |
@@ -316,13 +307,15 @@ static int bin_migrate(struct vm_area_struct *vma, const nodemask_t *from, | |||
316 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; | 307 | struct sysfs_dirent *attr_sd = file->f_path.dentry->d_fsdata; |
317 | int ret; | 308 | int ret; |
318 | 309 | ||
319 | if (!bb->vm_ops || !bb->vm_ops->migrate) | 310 | if (!bb->vm_ops) |
320 | return 0; | 311 | return 0; |
321 | 312 | ||
322 | if (!sysfs_get_active(attr_sd)) | 313 | if (!sysfs_get_active(attr_sd)) |
323 | return 0; | 314 | return 0; |
324 | 315 | ||
325 | ret = bb->vm_ops->migrate(vma, from, to, flags); | 316 | ret = 0; |
317 | if (bb->vm_ops->migrate) | ||
318 | ret = bb->vm_ops->migrate(vma, from, to, flags); | ||
326 | 319 | ||
327 | sysfs_put_active(attr_sd); | 320 | sysfs_put_active(attr_sd); |
328 | return ret; | 321 | return ret; |
@@ -331,7 +324,6 @@ static int bin_migrate(struct vm_area_struct *vma, const nodemask_t *from, | |||
331 | 324 | ||
332 | static const struct vm_operations_struct bin_vm_ops = { | 325 | static const struct vm_operations_struct bin_vm_ops = { |
333 | .open = bin_vma_open, | 326 | .open = bin_vma_open, |
334 | .close = bin_vma_close, | ||
335 | .fault = bin_fault, | 327 | .fault = bin_fault, |
336 | .page_mkwrite = bin_page_mkwrite, | 328 | .page_mkwrite = bin_page_mkwrite, |
337 | .access = bin_access, | 329 | .access = bin_access, |
@@ -377,6 +369,14 @@ static int mmap(struct file *file, struct vm_area_struct *vma) | |||
377 | if (bb->mmapped && bb->vm_ops != vma->vm_ops) | 369 | if (bb->mmapped && bb->vm_ops != vma->vm_ops) |
378 | goto out_put; | 370 | goto out_put; |
379 | 371 | ||
372 | /* | ||
373 | * It is not possible to successfully wrap close. | ||
374 | * So error if someone is trying to use close. | ||
375 | */ | ||
376 | rc = -EINVAL; | ||
377 | if (vma->vm_ops && vma->vm_ops->close) | ||
378 | goto out_put; | ||
379 | |||
380 | rc = 0; | 380 | rc = 0; |
381 | bb->mmapped = 1; | 381 | bb->mmapped = 1; |
382 | bb->vm_ops = vma->vm_ops; | 382 | bb->vm_ops = vma->vm_ops; |
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c index 7e54bac8c4b0..ea9120a830d8 100644 --- a/fs/sysfs/dir.c +++ b/fs/sysfs/dir.c | |||
@@ -231,7 +231,7 @@ void release_sysfs_dirent(struct sysfs_dirent * sd) | |||
231 | goto repeat; | 231 | goto repeat; |
232 | } | 232 | } |
233 | 233 | ||
234 | static int sysfs_dentry_delete(struct dentry *dentry) | 234 | static int sysfs_dentry_delete(const struct dentry *dentry) |
235 | { | 235 | { |
236 | struct sysfs_dirent *sd = dentry->d_fsdata; | 236 | struct sysfs_dirent *sd = dentry->d_fsdata; |
237 | return !!(sd->s_flags & SYSFS_FLAG_REMOVED); | 237 | return !!(sd->s_flags & SYSFS_FLAG_REMOVED); |
@@ -239,9 +239,13 @@ static int sysfs_dentry_delete(struct dentry *dentry) | |||
239 | 239 | ||
240 | static int sysfs_dentry_revalidate(struct dentry *dentry, struct nameidata *nd) | 240 | static int sysfs_dentry_revalidate(struct dentry *dentry, struct nameidata *nd) |
241 | { | 241 | { |
242 | struct sysfs_dirent *sd = dentry->d_fsdata; | 242 | struct sysfs_dirent *sd; |
243 | int is_dir; | 243 | int is_dir; |
244 | 244 | ||
245 | if (nd->flags & LOOKUP_RCU) | ||
246 | return -ECHILD; | ||
247 | |||
248 | sd = dentry->d_fsdata; | ||
245 | mutex_lock(&sysfs_mutex); | 249 | mutex_lock(&sysfs_mutex); |
246 | 250 | ||
247 | /* The sysfs dirent has been deleted */ | 251 | /* The sysfs dirent has been deleted */ |
@@ -701,7 +705,7 @@ static struct dentry * sysfs_lookup(struct inode *dir, struct dentry *dentry, | |||
701 | /* instantiate and hash dentry */ | 705 | /* instantiate and hash dentry */ |
702 | ret = d_find_alias(inode); | 706 | ret = d_find_alias(inode); |
703 | if (!ret) { | 707 | if (!ret) { |
704 | dentry->d_op = &sysfs_dentry_ops; | 708 | d_set_d_op(dentry, &sysfs_dentry_ops); |
705 | dentry->d_fsdata = sysfs_get(sd); | 709 | dentry->d_fsdata = sysfs_get(sd); |
706 | d_add(dentry, inode); | 710 | d_add(dentry, inode); |
707 | } else { | 711 | } else { |
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index da3fefe91a8f..1ad8c93c1b85 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c | |||
@@ -24,13 +24,6 @@ | |||
24 | 24 | ||
25 | #include "sysfs.h" | 25 | #include "sysfs.h" |
26 | 26 | ||
27 | /* used in crash dumps to help with debugging */ | ||
28 | static char last_sysfs_file[PATH_MAX]; | ||
29 | void sysfs_printk_last_file(void) | ||
30 | { | ||
31 | printk(KERN_EMERG "last sysfs file: %s\n", last_sysfs_file); | ||
32 | } | ||
33 | |||
34 | /* | 27 | /* |
35 | * There's one sysfs_buffer for each open file and one | 28 | * There's one sysfs_buffer for each open file and one |
36 | * sysfs_open_dirent for each sysfs_dirent with one or more open | 29 | * sysfs_open_dirent for each sysfs_dirent with one or more open |
@@ -337,11 +330,6 @@ static int sysfs_open_file(struct inode *inode, struct file *file) | |||
337 | struct sysfs_buffer *buffer; | 330 | struct sysfs_buffer *buffer; |
338 | const struct sysfs_ops *ops; | 331 | const struct sysfs_ops *ops; |
339 | int error = -EACCES; | 332 | int error = -EACCES; |
340 | char *p; | ||
341 | |||
342 | p = d_path(&file->f_path, last_sysfs_file, sizeof(last_sysfs_file)); | ||
343 | if (!IS_ERR(p)) | ||
344 | memmove(last_sysfs_file, p, strlen(p) + 1); | ||
345 | 333 | ||
346 | /* need attr_sd for attr and ops, its parent for kobj */ | 334 | /* need attr_sd for attr and ops, its parent for kobj */ |
347 | if (!sysfs_get_active(attr_sd)) | 335 | if (!sysfs_get_active(attr_sd)) |
diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index 23c1e598792a..194414f8298c 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c | |||
@@ -101,9 +101,9 @@ int sysfs_create_group(struct kobject *kobj, | |||
101 | } | 101 | } |
102 | 102 | ||
103 | /** | 103 | /** |
104 | * sysfs_update_group - given a directory kobject, create an attribute group | 104 | * sysfs_update_group - given a directory kobject, update an attribute group |
105 | * @kobj: The kobject to create the group on | 105 | * @kobj: The kobject to update the group on |
106 | * @grp: The attribute group to create | 106 | * @grp: The attribute group to update |
107 | * | 107 | * |
108 | * This function updates an attribute group. Unlike | 108 | * This function updates an attribute group. Unlike |
109 | * sysfs_create_group(), it will explicitly not warn or error if any | 109 | * sysfs_create_group(), it will explicitly not warn or error if any |
@@ -148,6 +148,59 @@ void sysfs_remove_group(struct kobject * kobj, | |||
148 | sysfs_put(sd); | 148 | sysfs_put(sd); |
149 | } | 149 | } |
150 | 150 | ||
151 | /** | ||
152 | * sysfs_merge_group - merge files into a pre-existing attribute group. | ||
153 | * @kobj: The kobject containing the group. | ||
154 | * @grp: The files to create and the attribute group they belong to. | ||
155 | * | ||
156 | * This function returns an error if the group doesn't exist or any of the | ||
157 | * files already exist in that group, in which case none of the new files | ||
158 | * are created. | ||
159 | */ | ||
160 | int sysfs_merge_group(struct kobject *kobj, | ||
161 | const struct attribute_group *grp) | ||
162 | { | ||
163 | struct sysfs_dirent *dir_sd; | ||
164 | int error = 0; | ||
165 | struct attribute *const *attr; | ||
166 | int i; | ||
167 | |||
168 | dir_sd = sysfs_get_dirent(kobj->sd, NULL, grp->name); | ||
169 | if (!dir_sd) | ||
170 | return -ENOENT; | ||
171 | |||
172 | for ((i = 0, attr = grp->attrs); *attr && !error; (++i, ++attr)) | ||
173 | error = sysfs_add_file(dir_sd, *attr, SYSFS_KOBJ_ATTR); | ||
174 | if (error) { | ||
175 | while (--i >= 0) | ||
176 | sysfs_hash_and_remove(dir_sd, NULL, (*--attr)->name); | ||
177 | } | ||
178 | sysfs_put(dir_sd); | ||
179 | |||
180 | return error; | ||
181 | } | ||
182 | EXPORT_SYMBOL_GPL(sysfs_merge_group); | ||
183 | |||
184 | /** | ||
185 | * sysfs_unmerge_group - remove files from a pre-existing attribute group. | ||
186 | * @kobj: The kobject containing the group. | ||
187 | * @grp: The files to remove and the attribute group they belong to. | ||
188 | */ | ||
189 | void sysfs_unmerge_group(struct kobject *kobj, | ||
190 | const struct attribute_group *grp) | ||
191 | { | ||
192 | struct sysfs_dirent *dir_sd; | ||
193 | struct attribute *const *attr; | ||
194 | |||
195 | dir_sd = sysfs_get_dirent(kobj->sd, NULL, grp->name); | ||
196 | if (dir_sd) { | ||
197 | for (attr = grp->attrs; *attr; ++attr) | ||
198 | sysfs_hash_and_remove(dir_sd, NULL, (*attr)->name); | ||
199 | sysfs_put(dir_sd); | ||
200 | } | ||
201 | } | ||
202 | EXPORT_SYMBOL_GPL(sysfs_unmerge_group); | ||
203 | |||
151 | 204 | ||
152 | EXPORT_SYMBOL_GPL(sysfs_create_group); | 205 | EXPORT_SYMBOL_GPL(sysfs_create_group); |
153 | EXPORT_SYMBOL_GPL(sysfs_update_group); | 206 | EXPORT_SYMBOL_GPL(sysfs_update_group); |
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index cffb1fd8ba33..0a12eb89cd32 100644 --- a/fs/sysfs/inode.c +++ b/fs/sysfs/inode.c | |||
@@ -19,6 +19,7 @@ | |||
19 | #include <linux/errno.h> | 19 | #include <linux/errno.h> |
20 | #include <linux/sched.h> | 20 | #include <linux/sched.h> |
21 | #include <linux/slab.h> | 21 | #include <linux/slab.h> |
22 | #include <linux/sysfs.h> | ||
22 | #include <linux/xattr.h> | 23 | #include <linux/xattr.h> |
23 | #include <linux/security.h> | 24 | #include <linux/security.h> |
24 | #include "sysfs.h" | 25 | #include "sysfs.h" |
@@ -348,13 +349,18 @@ int sysfs_hash_and_remove(struct sysfs_dirent *dir_sd, const void *ns, const cha | |||
348 | return -ENOENT; | 349 | return -ENOENT; |
349 | } | 350 | } |
350 | 351 | ||
351 | int sysfs_permission(struct inode *inode, int mask) | 352 | int sysfs_permission(struct inode *inode, int mask, unsigned int flags) |
352 | { | 353 | { |
353 | struct sysfs_dirent *sd = inode->i_private; | 354 | struct sysfs_dirent *sd; |
355 | |||
356 | if (flags & IPERM_FLAG_RCU) | ||
357 | return -ECHILD; | ||
358 | |||
359 | sd = inode->i_private; | ||
354 | 360 | ||
355 | mutex_lock(&sysfs_mutex); | 361 | mutex_lock(&sysfs_mutex); |
356 | sysfs_refresh_inode(sd, inode); | 362 | sysfs_refresh_inode(sd, inode); |
357 | mutex_unlock(&sysfs_mutex); | 363 | mutex_unlock(&sysfs_mutex); |
358 | 364 | ||
359 | return generic_permission(inode, mask, NULL); | 365 | return generic_permission(inode, mask, flags, NULL); |
360 | } | 366 | } |
diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c index f2af22574c50..e34f0d99ea4e 100644 --- a/fs/sysfs/mount.c +++ b/fs/sysfs/mount.c | |||
@@ -23,7 +23,7 @@ | |||
23 | #include "sysfs.h" | 23 | #include "sysfs.h" |
24 | 24 | ||
25 | 25 | ||
26 | static struct vfsmount *sysfs_mount; | 26 | static struct vfsmount *sysfs_mnt; |
27 | struct kmem_cache *sysfs_dir_cachep; | 27 | struct kmem_cache *sysfs_dir_cachep; |
28 | 28 | ||
29 | static const struct super_operations sysfs_ops = { | 29 | static const struct super_operations sysfs_ops = { |
@@ -95,84 +95,63 @@ static int sysfs_set_super(struct super_block *sb, void *data) | |||
95 | return error; | 95 | return error; |
96 | } | 96 | } |
97 | 97 | ||
98 | static int sysfs_get_sb(struct file_system_type *fs_type, | 98 | static void free_sysfs_super_info(struct sysfs_super_info *info) |
99 | int flags, const char *dev_name, void *data, struct vfsmount *mnt) | 99 | { |
100 | int type; | ||
101 | for (type = KOBJ_NS_TYPE_NONE; type < KOBJ_NS_TYPES; type++) | ||
102 | kobj_ns_drop(type, info->ns[type]); | ||
103 | kfree(info); | ||
104 | } | ||
105 | |||
106 | static struct dentry *sysfs_mount(struct file_system_type *fs_type, | ||
107 | int flags, const char *dev_name, void *data) | ||
100 | { | 108 | { |
101 | struct sysfs_super_info *info; | 109 | struct sysfs_super_info *info; |
102 | enum kobj_ns_type type; | 110 | enum kobj_ns_type type; |
103 | struct super_block *sb; | 111 | struct super_block *sb; |
104 | int error; | 112 | int error; |
105 | 113 | ||
106 | error = -ENOMEM; | ||
107 | info = kzalloc(sizeof(*info), GFP_KERNEL); | 114 | info = kzalloc(sizeof(*info), GFP_KERNEL); |
108 | if (!info) | 115 | if (!info) |
109 | goto out; | 116 | return ERR_PTR(-ENOMEM); |
110 | 117 | ||
111 | for (type = KOBJ_NS_TYPE_NONE; type < KOBJ_NS_TYPES; type++) | 118 | for (type = KOBJ_NS_TYPE_NONE; type < KOBJ_NS_TYPES; type++) |
112 | info->ns[type] = kobj_ns_current(type); | 119 | info->ns[type] = kobj_ns_grab_current(type); |
113 | 120 | ||
114 | sb = sget(fs_type, sysfs_test_super, sysfs_set_super, info); | 121 | sb = sget(fs_type, sysfs_test_super, sysfs_set_super, info); |
115 | if (IS_ERR(sb) || sb->s_fs_info != info) | 122 | if (IS_ERR(sb) || sb->s_fs_info != info) |
116 | kfree(info); | 123 | free_sysfs_super_info(info); |
117 | if (IS_ERR(sb)) { | 124 | if (IS_ERR(sb)) |
118 | error = PTR_ERR(sb); | 125 | return ERR_CAST(sb); |
119 | goto out; | ||
120 | } | ||
121 | if (!sb->s_root) { | 126 | if (!sb->s_root) { |
122 | sb->s_flags = flags; | 127 | sb->s_flags = flags; |
123 | error = sysfs_fill_super(sb, data, flags & MS_SILENT ? 1 : 0); | 128 | error = sysfs_fill_super(sb, data, flags & MS_SILENT ? 1 : 0); |
124 | if (error) { | 129 | if (error) { |
125 | deactivate_locked_super(sb); | 130 | deactivate_locked_super(sb); |
126 | goto out; | 131 | return ERR_PTR(error); |
127 | } | 132 | } |
128 | sb->s_flags |= MS_ACTIVE; | 133 | sb->s_flags |= MS_ACTIVE; |
129 | } | 134 | } |
130 | 135 | ||
131 | simple_set_mnt(mnt, sb); | 136 | return dget(sb->s_root); |
132 | error = 0; | ||
133 | out: | ||
134 | return error; | ||
135 | } | 137 | } |
136 | 138 | ||
137 | static void sysfs_kill_sb(struct super_block *sb) | 139 | static void sysfs_kill_sb(struct super_block *sb) |
138 | { | 140 | { |
139 | struct sysfs_super_info *info = sysfs_info(sb); | 141 | struct sysfs_super_info *info = sysfs_info(sb); |
140 | |||
141 | /* Remove the superblock from fs_supers/s_instances | 142 | /* Remove the superblock from fs_supers/s_instances |
142 | * so we can't find it, before freeing sysfs_super_info. | 143 | * so we can't find it, before freeing sysfs_super_info. |
143 | */ | 144 | */ |
144 | kill_anon_super(sb); | 145 | kill_anon_super(sb); |
145 | kfree(info); | 146 | free_sysfs_super_info(info); |
146 | } | 147 | } |
147 | 148 | ||
148 | static struct file_system_type sysfs_fs_type = { | 149 | static struct file_system_type sysfs_fs_type = { |
149 | .name = "sysfs", | 150 | .name = "sysfs", |
150 | .get_sb = sysfs_get_sb, | 151 | .mount = sysfs_mount, |
151 | .kill_sb = sysfs_kill_sb, | 152 | .kill_sb = sysfs_kill_sb, |
152 | }; | 153 | }; |
153 | 154 | ||
154 | void sysfs_exit_ns(enum kobj_ns_type type, const void *ns) | ||
155 | { | ||
156 | struct super_block *sb; | ||
157 | |||
158 | mutex_lock(&sysfs_mutex); | ||
159 | spin_lock(&sb_lock); | ||
160 | list_for_each_entry(sb, &sysfs_fs_type.fs_supers, s_instances) { | ||
161 | struct sysfs_super_info *info = sysfs_info(sb); | ||
162 | /* | ||
163 | * If we see a superblock on the fs_supers/s_instances | ||
164 | * list the unmount has not completed and sb->s_fs_info | ||
165 | * points to a valid struct sysfs_super_info. | ||
166 | */ | ||
167 | /* Ignore superblocks with the wrong ns */ | ||
168 | if (info->ns[type] != ns) | ||
169 | continue; | ||
170 | info->ns[type] = NULL; | ||
171 | } | ||
172 | spin_unlock(&sb_lock); | ||
173 | mutex_unlock(&sysfs_mutex); | ||
174 | } | ||
175 | |||
176 | int __init sysfs_init(void) | 155 | int __init sysfs_init(void) |
177 | { | 156 | { |
178 | int err = -ENOMEM; | 157 | int err = -ENOMEM; |
@@ -189,11 +168,11 @@ int __init sysfs_init(void) | |||
189 | 168 | ||
190 | err = register_filesystem(&sysfs_fs_type); | 169 | err = register_filesystem(&sysfs_fs_type); |
191 | if (!err) { | 170 | if (!err) { |
192 | sysfs_mount = kern_mount(&sysfs_fs_type); | 171 | sysfs_mnt = kern_mount(&sysfs_fs_type); |
193 | if (IS_ERR(sysfs_mount)) { | 172 | if (IS_ERR(sysfs_mnt)) { |
194 | printk(KERN_ERR "sysfs: could not mount!\n"); | 173 | printk(KERN_ERR "sysfs: could not mount!\n"); |
195 | err = PTR_ERR(sysfs_mount); | 174 | err = PTR_ERR(sysfs_mnt); |
196 | sysfs_mount = NULL; | 175 | sysfs_mnt = NULL; |
197 | unregister_filesystem(&sysfs_fs_type); | 176 | unregister_filesystem(&sysfs_fs_type); |
198 | goto out_err; | 177 | goto out_err; |
199 | } | 178 | } |
diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h index d9be60a2e956..2ed2404f3113 100644 --- a/fs/sysfs/sysfs.h +++ b/fs/sysfs/sysfs.h | |||
@@ -9,6 +9,7 @@ | |||
9 | */ | 9 | */ |
10 | 10 | ||
11 | #include <linux/lockdep.h> | 11 | #include <linux/lockdep.h> |
12 | #include <linux/kobject_ns.h> | ||
12 | #include <linux/fs.h> | 13 | #include <linux/fs.h> |
13 | 14 | ||
14 | struct sysfs_open_dirent; | 15 | struct sysfs_open_dirent; |
@@ -135,7 +136,7 @@ struct sysfs_addrm_cxt { | |||
135 | * instance). | 136 | * instance). |
136 | */ | 137 | */ |
137 | struct sysfs_super_info { | 138 | struct sysfs_super_info { |
138 | const void *ns[KOBJ_NS_TYPES]; | 139 | void *ns[KOBJ_NS_TYPES]; |
139 | }; | 140 | }; |
140 | #define sysfs_info(SB) ((struct sysfs_super_info *)(SB->s_fs_info)) | 141 | #define sysfs_info(SB) ((struct sysfs_super_info *)(SB->s_fs_info)) |
141 | extern struct sysfs_dirent sysfs_root; | 142 | extern struct sysfs_dirent sysfs_root; |
@@ -200,7 +201,7 @@ static inline void __sysfs_put(struct sysfs_dirent *sd) | |||
200 | struct inode *sysfs_get_inode(struct super_block *sb, struct sysfs_dirent *sd); | 201 | struct inode *sysfs_get_inode(struct super_block *sb, struct sysfs_dirent *sd); |
201 | void sysfs_evict_inode(struct inode *inode); | 202 | void sysfs_evict_inode(struct inode *inode); |
202 | int sysfs_sd_setattr(struct sysfs_dirent *sd, struct iattr *iattr); | 203 | int sysfs_sd_setattr(struct sysfs_dirent *sd, struct iattr *iattr); |
203 | int sysfs_permission(struct inode *inode, int mask); | 204 | int sysfs_permission(struct inode *inode, int mask, unsigned int flags); |
204 | int sysfs_setattr(struct dentry *dentry, struct iattr *iattr); | 205 | int sysfs_setattr(struct dentry *dentry, struct iattr *iattr); |
205 | int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat); | 206 | int sysfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat); |
206 | int sysfs_setxattr(struct dentry *dentry, const char *name, const void *value, | 207 | int sysfs_setxattr(struct dentry *dentry, const char *name, const void *value, |