diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2014-12-18 14:10:48 -0500 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2015-04-02 21:34:18 -0400 |
commit | c003b26ff98ca04a180ff34c38c007a3998d62f9 (patch) | |
tree | 0d48f9edeed164c03b02494cf129ef76a0ffb91c /fs/pnode.c | |
parent | 8318e667f176f7ea34451a1a530634e293f216ac (diff) |
mnt: In umount_tree reuse mnt_list instead of mnt_hash
umount_tree builds a list of mounts that need to be unmounted.
Utilize mnt_list for this purpose instead of mnt_hash. This begins to
allow keeping a mount on the mnt_hash after it is unmounted, which is
necessary for a properly functioning MNT_LOCKED implementation.
The fact that mnt_list is an ordinary list makding available list_move
is nice bonus.
Cc: stable@vger.kernel.org
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'fs/pnode.c')
-rw-r--r-- | fs/pnode.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/pnode.c b/fs/pnode.c index 260ac8f898a4..bf012af709dd 100644 --- a/fs/pnode.c +++ b/fs/pnode.c | |||
@@ -384,7 +384,7 @@ static void __propagate_umount(struct mount *mnt) | |||
384 | if (child && list_empty(&child->mnt_mounts)) { | 384 | if (child && list_empty(&child->mnt_mounts)) { |
385 | list_del_init(&child->mnt_child); | 385 | list_del_init(&child->mnt_child); |
386 | hlist_del_init_rcu(&child->mnt_hash); | 386 | hlist_del_init_rcu(&child->mnt_hash); |
387 | hlist_add_before_rcu(&child->mnt_hash, &mnt->mnt_hash); | 387 | list_move_tail(&child->mnt_list, &mnt->mnt_list); |
388 | } | 388 | } |
389 | } | 389 | } |
390 | } | 390 | } |
@@ -396,11 +396,11 @@ static void __propagate_umount(struct mount *mnt) | |||
396 | * | 396 | * |
397 | * vfsmount lock must be held for write | 397 | * vfsmount lock must be held for write |
398 | */ | 398 | */ |
399 | int propagate_umount(struct hlist_head *list) | 399 | int propagate_umount(struct list_head *list) |
400 | { | 400 | { |
401 | struct mount *mnt; | 401 | struct mount *mnt; |
402 | 402 | ||
403 | hlist_for_each_entry(mnt, list, mnt_hash) | 403 | list_for_each_entry(mnt, list, mnt_list) |
404 | __propagate_umount(mnt); | 404 | __propagate_umount(mnt); |
405 | return 0; | 405 | return 0; |
406 | } | 406 | } |