diff options
author | Jan Kara <jack@suse.cz> | 2014-12-10 18:41:45 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-12-10 20:41:03 -0500 |
commit | f5425fcea72eec084c50f36db4d25f697227c602 (patch) | |
tree | 764b95d26d3f9a0cda8e93d4fb405ad9f1d26a8e /fs/ocfs2 | |
parent | 4a635a113bfe1eaa184410d6b6065cd8eee13607 (diff) |
ocfs2: report error from o2hb_do_disk_heartbeat() to user
Report return value of o2hb_do_disk_heartbeat() as a part of ML_HEARTBEAT
message so that we know whether a heartbeat actually happened or not.
This also makes assigned but otherwise unused 'ret' variable used.
Coverity id: 1227053.
Signed-off-by: Jan Kara <jack@suse.cz>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ocfs2')
-rw-r--r-- | fs/ocfs2/cluster/heartbeat.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c index eb9d48746ab4..16eff45727ee 100644 --- a/fs/ocfs2/cluster/heartbeat.c +++ b/fs/ocfs2/cluster/heartbeat.c | |||
@@ -1127,10 +1127,10 @@ static int o2hb_thread(void *data) | |||
1127 | elapsed_msec = o2hb_elapsed_msecs(&before_hb, &after_hb); | 1127 | elapsed_msec = o2hb_elapsed_msecs(&before_hb, &after_hb); |
1128 | 1128 | ||
1129 | mlog(ML_HEARTBEAT, | 1129 | mlog(ML_HEARTBEAT, |
1130 | "start = %lu.%lu, end = %lu.%lu, msec = %u\n", | 1130 | "start = %lu.%lu, end = %lu.%lu, msec = %u, ret = %d\n", |
1131 | before_hb.tv_sec, (unsigned long) before_hb.tv_usec, | 1131 | before_hb.tv_sec, (unsigned long) before_hb.tv_usec, |
1132 | after_hb.tv_sec, (unsigned long) after_hb.tv_usec, | 1132 | after_hb.tv_sec, (unsigned long) after_hb.tv_usec, |
1133 | elapsed_msec); | 1133 | elapsed_msec, ret); |
1134 | 1134 | ||
1135 | if (!kthread_should_stop() && | 1135 | if (!kthread_should_stop() && |
1136 | elapsed_msec < reg->hr_timeout_ms) { | 1136 | elapsed_msec < reg->hr_timeout_ms) { |