diff options
author | Alexey Dobriyan <adobriyan@gmail.com> | 2006-09-27 04:49:40 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-27 11:26:10 -0400 |
commit | 1a1d92c10dd24bbdc28b3d6e2d03ec199dd3a65b (patch) | |
tree | fade83955f75e718e39153d6f81d221403338bed /fs/ocfs2 | |
parent | f52720ca5f48574e347dff35ffe6b389ace61537 (diff) |
[PATCH] Really ignore kmem_cache_destroy return value
* Rougly half of callers already do it by not checking return value
* Code in drivers/acpi/osl.c does the following to be sure:
(void)kmem_cache_destroy(cache);
* Those who check it printk something, however, slab_error already printed
the name of failed cache.
* XFS BUGs on failed kmem_cache_destroy which is not the decision
low-level filesystem driver should make. Converted to ignore.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/ocfs2')
-rw-r--r-- | fs/ocfs2/dlm/dlmfs.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/ocfs2/dlm/dlmfs.c b/fs/ocfs2/dlm/dlmfs.c index 033ad1701232..0ff0898a0b9c 100644 --- a/fs/ocfs2/dlm/dlmfs.c +++ b/fs/ocfs2/dlm/dlmfs.c | |||
@@ -629,9 +629,7 @@ static void __exit exit_dlmfs_fs(void) | |||
629 | flush_workqueue(user_dlm_worker); | 629 | flush_workqueue(user_dlm_worker); |
630 | destroy_workqueue(user_dlm_worker); | 630 | destroy_workqueue(user_dlm_worker); |
631 | 631 | ||
632 | if (kmem_cache_destroy(dlmfs_inode_cache)) | 632 | kmem_cache_destroy(dlmfs_inode_cache); |
633 | printk(KERN_INFO "dlmfs_inode_cache: not all structures " | ||
634 | "were freed\n"); | ||
635 | } | 633 | } |
636 | 634 | ||
637 | MODULE_AUTHOR("Oracle"); | 635 | MODULE_AUTHOR("Oracle"); |